Page MenuHomePhabricator
Feed Advanced Search

Jul 18 2015

epriestley closed T8890: releeph: Call to undefined method PHUIObjectItemListView::getActions() as Resolved.

Restart Apache or PHP-FPM, according to the upgrade guide:

Jul 18 2015, 9:43 PM · Releeph
• Anett awarded T8887: Allow owners packages to add blocking reviewers a Like token.
Jul 18 2015, 5:12 PM · Haskell.org, Restricted Project, Owners
epriestley added a revision to T8726: Modularize Herald fields and actions: Unknown Object (Differential Revision).
Jul 18 2015, 1:07 PM · Herald
epriestley added a comment to T8871: Indexing a task with 2,000 comments required a lot of RAM in mid-2015.

That isn't a great solution - it should be possible to set a max ram used, rather than max percent free

Jul 18 2015, 12:20 PM · Search, Daemons
epriestley added a comment to T8871: Indexing a task with 2,000 comments required a lot of RAM in mid-2015.

Shouldn't we do something similar by default?

Jul 18 2015, 12:17 PM · Search, Daemons
joshuaspence added a comment to T8885: Application pin button is misaligned.
In T8885#126858, @chad wrote:

Also, #phui is the best tag for these, which is "Phabricator UI". Maybe a good way to think about it is #design is pre-commit, #phui is post-commit. :)

Jul 18 2015, 4:05 AM · PHUI, User Preferences
joshuaspence created T8887: Allow owners packages to add blocking reviewers.
Jul 18 2015, 3:34 AM · Haskell.org, Restricted Project, Owners
joshuaspence created T8886: External account overflows bounding box.
Jul 18 2015, 2:53 AM · User Preferences, Mobile
joshuaspence added a comment to T8882: Convert "serious business" mode to a locale.

Yeah that's true. Good point.

Jul 18 2015, 2:49 AM · Localization
epriestley added a comment to T8879: Prompt user to enter instance name when disabling instance on Phacility.

This is the dialog you had trouble with, right?

Jul 18 2015, 2:49 AM · Phacility
epriestley closed T8882: Convert "serious business" mode to a locale as Wontfix.

Then we'd need serious + non-serious locales in every language.

Jul 18 2015, 2:48 AM · Localization
joshuaspence created T8885: Application pin button is misaligned.
Jul 18 2015, 2:48 AM · PHUI, User Preferences
epriestley added a comment to T8881: Ask 2nd confirmation when disabling instance on Phacility.

Just to make sure, this is the dialog you confirmed your way through by accident?

Jul 18 2015, 2:47 AM · Phacility
joshuaspence created T8884: Show a setup warning when only some daemons are running.
Jul 18 2015, 2:41 AM · Restricted Project, Daemons
joshuaspence created T8883: Allow desktop notifications to replace normal notifications.
Jul 18 2015, 2:36 AM · Notifications
joshuaspence created T8882: Convert "serious business" mode to a locale.
Jul 18 2015, 2:30 AM · Localization
joshuaspence created T8878: Make desktop notifications more discoverable.
Jul 18 2015, 1:57 AM · User Preferences, Notifications
joshuaspence added a comment to T8871: Indexing a task with 2,000 comments required a lot of RAM in mid-2015.

Shouldn't we do something similar by default?

Jul 18 2015, 1:55 AM · Search, Daemons
joshuaspence added a comment to T8875: V4 support for Phabricator's S3 File backend.

I found it interesting that S3 got interpreted as remarkup. I wonder if we should blacklist it from being matched similar to Q1, etc.

Jul 18 2015, 1:54 AM · Files

Jul 17 2015

epriestley added a revision to T8726: Modularize Herald fields and actions: Unknown Object (Differential Revision).
Jul 17 2015, 5:31 PM · Herald
epriestley added a comment to T8812: Herald Rule does not send mails.

I'll try to make this more clear after T8726.

Jul 17 2015, 5:03 PM · Herald
epriestley renamed T8876: Fix weird object name on Fund Initiatives from Fix weird object name on initiatives to Fix weird object name on Fund Initiatives.
Jul 17 2015, 4:48 PM · Fund
epriestley created T8876: Fix weird object name on Fund Initiatives.
Jul 17 2015, 4:47 PM · Fund
epriestley added a revision to T8726: Modularize Herald fields and actions: Unknown Object (Differential Revision).
Jul 17 2015, 3:19 PM · Herald
epriestley added a comment to T8812: Herald Rule does not send mails.

Note that in this case and in the T8863 case, mail recipients must now be able to see objects (e.g., revisions and repositories) to receive email about them. It's possible that that's the source of this issue.

Jul 17 2015, 2:34 PM · Herald
epriestley added a comment to T8812: Herald Rule does not send mails.

I can't reproduce this. Here's a rule I wrote:

Jul 17 2015, 2:32 PM · Herald
epriestley added a comment to D13639: Prevent 'Start or Wait for Build Plan' from running disabled build plans.

I think this scenario would be better handled with a "Skip" or "Pass" build step than treating disabled plans as automatic passes. That behavior seems very unintuitive to me.

Jul 17 2015, 1:59 PM
epriestley triaged T8875: V4 support for Phabricator's S3 File backend as Wishlist priority.
Jul 17 2015, 1:57 PM · Files
epriestley closed T8864: Arcanist staleness control as Invalid.

We already have such a mechanism.

Jul 17 2015, 1:57 PM · Arcanist
epriestley closed T8867: Add "Editable by" field to top-level project details page as Wontfix.

You can click "Edit Project" to figure out what the policy is (it will either show you or tell you). This request doesn't really describe a problem.

Jul 17 2015, 1:56 PM · Projects
epriestley closed T8866: PhutilJSONParserException error when access phabricator/T2050 page. as Resolved.
Jul 17 2015, 1:50 PM · Maniphest
epriestley added a comment to T8871: Indexing a task with 2,000 comments required a lot of RAM in mid-2015.

Use --autoscale-reserve to prevent them from autoscaling past some amount of memory. For example, this will prevent autoscaling if less than 25% of RAM is free:

Jul 17 2015, 1:49 PM · Search, Daemons
epriestley closed T8872: phabricator admin Login Failure as Invalid.

This report doesn't have enough information for us to reproduce the issue. See the documentation here:

Jul 17 2015, 1:47 PM · Auth
joshuaspence added a comment to T8864: Arcanist staleness control.

I don't think our users would want to update Arcanist as often as I am updating Phabricator.

Jul 17 2015, 7:44 AM · Arcanist
joshuaspence closed T8847: Brace placement linter rule as Resolved by committing Restricted Diffusion Commit.
Jul 17 2015, 6:41 AM · Lint
joshuaspence created T8871: Indexing a task with 2,000 comments required a lot of RAM in mid-2015.
Jul 17 2015, 4:28 AM · Search, Daemons
joshuaspence created T8869: Issue with ArcanistDoubleQuoteXHPASTLinterRule.
Jul 17 2015, 3:22 AM · Lint
chad awarded T8862: Fix "1 reviewer(s)" translation string for Differential feed stories a Pterodactyl token.
Jul 17 2015, 1:03 AM · Differential

Jul 16 2015

joshuaspence added a comment to T8864: Arcanist staleness control.

Another option would be to allow a minimum version to be specified server-side. As in, Phabricator reports a minimum version commit hash which is either maintained in the code itself or overriden by admins.

Jul 16 2015, 11:55 PM · Arcanist
joshuaspence added a comment to T8864: Arcanist staleness control.

Also, 99% of the time when people ask me for help with Arcanist its just a matter of running arc upgrade.

Jul 16 2015, 11:53 PM · Arcanist
joshuaspence added a comment to T8864: Arcanist staleness control.

Interesting idea. Composer gives some sort of warning if it is more than 30 days old... Maybe something similar would be useful for Arcanist.

Jul 16 2015, 11:52 PM · Arcanist
joshuaspence created T8865: Automatically compact storage.
Jul 16 2015, 11:47 PM · Files
joshuaspence added a comment to T8007: Commit was associated with unrelated diff.

This is interesting. We had an abandoned diff which got closed by ./bin/repository reparse. If I click on "Explain Why" then it says We didn't find a "Differential Revision" field in the commit message. That doesn't really make sense to me, is this a bug?

Jul 16 2015, 11:06 PM · Differential, Diffusion
joshuaspence added a comment to T8007: Commit was associated with unrelated diff.

This happened again today. I ran for REPO in $(./bin/repository list); do ./bin/repository reparse --message $REPO; done and a whole lot of badness ensued.

Jul 16 2015, 11:04 PM · Differential, Diffusion
epriestley closed T5016: Allow Herald rules for Maniphest to act on custom task fields as Resolved by committing Restricted Diffusion Commit.
Jul 16 2015, 9:12 PM · Custom Fields, Herald
epriestley created T8862: Fix "1 reviewer(s)" translation string for Differential feed stories.
Jul 16 2015, 8:50 PM · Differential
epriestley removed a reviewer for D13607: aaa呵呵: Blessed Reviewers.
Jul 16 2015, 8:45 PM
epriestley removed a reviewer for D13610: 测试是否所有人可见: Blessed Reviewers.
Jul 16 2015, 8:45 PM
epriestley removed a reviewer for D13611: test audit: Blessed Reviewers.
Jul 16 2015, 8:44 PM
epriestley requested changes to D13639: Prevent 'Start or Wait for Build Plan' from running disabled build plans.

Why is this passing instead of failing?

Jul 16 2015, 8:41 PM
epriestley triaged T8858: Allow storing binary files in Passphrase as Wishlist priority.
Jul 16 2015, 8:38 PM · Passphrase
epriestley added a comment to T8861: Updating a revision with dependencies pulls all diffs from dependencies by default.

Use arc which to understand what arc is doing and why.

Jul 16 2015, 8:38 PM · Arcanist
epriestley edited P1826 ssh-keygen.
Jul 16 2015, 8:26 PM
epriestley merged task T8857: Make Git commit / message parsers eventually fail or de-prioritize on failure into T5955: Refactor Conduit auth to be stateless, token-based, and support wire encodings.
Jul 16 2015, 7:42 PM · Daemons
epriestley merged T8857: Make Git commit / message parsers eventually fail or de-prioritize on failure into T5955: Refactor Conduit auth to be stateless, token-based, and support wire encodings.
Jul 16 2015, 7:42 PM · Restricted Project, Auth, Conduit
epriestley edited the content of 2011-05 May - 2011-07 July.
Jul 16 2015, 7:37 PM
epriestley edited the content of Changelog.
Jul 16 2015, 7:36 PM
epriestley edited the content of Welcome.
Jul 16 2015, 7:36 PM
epriestley deleted Demo Page.
Jul 16 2015, 7:25 PM
20after4 awarded T6049: Implement Phurl, a URL shortener/bookmarking application a Love token.
Jul 16 2015, 5:43 PM · Phurl
epriestley closed T8860: Test task as Resolved.
Jul 16 2015, 3:37 PM
epriestley renamed T8667: Don't index Diviner sub-atoms in global search from Search should allow "Not" functions when selecting document types to Don't index Diviner sub-atoms in global search.
Jul 16 2015, 3:25 PM · Diviner
epriestley added a comment to T8667: Don't index Diviner sub-atoms in global search.

Currently, these results are essentially never useful to anyone, so I don't think the proposed solution (adding difficult-to-discovery complexity to the typeahead) is very good. Instead, we should improve the quality of the search results. For example, only indexing top-level atoms (in PHP, classes and functions). I believe we already have the concept of "top-level" in Diviner.

Jul 16 2015, 3:23 PM · Diviner
epriestley renamed T8850: Add a setup warning to make sure users haven't wiped out $_SERVER['REMOTE_ADDR'] from Creating new user raises: #1048: Column 'remoteAddr' cannot be null to Add a setup warning to make sure users haven't wiped out $_SERVER['REMOTE_ADDR'].
Jul 16 2015, 3:17 PM · Contributor Onboarding, Setup
epriestley added a comment to T8857: Make Git commit / message parsers eventually fail or de-prioritize on failure.

Why are they failing?

Jul 16 2015, 3:12 PM · Daemons
epriestley updated subscribers of T8320: Bring Owners out of the dark ages.
Jul 16 2015, 3:11 PM · Prioritized, Owners
epriestley merged task T8859: Find Owners link in Diffusion leads to a 404 /owners/view/search into T8320: Bring Owners out of the dark ages.
Jul 16 2015, 3:11 PM · Owners, Diffusion
joshuaspence created T8858: Allow storing binary files in Passphrase.
Jul 16 2015, 3:54 AM · Passphrase
epriestley added a comment to T8854: Display unit test results on home view.

(I believe) get a warning on the command-line if you try to land when tests are failing/not yet reported.

Jul 16 2015, 12:19 AM · Unit, Arcanist, Restricted Project
epriestley added a comment to T8854: Display unit test results on home view.

This would discourage people from landing in the situation where a diff has passed CR but hasn't passed tests.

Jul 16 2015, 12:19 AM · Unit, Arcanist, Restricted Project

Jul 15 2015

epriestley closed T8805: Improve error checking for third-party unit test engines as Resolved by committing Restricted Diffusion Commit.
Jul 15 2015, 8:26 PM · Arcanist
epriestley added a revision to T8805: Improve error checking for third-party unit test engines: Unknown Object (Differential Revision).
Jul 15 2015, 7:34 PM · Arcanist
epriestley added a comment to T8848: Add policy support to hosted repositories for allowing pushing branches or tags.

T8644 also discusses writing a "recipe book" for Herald, since there are a lot of things like this which it's powerful enough to do but where the pathway isn't necessarily obvious.

Jul 15 2015, 5:21 PM · Diffusion
epriestley added a comment to T8848: Add policy support to hosted repositories for allowing pushing branches or tags.

Oh, I suppose there's actually no way to specify "Administrators", per se, right now. We could maybe add one after T8726 wraps up.

Jul 15 2015, 5:14 PM · Diffusion
epriestley removed 1 mock(s) for T8830: `bin/remove destroy` is dangerous and leaves dangling edges: Unknown Object (Pholio Mock).
Jul 15 2015, 5:13 PM · Infrastructure, Restricted Project
epriestley added a comment to T7410: Allow a project's workboard to be disabled so that tagged tasks no longer show meaningless "(Backlog)".

its information content is 0.

Jul 15 2015, 5:12 PM · Projects, Wikimedia, Workboards

Jul 14 2015

epriestley added a comment to T8848: Add policy support to hosted repositories for allowing pushing branches or tags.

Can you use a Herald rule like this?

Jul 14 2015, 11:22 PM · Diffusion
joshuaspence added a revision to T8847: Brace placement linter rule: Unknown Object (Differential Revision).
Jul 14 2015, 10:29 PM · Lint
joshuaspence created T8847: Brace placement linter rule.
Jul 14 2015, 10:02 PM · Lint
haldyr awarded T3993: Build a global menu item showing the current Phrequent stack a Love token.
Jul 14 2015, 6:13 PM · Phrequent
epriestley added a comment to T8455: Herald rules with mailing lists are broken after mailing list -> user migration.

Do you still happen to have the original error message? That was unexpected, and the migration specifically accounted for the case of email collisions and I recall testing that case locally in detail, so I'm curious what I missed. The expected behavior is that that list wouldn't migrate (and would emit a message), but other lists would:

Jul 14 2015, 2:43 PM · Herald, Mailing Lists, Restricted Project
epriestley added a comment to T7484: Lock is not locked by this process.

I can write a lock log for this but it's going to add a huge amount of complexity and basically amount to implementing locks ourselves from scratch. However, I don't see any other way forward.

Jul 14 2015, 2:32 PM · Restricted Project, Daemons
epriestley added a comment to T8830: `bin/remove destroy` is dangerous and leaves dangling edges.

Locally, edge destruction works correctly. Here's a complete log:

Jul 14 2015, 2:29 PM · Infrastructure, Restricted Project
epriestley added a comment to T8830: `bin/remove destroy` is dangerous and leaves dangling edges.

Can you also enumerate exactly what problems you have with bin/remove destroy on tasks at HEAD? The expectation is that all these relationships are destroyed:

Jul 14 2015, 2:27 PM · Infrastructure, Restricted Project
epriestley added a comment to T8836: Unhandled Exception when dragging a card on workboards (not affecting all projects, may need help to investigate the cause).

This is almost certainly fixed by outstanding changes to Herald which are awaiting review. See also T8822.

Jul 14 2015, 2:23 PM · Herald
epriestley added a comment to T8835: Replacement for actAsUser in Conduit API.

We don't plan to restore actAsUser in any form to the upstream, since it violates policies and can not be made safe (in the sense of not-policy-violating).

Jul 14 2015, 2:20 PM · Restricted Project, Conduit
epriestley merged task T8837: XUnit parser generates results with a stringy duration into T8805: Improve error checking for third-party unit test engines.
Jul 14 2015, 2:16 PM · Arcanist
epriestley updated subscribers of T8805: Improve error checking for third-party unit test engines.
Jul 14 2015, 2:16 PM · Arcanist
epriestley added a comment to T3855: `arc land` should work when the current branch/bookmark and the target branch/bookmark are the same.

T8833 is also "arc land should restore state after a failure".

Jul 14 2015, 2:16 PM · Restricted Project, Arcanist
epriestley updated subscribers of T3855: `arc land` should work when the current branch/bookmark and the target branch/bookmark are the same.
Jul 14 2015, 2:15 PM · Restricted Project, Arcanist
epriestley merged task T8833: Branch state not preserved during arc land with a failed pre-receive hook into T3855: `arc land` should work when the current branch/bookmark and the target branch/bookmark are the same.
Jul 14 2015, 2:15 PM · Restricted Project, Arcanist
epriestley added a comment to T8833: Branch state not preserved during arc land with a failed pre-receive hook.

It is currently intentional that arc land does not restore state after a push failure.

Jul 14 2015, 2:15 PM · Restricted Project, Arcanist
epriestley added a comment to T8834: Remove Calendar/Files from Conpherence.

Yeah, I think we're likely to remove this. It generally needs a lot of effort to modernize even if we're going to keep it.

Jul 14 2015, 2:07 PM · Calendar, Conpherence

Jul 12 2015

johnny-bit awarded T6526: Implement "Badges" or "Medals", for annotating special users a Like token.
Jul 12 2015, 6:53 AM · Restricted Project, Badges (v0), People
hach-que awarded T6526: Implement "Badges" or "Medals", for annotating special users a Like token.
Jul 12 2015, 12:15 AM · Restricted Project, Badges (v0), People
hach-que awarded T6526: Implement "Badges" or "Medals", for annotating special users a Piece of Eight token.
Jul 12 2015, 12:15 AM · Restricted Project, Badges (v0), People

Jul 11 2015

tycho.tatitscheff awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Pterodactyl token.
Jul 11 2015, 6:46 AM · Workboards (v3), Restricted Project

Jul 10 2015

epriestley updated subscribers of T4136: Project options shown in Policy control should be smarter and more powerful.
Jul 10 2015, 6:33 PM · Policy, Projects
epriestley merged task T8819: Limiting "Can Create Spaces" to "Administrators" causes usability issues into T4136: Project options shown in Policy control should be smarter and more powerful.
Jul 10 2015, 6:33 PM · Policy, Spaces
epriestley added a comment to T8823: Unhandled Exception ("AphrontQueryException") when searching.

Try this:

Jul 10 2015, 6:11 PM · Search