Page MenuHomePhabricator

Allow owners packages to add blocking reviewers
Closed, ResolvedPublic

Assigned To
None
Authored By
joshuaspence
Jul 18 2015, 3:34 AM
Tags
Tokens
"Love" token, awarded by Luke081515.2."Piece of Eight" token, awarded by thoughtpolice."Haypence" token, awarded by joshuaspence."Like" token, awarded by Anett.

Description

I've started using Owners packages instead of Herald rules. Owners packages are generally more powerful when a package spans multiple repositories or when the repository structure is likely go change (in which case regexes for Herald rules would need to be updated... Actually I'm not sure if Owners packages paths are updated when files in the package are moved, but it is certainly possible).

One thing that's great about using Owners is that I don't need to setup a Herald rule for auditing unreviewed commits, I get this functionality for free. I do, however, still need to setup one or more Herald rules for Differential, to add blocking reviewers when packages are modified. It would be great if Owners could support this use case natively.

Event Timeline

joshuaspence raised the priority of this task from to Needs Triage.
joshuaspence updated the task description. (Show Details)
joshuaspence added a project: Owners.
joshuaspence added a subscriber: joshuaspence.
eadler added a project: Restricted Project.Feb 18 2016, 10:08 PM
eadler moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.
eadler edited projects, added Restricted Project; removed Restricted Project.Feb 26 2016, 7:56 PM
eadler moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Mar 18 2016, 4:48 PM
eadler moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Apr 18 2016, 12:25 AM
eadler edited projects, added Restricted Project; removed Restricted Project.
eadler moved this task to Restricted Project Column on the Restricted Project board.May 13 2016, 6:02 PM