Page MenuHomePhabricator

Make Git commit / message parsers eventually fail or de-prioritize on failure
Closed, DuplicatePublic

Description

From IRC:

<hachque> hey epriestley
<hachque> can we make the git commit / message parser have either a maximum failure
<hachque> or make the retry time exponential
<hachque> or make them deprioritized when they fail?
<hachque> because our queue just ends up like this https://secure.phabricator.com/F627219
<hachque> and i have to manually go and fail the tasks

pasted_file (863×1 px, 230 KB)

Event Timeline

hach-que assigned this task to epriestley.
hach-que raised the priority of this task from to Needs Triage.
hach-que updated the task description. (Show Details)
hach-que added a project: Daemons.
hach-que added a subscriber: hach-que.

Invalid utf8 for JSON encoding. Basically until phabricator has a binary wire format for conduit that can handle invalid character sets, these commits will always fail.

Since the binary wire format is reasonably low on the upstream priority (it literally only affects us because everyone else uses phabricator in a non-HA setup or runs daemons on the storage tier), we'd much rather just have the commits fail for now and reparse them when the binary wire format is available.