Page MenuHomePhabricator
Create Task
Maniphest T8865

Automatically compact storage
Closed, WontfixPublic
Actions

Description

Every now and then I run ./bin/files compact and see a whole bunch of files compacted. We could probably be a bit smarter with this and do this automatically. I'm guessing that we don't do this automatically because there is a risk that we get it wrong and destroy a file inadvertently, but maybe this isn't a real issue.

Event Timeline

joshuaspence created this task.Jul 16 2015, 11:47 PM
joshuaspence raised the priority of this task from to Needs Triage.
joshuaspence updated the task description. (Show Details)
joshuaspence added a project: Files.
joshuaspence added a subscriber: joshuaspence.
epriestley added a subscriber: epriestley.Sep 27 2015, 1:41 PM

bin/files compact shouldn't normally do much of anything; the better fix might be to identify what's causing these files to be written despite being compactable and stop it from doing that. My expectation is that all file writing callsites should automatically reuse storage if possible in modern code.

epriestley moved this task from Backlog to vNext on the Files board.Nov 24 2015, 5:18 PM
eadler added a subscriber: eadler.Apr 14 2016, 4:56 AM
epriestley closed this task as Wontfix.Jul 18 2016, 7:51 PM
epriestley claimed this task.

Per above, I'd like to just fix issues here rather than add an automatic compaction process. I don't currently know how to generate un-compact files in modern code.

Phabricator · Built by Phacility