Page MenuHomePhabricator
Feed Advanced Search

Mar 9 2017

chad updated subscribers of T12369: Users sometimes prompted to "Edit Locked Task" when attempting to create a new task.

There is definitely a bug here, I just have no idea what configuration of forms leads to it. @epriestley might have other guesses.

Mar 9 2017, 4:43 PM · Bug Report, EditEngine
d.maznekov added a comment to T12369: Users sometimes prompted to "Edit Locked Task" when attempting to create a new task.

I'll wait Friday stable.... today I've switched from stable to master branch. The install is if I can say untouched and every Friday updated.
Just git pull in 3 dirs and that's all. Use well known bash script for that. All customization and setups are stored in SQL database.
What else steps to report - just pressing New task and appears that.
Is it an option to clean up folder and make clean git clone ?
If tomorrow stable don't resolve that nasty problem will proceed with clean install.

Mar 9 2017, 4:04 PM · Bug Report, EditEngine
epriestley added a comment to T12373: Support macros in Phame.

That is, the problem would be:

Mar 9 2017, 3:37 PM · Macros, Phame, Bug Report
epriestley added a comment to T12373: Support macros in Phame.

I guess we actually have to test this use case:

Mar 9 2017, 3:36 PM · Macros, Phame, Bug Report
chad added a comment to T12373: Support macros in Phame.

I can fix if it's one line, I just assumed it was something super hard with external urls or something.

Mar 9 2017, 3:32 PM · Macros, Phame, Bug Report
chad added a comment to T12373: Support macros in Phame.

I blame the fun police.

Mar 9 2017, 3:32 PM · Macros, Phame, Bug Report
epriestley added a comment to T12373: Support macros in Phame.

https://secure.phabricator.com/source/phabricator/browse/master/src/infrastructure/markup/PhabricatorMarkupEngine.php;4c7d464f8bf2627ef7455596fde2ae5667e67a57$356

Mar 9 2017, 3:27 PM · Macros, Phame, Bug Report
epriestley updated subscribers of T12373: Support macros in Phame.

Macros are disabled in Phame posts, via markup engine. This originated in D2202.

Mar 9 2017, 3:27 PM · Macros, Phame, Bug Report
cspeckmim added a comment to T12370: Maniphest menu items misalign if they have submenu items.

youreawesome

Mar 9 2017, 3:27 PM · Bug Report
chad closed T12370: Maniphest menu items misalign if they have submenu items as Resolved by committing Restricted Diffusion Commit.
Mar 9 2017, 3:25 PM · Bug Report
epriestley claimed T12378: "This task has been locked" on all logged out tasks.

I think the way the view gets built is a little odd and I didn't get the logic quite right. Definitely a bug, thanks.

Mar 9 2017, 3:16 PM · Maniphest, EditEngine
chad added projects to T12378: "This task has been locked" on all logged out tasks: EditEngine, Maniphest.
Mar 9 2017, 3:05 PM · Maniphest, EditEngine
chad added a comment to T12375: Integrate Conduit API for Policy Object Creation.

We'd want to know the root problem you're having with Phabricator specifically so that we could decide the best way to resolve the issue in the upstream. Can you go into more detail about the custom policies you're wanting to create, how often, what they do, etc?

Mar 9 2017, 3:03 PM · Policy, Feature Request
chad created T12378: "This task has been locked" on all logged out tasks.
Mar 9 2017, 2:48 PM · Maniphest, EditEngine
chad closed T12377: S3 cannot migrate / upload files as Wontfix.
Mar 9 2017, 2:45 PM · Bug Report
chad added a comment to T12369: Users sometimes prompted to "Edit Locked Task" when attempting to create a new task.

Thanks, but we really just need the steps to reproduce the issue locally. I don't know them, I have no guesses as to how to get an installation to do that. Without knowing how to reproduce your bug specifically, we have no idea what to look for or if we're fixing the correct bug. This is a huge time burden for us, and is outside what we cover under "free support". We require every bug report to provide these steps for us, since Phabricator is a free product.

Mar 9 2017, 2:42 PM · Bug Report, EditEngine
remusvrm closed Q586: Is there a reason way I can not add a subscriber to a question in Ponder? as resolved.
Mar 9 2017, 1:54 PM · Ponder
remusvrm added Q586: Is there a reason way I can not add a subscriber to a question in Ponder? (Answer 527).
Mar 9 2017, 1:54 PM
remusvrm updated Q586: Is there a reason way I can not add a subscriber to a question in Ponder? from to Is there a reason way I can not add a subscriber to a question in Ponder?.
Mar 9 2017, 1:41 PM · Ponder
rlex added a comment to T12377: S3 cannot migrate / upload files.

Ok, i'm an idiot.
I configured wrong endpoint.
It's working now.
Still, it might be good idea for mentioning this policy in install doc - it's not really obvious that you need

"Effect": "Allow",
"Action": "s3:ListAllMyBuckets",
"Resource": "arn:aws:s3:::*"

For IAM policy to work.

Mar 9 2017, 1:37 PM · Bug Report
rlex added a comment to T12377: S3 cannot migrate / upload files.

Probably worth mentioning that this creds are configured using IAM instead of root creds.
Policy for this user:

{
    "Version": "2012-10-17",
    "Statement": [
        {
            "Effect": "Allow",
            "Action": "s3:ListAllMyBuckets",
            "Resource": "arn:aws:s3:::*"
        },
        {
            "Effect": "Allow",
            "Action": "s3:*",
            "Resource": [
                "arn:aws:s3:::files.example.com",
                "arn:aws:s3:::files.example.com/*"
            ]
        }
    ]
}
Mar 9 2017, 1:29 PM · Bug Report
rlex created T12377: S3 cannot migrate / upload files.
Mar 9 2017, 1:27 PM · Bug Report
mrybczyn created T12376: Export workboard columns for reporting.
Mar 9 2017, 1:25 PM · Feature Request
stettberger created T12375: Integrate Conduit API for Policy Object Creation.
Mar 9 2017, 1:11 PM · Policy, Feature Request
jkrets added a project to T12374: Saved Workboard Queries: Workboards.
Mar 9 2017, 11:50 AM · Workboards, Feature Request
jkrets created T12374: Saved Workboard Queries.
Mar 9 2017, 10:44 AM · Workboards, Feature Request
RJVB added a comment to T5029: Fill in missing context for low-context diffs against tracked repositories.
Mar 9 2017, 10:10 AM · KDE, Restricted Project, Diffusion, Differential
bcooksley added a comment to T12368: better support for "raw" patches, in particular corresponding to uncommitted changes?.

@epriestley my apologies for this. I had sent out a memo previously asking for everyone to file tasks on our Phabricator so that I could co-ordinate things from there. It seems some folks have missed that, so i've now resent it to a wider audience.

Mar 9 2017, 9:05 AM · KDE, Feature Request (Needs Information)
d.maznekov added a comment to T12369: Users sometimes prompted to "Edit Locked Task" when attempting to create a new task.

Usual "here in my machine works fine".
Hereby is screenrecord to convince you
http://srecorder.com/s/3huk
Or just give a joker where to look after for raised flag of locked task or like that.

Mar 9 2017, 6:25 AM · Bug Report, EditEngine
lyahdav added a comment to T11768: Show diff statistics (lines changed).

For anyone who doesn't want to wait for this to be implemented, here's a Tampermonkey script to do it: https://gist.github.com/lyahdav/30fabcfb2856a28d320114922c91a1e3

Mar 9 2017, 3:37 AM · Feature Request
lyahdav added Q184: Is it possible to display the number of lines changed in a diff (Answer 526).
Mar 9 2017, 3:00 AM
chad triaged T12373: Support macros in Phame as Low priority.
Mar 9 2017, 2:47 AM · Macros, Phame, Bug Report
CodeMouse92 created T12373: Support macros in Phame.
Mar 9 2017, 2:39 AM · Macros, Phame, Bug Report
chad added a revision to T12370: Maniphest menu items misalign if they have submenu items: Unknown Object (Differential Revision).
Mar 9 2017, 2:03 AM · Bug Report
jboning added a project to T12371: Support `viewerprojects()` and implement `viewerpackages()` for "Auditors" in Diffusion: Restricted Project.
Mar 9 2017, 1:15 AM · Restricted Project, Audit, Differential
lvital updated subscribers of T12372: Long list of reviewers breaks to: field when metamta.one-mail-per-recipient set to false.
Mar 9 2017, 12:55 AM · Mail, Bug Report
lvital created T12372: Long list of reviewers breaks to: field when metamta.one-mail-per-recipient set to false.
Mar 9 2017, 12:50 AM · Mail, Bug Report

Mar 8 2017

jboning added a comment to T12371: Support `viewerprojects()` and implement `viewerpackages()` for "Auditors" in Diffusion.

Cool, this would be great!

Mar 8 2017, 11:09 PM · Restricted Project, Audit, Differential
epriestley added a comment to T9430: "Needs Audit" no longer excludes author commits.

The general headers/sections are mostly scripted now so they should be fairly consistent, but I'm still editing the actual markup at the end of the day.

Mar 8 2017, 11:04 PM · Restricted Project, Restricted Project, Audit
cspeckmim added a comment to T9430: "Needs Audit" no longer excludes author commits.

I'm good with the current balance of the changelogs - the one thing I think would be nifty is being able to accumulate the Upgrade/Compatibility sections across changelogs, for sites that aren't able to upgrade weekly. I was considering making a script to scrape that info but haven't had a chance to sit down for it. Also it'd be relying on the changelog format to be consistent (seems to be pretty darn consistent).

Mar 8 2017, 10:59 PM · Restricted Project, Restricted Project, Audit
epriestley updated the task description for T12371: Support `viewerprojects()` and implement `viewerpackages()` for "Auditors" in Diffusion.
Mar 8 2017, 10:57 PM · Restricted Project, Audit, Differential
epriestley updated the task description for T12371: Support `viewerprojects()` and implement `viewerpackages()` for "Auditors" in Diffusion.
Mar 8 2017, 10:57 PM · Restricted Project, Audit, Differential
epriestley created T12371: Support `viewerprojects()` and implement `viewerpackages()` for "Auditors" in Diffusion.
Mar 8 2017, 10:56 PM · Restricted Project, Audit, Differential
epriestley added a comment to T9430: "Needs Audit" no longer excludes author commits.

I think we currently get about equal amounts of "your changelogs should be more detailed" and "your changelogs have too much irrelevant stuff" feedback so I'll take that feedback under consideration but don't plan to make changes unless the overall balance of feedback shifts substantially in one direction.

Mar 8 2017, 10:55 PM · Restricted Project, Restricted Project, Audit
epriestley added a comment to T9430: "Needs Audit" no longer excludes author commits.

We support viewerprojects() elsewhere but it isn't currently a component of the "Auditors" datasource. See also T9362#207080. I'll file a version of T9362 for the "Auditors" field.

Mar 8 2017, 10:49 PM · Restricted Project, Restricted Project, Audit
jboning added a comment to T9430: "Needs Audit" no longer excludes author commits.

More generally: I think your decision to not try to migrate saved queries makes a lot of sense. In lieu of that, I'd like to cast a vote for more prominent mention in the changelog. It would be great just to see a note that some queries would break and some hints on identifying and replacing/repairing the broken ones.

Mar 8 2017, 10:44 PM · Restricted Project, Restricted Project, Audit
jboning added a comment to T9430: "Needs Audit" no longer excludes author commits.

I've hit the same problem that @cspeckmim ran into. As best I can tell, in the new system there's no way to quite replicate the behaviour of the old 'needs' or 'problem' audit queries. The closest attempts I've come up with so far are:

  • query for Audit Status = Audit Required/Needs Verification and Responsible Users = viewer(). But that includes results where the user is the diff author, not auditor.
  • query for Audit Status = Audit Required/Needs Verification and Auditors = viewer(). But that misses results where user is a member of a package or project auditor.

I think this would work if I could query for Auditors = viewer()/projects(viewer())/packages(viewer()), but it seems the functions aren't composable (at least in the UI).

Mar 8 2017, 10:22 PM · Restricted Project, Restricted Project, Audit
20after4 closed T12353: Convert PhabricatorSearchDocumentQuery to cursor based paging as Invalid.
Mar 8 2017, 9:47 PM · Elasticsearch, Wikimedia, Search
cspeckmim added a comment to T12370: Maniphest menu items misalign if they have submenu items.

I tried removing white space: nowrap; (from one of .phabricator-action-view button.phabricator-action-view-item, .phabricator-action-view-item) in the browser inspector on FF and it looks like it goes back to normal (even when expanding).

Mar 8 2017, 8:52 PM · Bug Report
chad added a comment to T12370: Maniphest menu items misalign if they have submenu items.

Yeah Chrome is fine as well.

Mar 8 2017, 8:48 PM · Bug Report
cspeckmim updated the task description for T12370: Maniphest menu items misalign if they have submenu items.
Mar 8 2017, 8:43 PM · Bug Report
cspeckmim updated the task description for T12370: Maniphest menu items misalign if they have submenu items.
Mar 8 2017, 8:42 PM · Bug Report
cspeckmim updated the task description for T12370: Maniphest menu items misalign if they have submenu items.
Mar 8 2017, 8:42 PM · Bug Report
cspeckmim created T12370: Maniphest menu items misalign if they have submenu items.
Mar 8 2017, 8:41 PM · Bug Report
chad added a revision to T12270: Unbeta Badges: Unknown Object (Differential Revision).
Mar 8 2017, 8:34 PM · Badges (v0)
chad added a comment to T12270: Unbeta Badges.

Do you have a rough suggestion on what to do with badges.search? Seems like noone would use these feature regardless.

Mar 8 2017, 7:45 PM · Badges (v0)
epriestley added a project to T12368: better support for "raw" patches, in particular corresponding to uncommitted changes?: KDE.
Mar 8 2017, 6:36 PM · KDE, Feature Request (Needs Information)
epriestley merged T12368: better support for "raw" patches, in particular corresponding to uncommitted changes? into T5029: Fill in missing context for low-context diffs against tracked repositories.
Mar 8 2017, 6:36 PM · KDE, Restricted Project, Diffusion, Differential
epriestley merged task T12368: better support for "raw" patches, in particular corresponding to uncommitted changes? into T5029: Fill in missing context for low-context diffs against tracked repositories.
Mar 8 2017, 6:36 PM · KDE, Feature Request (Needs Information)
epriestley updated subscribers of T12368: better support for "raw" patches, in particular corresponding to uncommitted changes?.

I'm going to merge this into T5029. This is an extremely low priority for this upstream because this workflow is virtually unheard of among full-time software development professionals (see "Target Audience" in Contributing Feature Requests) because it is inherently error-prone.

Mar 8 2017, 6:35 PM · KDE, Feature Request (Needs Information)
RJVB added a comment to T12368: better support for "raw" patches, in particular corresponding to uncommitted changes?.

How do you make guarantee that unrelated, simultaneous, uncommitted changes in the same working copy do not interfere with each other?

Mar 8 2017, 6:26 PM · KDE, Feature Request (Needs Information)
chad added a comment to T12368: better support for "raw" patches, in particular corresponding to uncommitted changes?.

Maybe a better way to explain Phabricator's philosophy is that it's build on code quality. That is, if we have to equally choose between developer efficiency and code quality, code quality will win because we feel code quality leads to greater long-term efficiency. It means less likelihood of wasting reviewers time, or chasing bugs, or missing issues because of easily catchable programmatic mistakes. Is it a great workflow if you're just fixing a typo in a document file? Not at all. But 99% of revisions are not typo fixes. With a commit, we can run builds, show reviewers full context diffs, allow for arc to patch diffs, allow for chain of custody and so on.

Mar 8 2017, 5:47 PM · KDE, Feature Request (Needs Information)
epriestley added a comment to T12368: better support for "raw" patches, in particular corresponding to uncommitted changes?.

How do you make guarantee that unrelated, simultaneous, uncommitted changes in the same working copy do not interfere with each other?

Mar 8 2017, 5:18 PM · KDE, Feature Request (Needs Information)
RJVB added a comment to T12368: better support for "raw" patches, in particular corresponding to uncommitted changes?.

The problem to be solved is that workflows as I've tried to describe aren't possible. Workflows where there is no official policy that changes first have to be committed, signed off or whatever before they can be considered for inclusion upstream. Or if you want, workflows in a more relaxed community with smaller and larger contributions coming in from a wide variety of users and developers not all of whom are experts in using git, svn or what have you.

Mar 8 2017, 5:12 PM · KDE, Feature Request (Needs Information)
chad added a comment to T12368: better support for "raw" patches, in particular corresponding to uncommitted changes?.

I guess this is pre pre-commit review?

Mar 8 2017, 4:30 PM · KDE, Feature Request (Needs Information)
chad added a comment to T12368: better support for "raw" patches, in particular corresponding to uncommitted changes?.

We want to know the problem you feel that feature solves specifically, not just that you want it. You can run patches manually or run arc diff --preview to just preview changes. But offhand I don't see any workflow benefit to reviewing non committed changes and don't recall any requests for such a feature.

Mar 8 2017, 4:09 PM · KDE, Feature Request (Needs Information)
RJVB added a comment to T12368: better support for "raw" patches, in particular corresponding to uncommitted changes?.

Sorry, the Root Problem was clear enough in my head but apparently not explicit enough in the OP. I hope to have addressed that now.

Mar 8 2017, 3:48 PM · KDE, Feature Request (Needs Information)
RJVB renamed T12368: better support for "raw" patches, in particular corresponding to uncommitted changes? from better support for "raw" patches? to better support for "raw" patches, in particular corresponding to uncommitted changes?.
Mar 8 2017, 3:47 PM · KDE, Feature Request (Needs Information)
adam93 updated Q585: Using Spaces within a large organisation from to Using Spaces within a large organisation.
Mar 8 2017, 3:44 PM · Projects, Spaces
chad edited projects for T12368: better support for "raw" patches, in particular corresponding to uncommitted changes?, added: Feature Request (Needs Information); removed Feature Request.
Mar 8 2017, 3:14 PM · KDE, Feature Request (Needs Information)
chad added a comment to T12368: better support for "raw" patches, in particular corresponding to uncommitted changes?.

Please use Ponder or Conpherence if you have general questions about using Phabricator. If this is a feature request, it needs to state a root problem in order to be accepted. See Contributing Feature Requests and Describing Root Problems.

Mar 8 2017, 2:50 PM · KDE, Feature Request (Needs Information)
chad edited projects for T12369: Users sometimes prompted to "Edit Locked Task" when attempting to create a new task, added: Bug Report (Needs Information); removed Bug Report.
Mar 8 2017, 2:44 PM · Bug Report, EditEngine
Croakx awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Like token.
Mar 8 2017, 2:44 PM · Workboards (v3), Restricted Project
chad added a comment to T12369: Users sometimes prompted to "Edit Locked Task" when attempting to create a new task.

I've followed the steps you listed above but am not able to reproduce the issue. Do you have more information you can give us on how to reproduce the bug? Without reproduction steps the upstream cannot move forward.

Mar 8 2017, 2:44 PM · Bug Report, EditEngine
d.maznekov updated the task description for T12369: Users sometimes prompted to "Edit Locked Task" when attempting to create a new task.
Mar 8 2017, 2:31 PM · Bug Report, EditEngine
d.maznekov created T12369: Users sometimes prompted to "Edit Locked Task" when attempting to create a new task.
Mar 8 2017, 2:30 PM · Bug Report, EditEngine
RJVB created T12368: better support for "raw" patches, in particular corresponding to uncommitted changes?.
Mar 8 2017, 2:12 PM · KDE, Feature Request (Needs Information)
angel added a comment to Q343: Uploading file to Amazon S3 bucket fails with cUrl error 7.

Same problem here, any help?

Mar 8 2017, 12:46 PM
mcorteel added a comment to T12284: Wrong notification label (subtask status update).

Thank you for the very thorough reply.
That's not a big deal and it certainly can wait!

Mar 8 2017, 12:46 PM · Bug Report
mbishopim3 added a comment to T12365: Daemon never recovers with Git commit parsing task, but manually reparsing succeeds.

In our case these are commits from landed Differential diffs. Permissions
for the web user are there and correct, but I'm not sure I understand all
the details around the daemon vs. web user, and the daemon is doing the
work for this git commit parser.

Mar 8 2017, 12:46 PM · Daemons, Bug Report
mcorteel added a comment to T12357: Remarkup: **bold** effect in Header section is not discernible.

Thank you for your quick reaction (and sorry that I didn't reply sooner). I think a black color with a 1px black text-shadow looks better. The blue is confusing (it sort of looks like a link).
So I suggest:

.phui-document-view .phabricator-remarkup .remarkup-header strong {
  color: #000000;
  text-shadow: 0 0 1px #000000;
}
Mar 8 2017, 12:42 PM · Remarkup, Bug Report
avivey added a comment to T4752: Daemons may not have permission to remove files from local disk storage engine.

I've implemented the sudo approach at some point - P2016 - and I think it worked alright.

Mar 8 2017, 12:03 PM · Files
d.maznekov marked Q584: Edit Locked Task message ?? (Answer 525) as visible.
Mar 8 2017, 11:57 AM
avivey added a comment to T12365: Daemon never recovers with Git commit parsing task, but manually reparsing succeeds.

mkdir: cannot create directory ‘/var/storage/3f/49’: Permission denied

Mar 8 2017, 11:56 AM · Daemons, Bug Report
d.maznekov added a comment to T12335: Ability to lock a task to prevent further edits.

I have to report a possible bug as asked in Q584.
Message for editing locked task when create new non-existing task:

Screenshot (1).png (328×1 px, 31 KB)

Mar 8 2017, 11:51 AM · Maniphest, Feature Request
d.maznekov closed Q584: Edit Locked Task message ?? as resolved.
Mar 8 2017, 11:49 AM
d.maznekov added Q584: Edit Locked Task message ?? (Answer 525).
Mar 8 2017, 11:48 AM
avivey added Q584: Edit Locked Task message ?? (Answer 524).
Mar 8 2017, 11:35 AM
avivey awarded T12270: Unbeta Badges a Baby Tequila token.
Mar 8 2017, 11:31 AM · Badges (v0)
d.maznekov updated Q584: Edit Locked Task message ?? from to Edit Locked Task message ?? .
Mar 8 2017, 11:24 AM
joshuaspence awarded T12270: Unbeta Badges a Like token.
Mar 8 2017, 5:13 AM · Badges (v0)
chad added a comment to T12270: Unbeta Badges.

... and then there was one ...

Mar 8 2017, 1:58 AM · Badges (v0)
chad updated the task description for T12270: Unbeta Badges.
Mar 8 2017, 1:58 AM · Badges (v0)
chad archived Sample Project.
Mar 8 2017, 1:45 AM
• sshannin renamed T7022: diffusion - doesn't understand svn Replace operation from Differential looking at wrong revision #'s to diffusion - doesn't understand svn Replace operation.
Mar 8 2017, 12:40 AM · Bug Report, Diffusion, Subversion
chad closed T12367: Cut off Project names in policy dropdown indiscernible - need `text-overflow: ellipsis` & a tooltip instead as Resolved by committing Restricted Diffusion Commit.
Mar 8 2017, 12:38 AM · PHUI, Bug Report
chad closed T12366: Long Project names outgrow dropdown widget as Resolved by committing Restricted Diffusion Commit.
Mar 8 2017, 12:36 AM · PHUI, Bug Report
epriestley added a comment to T12355: Daemons are having a rough time starting on `admin`.

I haven't been able to reproduce this locally by artificially making services unavailable or connections fail. Debugging this in production will require momentary service interruptions on admin until I can narrow things down so I'm going to wait until off-peak to poke at it.

Mar 8 2017, 12:00 AM · Phacility, Daemons, Ops

Mar 7 2017

chad closed T10698: Comment previews should display user badges under the author's profile image. as Resolved by committing Restricted Diffusion Commit.
Mar 7 2017, 11:57 PM · Badges
chad added a revision to T10698: Comment previews should display user badges under the author's profile image.: Unknown Object (Differential Revision).
Mar 7 2017, 10:20 PM · Badges