Page MenuHomePhabricator

mbishopim3 (Matt Bishop)
Engineering

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
May 23 2012, 3:07 PM (356 w, 1 d)
Availability
Available

Recent Activity

Sep 5 2017

mbishopim3 abandoned D18326: Support Windows paths for lint results.

Thanks, been a while since we tried to do this. Bug report submitted at https://discourse.phabricator-community.org/t/inline-comments-not-generated-for-lint-results-when-uploaded-from-windows/377.

Sep 5 2017, 6:50 PM

Aug 31 2017

mbishopim3 added a comment to D18326: Support Windows paths for lint results.

@epriestley are code contributions no longer accepted? We don't consider this something related to a bug report per se.

Aug 31 2017, 1:38 PM

Aug 14 2017

mbishopim3 added a reviewer for D18326: Support Windows paths for lint results: epriestley.
Aug 14 2017, 7:48 PM
mbishopim3 updated the diff for D18326: Support Windows paths for lint results.

Get local issues with unit tests corrected

Aug 14 2017, 7:47 PM

Aug 3 2017

mbishopim3 created D18326: Support Windows paths for lint results.
Aug 3 2017, 4:18 PM

Apr 11 2017

mbishopim3 added a comment to T12536: `PhabricatorRepositoryGitCommitMessageParserWorker` fails with `Got unexpected parameters: isPartial`.

Thanks. Deployed just now and confirmed working.

Apr 11 2017, 6:45 PM · Bug Report
mbishopim3 created T12536: `PhabricatorRepositoryGitCommitMessageParserWorker` fails with `Got unexpected parameters: isPartial`.
Apr 11 2017, 5:06 PM · Bug Report

Mar 8 2017

mbishopim3 added a comment to T12365: Daemon never recovers with Git commit parsing task, but manually reparsing succeeds.

In our case these are commits from landed Differential diffs. Permissions
for the web user are there and correct, but I'm not sure I understand all
the details around the daemon vs. web user, and the daemon is doing the
work for this git commit parser.

Mar 8 2017, 12:46 PM · Daemons, Bug Report

Mar 7 2017

mbishopim3 added a comment to T12365: Daemon never recovers with Git commit parsing task, but manually reparsing succeeds.

Occasionally, even after running the re-parse command, the basics of the commit will import but the content itself will not. A phd restart will almost immediately allow the commit to then import.

Mar 7 2017, 10:18 PM · Daemons, Bug Report
mbishopim3 added a comment to T12365: Daemon never recovers with Git commit parsing task, but manually reparsing succeeds.

More info: the commit contained binary files (executables actually).

Mar 7 2017, 8:25 PM · Daemons, Bug Report
mbishopim3 added a comment to T12365: Daemon never recovers with Git commit parsing task, but manually reparsing succeeds.

We now have one that's failing even when forcing a reparse:

Mar 7 2017, 7:44 PM · Daemons, Bug Report
mbishopim3 added a comment to T12365: Daemon never recovers with Git commit parsing task, but manually reparsing succeeds.

Is there a way to recall the logs from a failing task? Is there any value in providing the logs for the successful task? Not really sure what to say here besides that it's a consistent and random issue on our repositories. When we run the trace, it then "bumps" the task somehow and things succeed, so it would be difficult to provide detail on an error.

Mar 7 2017, 4:16 PM · Daemons, Bug Report
mbishopim3 created T12365: Daemon never recovers with Git commit parsing task, but manually reparsing succeeds.
Mar 7 2017, 4:10 PM · Daemons, Bug Report

Jan 4 2017

mbishopim3 added a comment to T11978: Storage Tools Not Actually Upgrading Database.

This can be closed as invalid (or resolved I guess). Looks like we performed an install and some upgrades at an awkward time when some storage upgrade changes were occurring. We've run several stable branch updates on the install since and it's been fine.

Jan 4 2017, 3:34 PM · Bug Report (Needs Information)

Dec 9 2016

mbishopim3 added a comment to T11978: Storage Tools Not Actually Upgrading Database.

Re-applied the scripts and all is well now. Once another SQL script comes into the stable branch I will run the upgrade again, something must still be off here. For reference, after a pull, daemon stop, etc. we are only running storage upgrade --force -- is this incorrect? Seems to be fine in our other instances, but for this one the scripts are being marked as applied, but they aren't.

Dec 9 2016, 2:11 PM · Bug Report (Needs Information)

Dec 8 2016

mbishopim3 created T11978: Storage Tools Not Actually Upgrading Database.
Dec 8 2016, 10:38 PM · Bug Report (Needs Information)

Jun 20 2016

mbishopim3 added a comment to T11181: Old missing commits from deleted branches stuck as queued tasks.

That did it, thanks!

Jun 20 2016, 6:42 PM · Bug Report
mbishopim3 created T11181: Old missing commits from deleted branches stuck as queued tasks.
Jun 20 2016, 6:35 PM · Bug Report
mbishopim3 added a comment to T11180: Daemons fail to discover when a repository contains tags which tag other tags.

Thanks, this is working now.

Jun 20 2016, 6:25 PM · Diffusion, Bug Report
epriestley awarded T11180: Daemons fail to discover when a repository contains tags which tag other tags a Mountain of Wealth token.
Jun 20 2016, 6:13 PM · Diffusion, Bug Report
mbishopim3 added a comment to T11180: Daemons fail to discover when a repository contains tags which tag other tags.

This is in all likelihood a mistake made forever ago but I'll wait for a potential patch.

Jun 20 2016, 6:06 PM · Diffusion, Bug Report
mbishopim3 added a comment to T11180: Daemons fail to discover when a repository contains tags which tag other tags.

object 78daf8de9fe15dce0b4d0e1945a57c778e0536d7
type tag
tag v2.11.1
tagger Test User <test@test.com> 1413916998 -0400

tagging v2.11.1

Jun 20 2016, 5:41 PM · Diffusion, Bug Report
mbishopim3 added a comment to T11180: Daemons fail to discover when a repository contains tags which tag other tags.

If it requires us to delete the v2.11.1 tag then so be it, we understand that maybe we did something wild with history in the past but that tag doesn't really give us anything anymore so it can go.

Jun 20 2016, 5:33 PM · Diffusion, Bug Report
mbishopim3 added a comment to T11180: Daemons fail to discover when a repository contains tags which tag other tags.

Had to redact a bit:

Jun 20 2016, 5:31 PM · Diffusion, Bug Report
mbishopim3 added a comment to T11180: Daemons fail to discover when a repository contains tags which tag other tags.

The repo uses callsign P and refers to Platform.

Jun 20 2016, 5:05 PM · Diffusion, Bug Report
mbishopim3 created T11180: Daemons fail to discover when a repository contains tags which tag other tags.
Jun 20 2016, 4:32 PM · Diffusion, Bug Report

Feb 10 2016

mbishopim3 edited the content of Organizations Using Phabricator.
Feb 10 2016, 8:08 PM

Jan 26 2016

exp10r3r awarded Roadmap a Love token.
Jan 26 2016, 9:01 AM

Jan 21 2016

jozacg awarded Starmap a Like token.
Jan 21 2016, 2:04 PM

Nov 21 2015

mbishopim3 added a comment to T9800: Upgrading: Possible issue with `xhpast` database for installs that upgraded between October 8, 2012 and October 9, 2012.

Excellent, thanks for following up! I am glad it wasn't just some strange issue for just us.

Nov 21 2015, 5:19 PM · Installing & Upgrading

Oct 1 2015

Herald updated subscribers of T8821: arc commands (diff, version) fails on Windows - terrible fix inside.
Oct 1 2015, 2:52 PM · Windows, libphutil, Arcanist

Sep 1 2015

mbishopim3 added a comment to T9305: "A task is moved between columns on a workboard." email preference not respected.

The email itself is isolated to the one action: movement on a workboard. There is a second e-mail however which refers to the closure of a task. The two are effectively grouped together and happened quickly, but two separate emails were sent. The other email's headers:

Sep 1 2015, 5:03 PM · Herald
mbishopim3 added a comment to T9305: "A task is moved between columns on a workboard." email preference not respected.

For example:

Sep 1 2015, 4:28 PM · Herald
mbishopim3 created T9305: "A task is moved between columns on a workboard." email preference not respected.
Sep 1 2015, 3:25 PM · Herald

Aug 31 2015

mbishopim3 created T9296: Default "one hour jump" logic not formatted correctly.
Aug 31 2015, 4:49 PM · Calendar
mbishopim3 created T9295: Date chooser picket fence issue with next month.
Aug 31 2015, 4:47 PM · Calendar

Jun 25 2015

mbishopim3 added a comment to T8675: Events not visible.

Confirmed working, thanks! A future request might be to have that range configurable.

Jun 25 2015, 9:55 PM · Calendar
mbishopim3 added a comment to T8675: Events not visible.

Month view is working, stupidity on my part -- didn't switch to the next month!

Jun 25 2015, 9:16 PM · Calendar
mbishopim3 added a comment to T8675: Events not visible.

After digging around this might be a limitation of the "upcoming events" query. We assumed that some views would present at least a minimal number of items, but that query now seems to be more restrictive. That's all this is. Is that timeframe configurable? We reported this because events went missing in some places, but that's just because they're far enough out in time.

Jun 25 2015, 7:08 PM · Calendar
mbishopim3 created T8675: Events not visible.
Jun 25 2015, 1:18 PM · Calendar

Jun 24 2015

mbishopim3 added a comment to D13396: MetaMTA - save actorPHID as its own column.

Not sure if these sorts of things are placed anywhere special these days but the application of this patch was brutal on our system -- took like 30 minutes on our relatively-decent hardware and MySQL instance. Might be worth warning.

Jun 24 2015, 1:39 PM

May 8 2015

mbishopim3 added a comment to T8021: Implement "All Day" events.

Good to go now, thanks!

May 8 2015, 3:46 PM · Calendar
mbishopim3 added a comment to T8021: Implement "All Day" events.

I stand corrected. This still occurs for all-day events.

May 8 2015, 12:44 PM · Calendar
mbishopim3 added a comment to T8021: Implement "All Day" events.

Not sure if this can be reproduced on your side but the first all-day event I attempted to create on our instance (it was multi-day as well) gave me an "invalid timezone" exception. Apparently "GMT+12" was attempted to be used. I went to try again and succeeded that time.

May 8 2015, 12:35 PM · Calendar

May 6 2015

mbishopim3 added a comment to T7674: Remove support for arc commit hooks.

@jparise this is fixed now: https://github.com/imobile3/cassowary/commit/dbee6144701519938c6845c546f4aa7bf1df3f62

May 6 2015, 5:26 PM · Lint, Arcanist
mbishopim3 added a comment to T5955: Refactor Conduit auth to be stateless, token-based, and support wire encodings.

Yeah that's what we were doing actually, but given our environment and arcanist's checks regarding the file permissions (that it's 600, etc.) it was messy due to shell restrictions and other stuff where our scripts are running. This will be great for build agents posting back Harbormaster statuses.

May 6 2015, 2:23 PM · Restricted Project, Auth, Conduit
mbishopim3 added a comment to T5955: Refactor Conduit auth to be stateless, token-based, and support wire encodings.

Great, thanks. It appears that it does still need the certificate in a .arcrc file somewhere, as we removed that file as part of the above test and received the certificate prompt.

May 6 2015, 1:36 PM · Restricted Project, Auth, Conduit
mbishopim3 added a comment to T5955: Refactor Conduit auth to be stateless, token-based, and support wire encodings.

Is the above commit able to be used or are there a few steps to go? Gave it a quick try and it still wanted my bot user to install a certificate despite providing an API token with the above parameter.

May 6 2015, 12:11 PM · Restricted Project, Auth, Conduit

May 4 2015

mbishopim3 added a comment to T7343: arc install-certificate doesn't work with bot users.

--conduit-token would be the bee's knees for us, managing the .arcrc file with web users, file permissions, and all this other noise is a huge hassle.

May 4 2015, 8:11 PM · Arcanist

Jan 6 2015

mbishopim3 accepted D11251: Continue after rejecting commits from a commit query.

Confirmed working for our users.

Jan 6 2015, 3:51 PM
mbishopim3 created T6880: "Attempting to access attached data on PhabricatorRepositoryCommit (via getRepository())" error when creating or accessing diffs.
Jan 6 2015, 3:32 PM

Sep 3 2014

mbishopim3 created T6025: Accepted differential revision Herald rule not catching.
Sep 3 2014, 11:01 AM · Herald

Aug 4 2014

mbishopim3 accepted D10138: Use standard infrastructure to attach commits to other objects.

I can't strictly speak to everything moved in this diff, but applying relationships does work correctly now so it's functionally fine.

Aug 4 2014, 5:11 PM
mbishopim3 accepted D10137: Write a "resign" audit relationship even if actor has no relationship.

Confirmed working now.

Aug 4 2014, 5:00 PM

Jul 26 2014

mbishopim3 added a comment to T5717: Unrelated validation exception when adding blocking task.

Confirmed working, thanks!

Jul 26 2014, 9:05 PM · Maniphest

Jul 25 2014

mbishopim3 created T5717: Unrelated validation exception when adding blocking task.
Jul 25 2014, 3:38 PM · Maniphest

Apr 20 2014

mbishopim3 added a comment to T4435: More tshirts.

I saw a tweet with a shirt photo, excited to potentially get mine one day!

Apr 20 2014, 9:55 PM · Design

Apr 1 2014

mbishopim3 added a comment to T4697: SVN file moves for hosted repositories aren't translating a protocol frame?.

Confirmed, operations such as svn mv work correctly now.

Apr 1 2014, 3:32 PM · Repositories

Mar 24 2014

mbishopim3 added a comment to T4636: Repository information from `arc which` not making it to Phabricator.

Unfortunately it doesn't seem to have fixed it, despite our setup and 'arc which' the diffs themselves don't have Repository set.

Mar 24 2014, 3:01 PM · Differential, Herald

Mar 4 2014

mbishopim3 added a comment to T4476: Optimize the UX for moving a task between columns in the Workboard.

Agreed. At least in our use cases the task will have a priority and having column moves change that will almost always be unintended.

Mar 4 2014, 9:32 PM · Workboards, Maniphest

Feb 24 2014

mbishopim3 added a comment to T4445: Diffusion tag cache not updating correctly when tags move?.

Let's do it with a test repo, I'll execute the commands and see if it gets crazy.

Feb 24 2014, 9:14 PM · Diffusion
mbishopim3 added a comment to T4445: Diffusion tag cache not updating correctly when tags move?.

Can you browse via that tag now? We see the hash update but then get a "Failed to look up tag" exception.

Feb 24 2014, 8:58 PM · Diffusion

Feb 14 2014

mbishopim3 awarded T4431: Provide Workboard templates, or some other way to get a commonly used set of columns on a board quickly a Love token.
Feb 14 2014, 2:14 AM · Projects, Workboards

Feb 12 2014

mbishopim3 edited this Maniphest Task.
Feb 12 2014, 8:28 PM · Maniphest, Workboards

Dec 3 2013

mbishopim3 added a comment to T4194: Offer header background color picker to stock Phabricator installs.

A header color and replacement top left logo are all we're really looking for.

Dec 3 2013, 4:49 PM · Phabricator

Oct 18 2013

mbishopim3 added a comment to T3820: Implement top-level "Spaces" that provide policy isolation to groups of objects.

Now that the first version is behind us, our instance at least is most interested in something like:

Oct 18 2013, 2:26 AM · Spaces, Policy, Wikimedia