Page MenuHomePhabricator
Create Task
Maniphest T12357

Remarkup: **bold** effect in Header section is not discernible
Closed, ResolvedPublic
Actions

Description

This block:

== Header **with bold**

Renders like this:

pasted_file (40×188 px, 2 KB)

The **with bold** words are wrapped in a <strong>, but it's not rendered any differently from the rest of the header..

I suggest using a different color to make <strong> sections stand out:

.phui-document-view .phabricator-remarkup .remarkup-header strong {
    color: #000;
}

Our use case is that we write UI text in bold in our specification (done with phriction). But this isn't apparent in titles, which is too bad! This would be subtle but useful for our use case.

Revisions and Commits

rP Phabricator
D17469rPcd6b28467829 Highlight strong tag in document headers

Event Timeline

mcorteel created this task.Mar 6 2017, 10:23 AM
avivey renamed this task from Display bold text with a different color in titles to Remarkup: **bold** effect in Header section is not discernible.Mar 6 2017, 10:31 AM
avivey updated the task description. (Show Details)
avivey edited projects, added Bug Report, Remarkup; removed Feature Request.
Herald added a subscriber: eadler. · View Herald TranscriptMar 6 2017, 10:31 AM
chad added a subscriber: chad.Mar 6 2017, 3:26 PM

What would you suggest as a fix?

chad added a comment.Mar 6 2017, 3:31 PM
In T12357#214422, @chad wrote:

What would you suggest as a fix?

I suppose I could read better.

chad added a revision: D17469: Highlight strong tag in document headers.Mar 6 2017, 3:58 PM
chad closed this task as Resolved by committing rPcd6b28467829: Highlight strong tag in document headers.Mar 6 2017, 5:28 PM
chad added a commit: rPcd6b28467829: Highlight strong tag in document headers.
chad added a comment.Mar 6 2017, 5:37 PM

I went with a different color, but we could also do text-shadow or a background-color... lmk if this seems bad in practice.

mcorteel added a comment.Mar 8 2017, 12:42 PM

Thank you for your quick reaction (and sorry that I didn't reply sooner). I think a black color with a 1px black text-shadow looks better. The blue is confusing (it sort of looks like a link).
So I suggest:

.phui-document-view .phabricator-remarkup .remarkup-header strong {
  color: #000000;
  text-shadow: 0 0 1px #000000;
}
mcorteel added a comment.Mar 22 2017, 6:22 AM

We tested this style (black with shadow) on our install, but the consensus is that it looks awful...
I guess a simple black text color is a little subtle, but at least it isn't confusing (like the blue color) or ugly (like the shadow).
@chad what do you think?

Phabricator · Built by Phacility