Page MenuHomePhabricator
Feed Advanced Search

Jul 22 2016

csilvers added a comment to T8115: arcanist plugin system.

arc upgrade: Upgrade everything? This feels sort of bad/dangerous, maybe? But maybe fine? We could prompt?

Jul 22 2016, 4:41 PM · Arcanist
ivo added a comment to T11362: Arcanist tries to land onto identical remote branch instead of 'master'.

I guess you're right. We've never really questioned the behaviour of these GUI tools. We assumed that because they do this automatically and provide no way to disable it "they'll probably know what they're doing".

Jul 22 2016, 4:20 PM · Arcanist, Bug Report
epriestley added a comment to T8115: arcanist plugin system.

Part of the tension here is that any package-related command potentially has two targets: arc itself, or the current working directory (Phabricator, some third-party app you're developing, etc).

Jul 22 2016, 3:44 PM · Arcanist
epriestley added a project to T11363: Differential "revision updated" mail preference is pretty useless: Phacility.
Jul 22 2016, 3:38 PM · Customer Impact, Restricted Project, Differential, Mail
epriestley added a subtask for T10448: Modularize mail tags: T11363: Differential "revision updated" mail preference is pretty useless.
Jul 22 2016, 3:24 PM · Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request
epriestley added a parent task for T11363: Differential "revision updated" mail preference is pretty useless: T10448: Modularize mail tags.
Jul 22 2016, 3:24 PM · Customer Impact, Restricted Project, Differential, Mail
epriestley created T11363: Differential "revision updated" mail preference is pretty useless.
Jul 22 2016, 3:24 PM · Customer Impact, Restricted Project, Differential, Mail
epriestley closed T8116: Prototype a package management application as Resolved.

None of that really does anything yet, but the next steps (signing, installing) need to have major components in arc, so I'm going to consolidate this into T8115 / T5055 and other related arc work.

Jul 22 2016, 2:53 PM
epriestley added a comment to T11362: Arcanist tries to land onto identical remote branch instead of 'master'.

(We could detect this case and fail with an error, but the root issue here seems to be that tracking is being set on a remote branch which the local branch really does not track.)

Jul 22 2016, 2:41 PM · Arcanist, Bug Report
epriestley added a comment to T11362: Arcanist tries to land onto identical remote branch instead of 'master'.

Generally, I'm very hesitant to use "will the push change anything" as a signal, because I think this is unintuitive and will create confusing false negatives. Specifically, if you do this:

Jul 22 2016, 2:38 PM · Arcanist, Bug Report
epriestley added a comment to T11362: Arcanist tries to land onto identical remote branch instead of 'master'.

Have you asked Sourcetree or Git Tower to change their behavior instead? They can compute ahead/behind without setting tracking, and it seems like setting tracking is not really correct here (the local branches do not really "track" temporary remote CI branches in the traditional sense).

Jul 22 2016, 2:36 PM · Arcanist, Bug Report
ivo added a comment to T11362: Arcanist tries to land onto identical remote branch instead of 'master'.

I'm not sure actually. Most of us use GUI tools like Sourcetree or Git Tower, which automatically set up tracking when a branch is pushed. I guess they do this to be able to show the "Commits behind / ahead" badges on branches.

Jul 22 2016, 2:33 PM · Arcanist, Bug Report
epriestley added a revision to T8116: Prototype a package management application: Unknown Object (Differential Revision).
Jul 22 2016, 2:11 PM
epriestley added a revision to T8116: Prototype a package management application: Unknown Object (Differential Revision).
Jul 22 2016, 1:37 PM
epriestley added a revision to T8116: Prototype a package management application: Unknown Object (Differential Revision).
Jul 22 2016, 1:12 PM
epriestley added a comment to T11362: Arcanist tries to land onto identical remote branch instead of 'master'.

Why does the local branch track the remote branch? Do you push using --set-upstream? If so, why?

Jul 22 2016, 12:52 PM · Arcanist, Bug Report
ivo created T11362: Arcanist tries to land onto identical remote branch instead of 'master'.
Jul 22 2016, 12:21 PM · Arcanist, Bug Report
RuralHunter created T11361: View/Edit Policy Problem of Parent Project Members .
Jul 22 2016, 6:44 AM · Policy, Projects, Bug Report
lewellyn added a comment to T9042: Diviner fails to create all books, path is error.

I see the same behavior noted by @lianghu in T9042#129510.

Jul 22 2016, 5:15 AM · Diviner
epriestley created T11360: Detect MySQL `read_only` and degrade masters to replicas.
Jul 22 2016, 3:21 AM · Contributor Onboarding, Restricted Project, Clusters
epriestley changed the name of U29 httpoxy Vulnerability Information from to httpoxy Vulnerability Information.
Jul 22 2016, 12:36 AM
epriestley created T11359: "httpoxy" HTTP Proxy Environmental Vulnerability.
Jul 22 2016, 12:36 AM · Security

Jul 21 2016

avivey edited P2001 AddSubscribersFromJIRAIssuesHeraldCustomAction.php.
Jul 21 2016, 9:54 PM · Herald
Shredder121 created an object: C145: End of UNIX time.
Jul 21 2016, 9:19 PM
• st_we updated the question details for Q451: Add subscriber to task with herald rules if there is "no" subscriber on creation.
Jul 21 2016, 8:47 PM · Maniphest, Herald
• st_we updated Q451: Add subscriber to task with herald rules if there is "no" subscriber on creation from to Add subscriber to task with herald rules if there is "no" subscriber on creation.
Jul 21 2016, 8:40 PM · Maniphest, Herald
epriestley added a revision to T8116: Prototype a package management application: Unknown Object (Differential Revision).
Jul 21 2016, 7:29 PM
eadler removed a project from T2968: In conduit, make auto resolve task via review land look the same as manual resolve: Restricted Project.
Jul 21 2016, 7:18 PM · Restricted Project, Conduit
eadler moved T11356: Simplify the output of `arc which` from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jul 21 2016, 7:17 PM · Restricted Project, Arcanist
eadler added a project to T11356: Simplify the output of `arc which`: Restricted Project.
Jul 21 2016, 7:17 PM · Restricted Project, Arcanist
epriestley added a revision to T8116: Prototype a package management application: Unknown Object (Differential Revision).
Jul 21 2016, 5:58 PM
mose added a comment to T11351: Move Pholio to EditEngine and modern APIs.

Excellent! Thanks for this so very detailed answer. I will try the way of the phid.lookup to work this issue around in the while.

Jul 21 2016, 5:22 PM · Restricted Project, EditEngine, Conduit, Pholio, Feature Request
epriestley closed T11358: Phame raises exception when 'subtitle' field too long as Resolved by committing Restricted Diffusion Commit.
Jul 21 2016, 4:48 PM · Phame, Bug Report
epriestley added a revision to T8116: Prototype a package management application: Unknown Object (Differential Revision).
Jul 21 2016, 4:44 PM
jonathanrseawright awarded T11355: Build a flexible revision lookup API in Arcanist a Mountain of Wealth token.
Jul 21 2016, 3:06 PM · Restricted Project, Prioritized, Arcanist
jonathanrseawright added a comment to T11358: Phame raises exception when 'subtitle' field too long.

Looks like that'll work nicely!

Jul 21 2016, 2:26 PM · Phame, Bug Report
epriestley added a comment to T11358: Phame raises exception when 'subtitle' field too long.

Thanks for the report, and for the good reproduction instructions. D16313 should raise a better exception.

Jul 21 2016, 2:19 PM · Phame, Bug Report
epriestley added a revision to T11358: Phame raises exception when 'subtitle' field too long: Unknown Object (Differential Revision).
Jul 21 2016, 2:15 PM · Phame, Bug Report
epriestley triaged T11358: Phame raises exception when 'subtitle' field too long as Normal priority.
Jul 21 2016, 2:08 PM · Phame, Bug Report
epriestley claimed T11358: Phame raises exception when 'subtitle' field too long.
Jul 21 2016, 2:08 PM · Phame, Bug Report
jonathanrseawright created T11358: Phame raises exception when 'subtitle' field too long.
Jul 21 2016, 2:07 PM · Phame, Bug Report
epriestley moved T9692: Warn but continue when installing bot certificates with `arc install-certificate` from Backlog to vNext on the Arcanist board.
Jul 21 2016, 2:06 PM · Contributor Onboarding, User Preferences, Arcanist
bjshively awarded T11355: Build a flexible revision lookup API in Arcanist a Doubloon token.
Jul 21 2016, 2:05 PM · Restricted Project, Prioritized, Arcanist
timor awarded T1894: Support commenting on Phriction documents a Love token.
Jul 21 2016, 1:28 PM · Restricted Project, Restricted Project, Phriction
epriestley added a project to T11355: Build a flexible revision lookup API in Arcanist: Prioritized.
Jul 21 2016, 1:26 PM · Restricted Project, Prioritized, Arcanist
yelirekim awarded T11355: Build a flexible revision lookup API in Arcanist a Dat Boi token.
Jul 21 2016, 12:52 PM · Restricted Project, Prioritized, Arcanist
yelirekim awarded T3875: Allow arc to perform cascading rebases, maybe during or after `arc land` a Cup of Joe token.
Jul 21 2016, 12:51 PM · Prioritized, Restricted Project, Arcanist
epriestley moved T2465: Context not available for revisions created on Windows from Backlog to Windows on the Arcanist board.
Jul 21 2016, 12:14 PM · Windows, Subversion, Arcanist
epriestley moved T2780: Under "cmd.exe" in Windows, "^C" causes "arc.bat" to annoyingly prompt the user "Terminate batch job? [Y/N]" from Backlog to Windows on the Arcanist board.
Jul 21 2016, 12:14 PM · Arcanist, Windows
epriestley moved T3271: Before launching $EDITOR from arc, print that we're doing it from Backlog to Windows on the Arcanist board.
Jul 21 2016, 12:14 PM · Arcanist
epriestley moved T3272: Route ExecFuture stdout/stderr through the filesystem on Windows from Backlog to Windows on the Arcanist board.
Jul 21 2016, 12:13 PM · Arcanist, Windows
epriestley moved T4631: Allow Differential to raise warnings on the server side via Conduit from Backlog to API Changes on the Arcanist board.
Jul 21 2016, 12:13 PM · Restricted Project, Differential, Arcanist
epriestley closed T4727: arc diff exception as Invalid.

There isn't enough information provided for us to reproduce this issue. See Contributing Bug Reports.

Jul 21 2016, 12:12 PM · Arcanist
epriestley moved T4964: Windows installer for Arcanist from Backlog to Far Future on the Arcanist board.
Jul 21 2016, 12:11 PM · Windows, Setup, Wikimedia, Arcanist
epriestley moved T4977: arc patch fails even when cherry pick appears successful from Backlog to arc patch on the Arcanist board.
Jul 21 2016, 12:11 PM · Arcanist
epriestley moved T5006: `arc patch` leaves a useless branch around when aborted due to a missing base from Backlog to arc patch on the Arcanist board.
Jul 21 2016, 12:11 PM · Arcanist
epriestley moved T5055: Distribution mechanism for arc extensions from Backlog to vMajor on the Arcanist board.
Jul 21 2016, 12:11 PM · Arcanist
epriestley moved T5064: Make `arc land` run unit tests and lint from Backlog to vMajor on the Arcanist board.
Jul 21 2016, 12:11 PM · Restricted Project, Arcanist
epriestley added a comment to T5172: Create an `arc status` workflow.

T5088 is a possible use case (report if the current revision needs an update), although I feel like it's a bit flimsy.

Jul 21 2016, 12:11 PM · Prioritized, Restricted Project, Arcanist
epriestley moved T5724: ANSI color escape sequences seem broken for arc in git bash on windows from Backlog to Windows on the Arcanist board.
Jul 21 2016, 12:09 PM · Windows, Arcanist
epriestley moved T5730: `arc lint --everything` reporting all symbols missing in libphutil/ on Windows? from Backlog to Windows on the Arcanist board.
Jul 21 2016, 12:09 PM · Lint, Windows, Arcanist
epriestley closed T5781: Moar functionality for `arc browse`! as Resolved.

T10895 is a reasonable followup for --revision / --do-what-I-mean-instead-of-what-I-say.

Jul 21 2016, 12:08 PM · Arcanist
epriestley moved T5784: Arc diff user guide default range is incorrect from Backlog to vNext on the Arcanist board.
Jul 21 2016, 12:06 PM · Arcanist, Documentation
epriestley moved T6112: Arcanist can not upload binaries when use Mercurial on Windows from Backlog to Windows on the Arcanist board.
Jul 21 2016, 12:05 PM · Mercurial, Arcanist
epriestley merged T6232: arc diff should suggest/pre-fill dependencies into T11343: Generate default "Depends on" line in commit message when multiple diffs are stacked.
Jul 21 2016, 12:05 PM · Differential, Arcanist, Feature Request
epriestley merged task T6232: arc diff should suggest/pre-fill dependencies into T11343: Generate default "Depends on" line in commit message when multiple diffs are stacked.
Jul 21 2016, 12:05 PM · Arcanist
epriestley closed T6317: Legacy Arcanist configuration names are not respected in .arcrc as Wontfix.

I think we missed the window on this one.

Jul 21 2016, 12:04 PM · Arcanist
epriestley moved T6712: `arc patch` should not ask if I want to add untracked files to my commit from Backlog to arc patch on the Arcanist board.
Jul 21 2016, 12:03 PM · Arcanist
epriestley merged task T7040: Create dependency for revisions automatically into T11343: Generate default "Depends on" line in commit message when multiple diffs are stacked.
Jul 21 2016, 12:03 PM · Arcanist
epriestley merged T7040: Create dependency for revisions automatically into T11343: Generate default "Depends on" line in commit message when multiple diffs are stacked.
Jul 21 2016, 12:03 PM · Differential, Arcanist, Feature Request
epriestley moved T7040: Create dependency for revisions automatically from Backlog to vNext on the Arcanist board.
Jul 21 2016, 12:02 PM · Arcanist
epriestley moved T7093: `arc patch` fails to apply case-changing renames in git on Windows from Backlog to Windows on the Arcanist board.
Jul 21 2016, 12:02 PM · Arcanist
epriestley closed T7342: Extend documentation on arc land as Resolved.

The arc help land documentation was improved by T9657.

Jul 21 2016, 12:02 PM · Documentation, Arcanist
epriestley moved T7487: ArcanistWorkflow should extend from PhutilArgumentWorkflow from Backlog to vMajor on the Arcanist board.
Jul 21 2016, 12:00 PM · Arcanist
epriestley closed T9935: Split ~/.arcrc between machine and user config as Resolved.

After T10431, aliases are also read from system configuration.

Jul 21 2016, 11:59 AM · Arcanist, Feature Request
epriestley moved T7616: Arcanist to be able to access site requiring client side SSL certificate from Backlog to Far Future on the Arcanist board.
Jul 21 2016, 11:58 AM · Arcanist, libphutil
epriestley added a comment to T7616: Arcanist to be able to access site requiring client side SSL certificate.

After the introduction of PhutilHTTPEngineExtension (T10227) we have a more viable pathway to bring support for this upstream, but I'd still like to see more interest in it before thinking about upstream support. It looks like only 1-2 installs would use it, today (not sure if both of you represent the same install or not).

Jul 21 2016, 11:58 AM · Arcanist, libphutil
epriestley moved T7715: Give `arc` query workflows (arc tasks, arc list) access to ApplicationSearch from Backlog to API Changes on the Arcanist board.
Jul 21 2016, 11:55 AM · Restricted Project, FreeBSD, Arcanist
epriestley moved T7787: Support "!priority high" and other email commands from "arc todo" from Backlog to API Changes on the Arcanist board.
Jul 21 2016, 11:55 AM · Arcanist
epriestley moved T8348: `arc download` doesn't support chunked downloads from Backlog to API Changes on the Arcanist board.
Jul 21 2016, 11:55 AM · Restricted Project, Files, Arcanist
epriestley moved T10945: Replace "repository.query" with "diffusion.repository.search" in Arcanist from vMajor to API Changes on the Arcanist board.
Jul 21 2016, 11:55 AM · Restricted Project, Conduit, Arcanist, Diffusion
epriestley moved T8115: arcanist plugin system from Backlog to vMajor on the Arcanist board.
Jul 21 2016, 11:54 AM · Arcanist
epriestley moved T8291: arc version fails on Windows from Backlog to Windows on the Arcanist board.
Jul 21 2016, 11:54 AM · Windows, Arcanist
epriestley moved T8348: `arc download` doesn't support chunked downloads from Backlog to vNext on the Files board.
Jul 21 2016, 11:53 AM · Restricted Project, Files, Arcanist
epriestley added a subtask for T11357: Move Files to EditEngine and modern APIs: T8348: `arc download` doesn't support chunked downloads.
Jul 21 2016, 11:53 AM · Restricted Project, Files
epriestley added a parent task for T8348: `arc download` doesn't support chunked downloads: T11357: Move Files to EditEngine and modern APIs.
Jul 21 2016, 11:53 AM · Restricted Project, Files, Arcanist
epriestley added a project to T8348: `arc download` doesn't support chunked downloads: Files.
Jul 21 2016, 11:53 AM · Restricted Project, Files, Arcanist
epriestley created T11357: Move Files to EditEngine and modern APIs.
Jul 21 2016, 11:52 AM · Restricted Project, Files
epriestley moved T8821: arc commands (diff, version) fails on Windows - terrible fix inside from Backlog to Windows on the Arcanist board.
Jul 21 2016, 11:50 AM · Windows, libphutil, Arcanist
epriestley moved T8855: Add Powershell support to Arcanist documentation from Backlog to Windows on the Arcanist board.
Jul 21 2016, 11:50 AM · Windows, Arcanist
epriestley closed T8861: Updating a revision with dependencies pulls all diffs from dependencies by default as Resolved.

See T6072 / T11356 for discussion.

Jul 21 2016, 11:50 AM · Arcanist
epriestley moved T9047: arc lint can not find php and phpcs from Backlog to Windows on the Arcanist board.
Jul 21 2016, 11:48 AM · Windows, Lint, Arcanist
epriestley moved T9049: Setting editor fails when following instructions from Backlog to Windows on the Arcanist board.
Jul 21 2016, 11:48 AM · Windows, Arcanist
epriestley moved T9223: Allow `arc diff` to run a build step like `gradle` first, then read lint and unit messages from the output from Backlog to vMajor on the Arcanist board.
Jul 21 2016, 11:48 AM · Unit, Arcanist
epriestley moved T9441: Cygwin PHP segfaults with arcanist from Backlog to Windows on the Arcanist board.
Jul 21 2016, 11:47 AM · Windows, Arcanist
epriestley moved T9459: arc upgrade on Windows doesn't understand it's a git repo from Backlog to Windows on the Arcanist board.
Jul 21 2016, 11:47 AM · Arcanist, Windows
epriestley renamed T9713: In Diffusion, show commit messages as parsed fields by default with an option to view them raw from Arcanist commit messages format usernames without a leading "@" to In Diffusion, show commit messages as parsed fields by default with an option to view them raw.
Jul 21 2016, 11:47 AM · Diffusion (v3)
epriestley moved T10329: Implement internal workflows / a build engine in Arcanist from Backlog to vMajor on the Arcanist board.
Jul 21 2016, 11:46 AM · Restricted Project, Arcanist
epriestley moved T10622: Auto add reviewers based on custom logic from Backlog to vMajor on the Arcanist board.
Jul 21 2016, 11:45 AM · Restricted Project, Arcanist, Feature Request
epriestley moved T10945: Replace "repository.query" with "diffusion.repository.search" in Arcanist from Backlog to vMajor on the Arcanist board.
Jul 21 2016, 11:45 AM · Restricted Project, Conduit, Arcanist, Diffusion