Phame raises exception when 'subtitle' field too long
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	jonathanrseawright
	Jul 21 2016, 2:07 PM

Description

Version (stable branch)

phabricator 46ceba728fee8a775e2ddf0cdae332a0679413a4 (Sat, Jul 9)
arcanist f1c45a3323ae20eefe29c0a22c7923fe8b151bbf (Fri, Jul 1)
phutil 5fd2cf9d5ddd38424a54a8fba02398d527639970 (Sat, Jul 9)

To Reproduce

I encountered this when editing a blog, but you may see it also when creating a new one.

Create a blog. Fill the name / subtitle with whatever you want
Edit the blog, put 'aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa' in the subtitle field.
Click "save"
You will get an exception:

Unhandled Exception ("AphrontQueryException")
#1406: Data too long for column 'subtitle' at row 1

Probably not a huge deal, but wanted to report it.

Revisions and Commits

Restricted Differential Revision

Restricted Diffusion Commit

Event Timeline

jonathanrseawright created this task.Jul 21 2016, 2:07 PM

epriestley claimed this task.Jul 21 2016, 2:08 PM

epriestley triaged this task as Normal priority.

epriestley added a project: Phame.

epriestley added a revision: Restricted Differential Revision.Jul 21 2016, 2:15 PM

Thanks for the report, and for the good reproduction instructions. D16313 should raise a better exception.

Technically, we probably have similar cases on several other fields, but I think users are very unlikely to hit them on, e.g., domainFullURI, especially since I was voted down on https://very-short-link.technology/ in V29. Once Phame fully modernizes to ModularTransactions we can make it easier to apply these checks.

Looks like that'll work nicely!

I definitely appreciate all the hard work you guys have been putting in. Phabricator is light years ahead of what we were using in the past. Glad I can help out in some way.

epriestley closed this task as Resolved by committing Restricted Diffusion Commit.Jul 21 2016, 4:48 PM

epriestley added a commit: Restricted Diffusion Commit.