Page MenuHomePhabricator
Create Task
Maniphest T11358

Phame raises exception when 'subtitle' field too long
Closed, ResolvedPublic
Actions

Description

Version (stable branch)

To Reproduce

I encountered this when editing a blog, but you may see it also when creating a new one.

  1. Create a blog. Fill the name / subtitle with whatever you want
  2. Edit the blog, put 'aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa' in the subtitle field.
  3. Click "save"
  4. You will get an exception:
Unhandled Exception ("AphrontQueryException")
#1406: Data too long for column 'subtitle' at row 1

Probably not a huge deal, but wanted to report it.

Revisions and Commits

rP Phabricator
D16313rPc27ba19da3b7 Raise human-readable error messages for overlong Phame blog titles and subtitles

Related Objects

Event Timeline

jonathanrseawright created this task.Jul 21 2016, 2:07 PM
epriestley claimed this task.Jul 21 2016, 2:08 PM
epriestley triaged this task as Normal priority.
epriestley added a project: Phame.
epriestley added a revision: D16313: Raise human-readable error messages for overlong Phame blog titles and subtitles.Jul 21 2016, 2:15 PM
epriestley added a comment.Jul 21 2016, 2:19 PM

Thanks for the report, and for the good reproduction instructions. D16313 should raise a better exception.

Technically, we probably have similar cases on several other fields, but I think users are very unlikely to hit them on, e.g., domainFullURI, especially since I was voted down on https://very-short-link.technology/ in V29. Once Phame fully modernizes to ModularTransactions we can make it easier to apply these checks.

jonathanrseawright added a comment.Jul 21 2016, 2:26 PM

Looks like that'll work nicely!

I definitely appreciate all the hard work you guys have been putting in. Phabricator is light years ahead of what we were using in the past. Glad I can help out in some way.

epriestley closed this task as Resolved by committing rPc27ba19da3b7: Raise human-readable error messages for overlong Phame blog titles and subtitles.Jul 21 2016, 4:48 PM
epriestley added a commit: rPc27ba19da3b7: Raise human-readable error messages for overlong Phame blog titles and subtitles.
Phabricator · Built by Phacility