Page MenuHomePhabricator

Arc diff user guide default range is incorrect
Open, LowPublic

Description

According to the arc diff user guide (https://secure.phabricator.com/book/phabricator/article/arcanist_diff/#git), the default commit range that is sent if you don't specify a commit is:

`git merge-base origin/master HEAD`..HEAD

But if you're on a branch that has an upstream it will instead be the merge-base of the upstream branch and your local branch (which makes sense, since that's "all the commits on the current branch that you haven't pushed yet", but the explicit origin/master in the previous sentence is confusing).

Event Timeline

nkovacs raised the priority of this task from to Needs Triage.
nkovacs updated the task description. (Show Details)
nkovacs added projects: Documentation, Arcanist.
nkovacs added a subscriber: nkovacs.
chad triaged this task as Low priority.Aug 25 2014, 5:15 PM