Page MenuHomePhabricator

In Conpherence, stop throwing away stuff users have typed when a reply arrives
ClosedPublic

Authored by epriestley on Apr 20 2017, 12:07 AM.
Tags
None
Referenced Files
F14847707: D17742.diff
Mon, Feb 3, 2:56 PM
Unknown Object (File)
Fri, Jan 31, 3:40 AM
Unknown Object (File)
Wed, Jan 29, 8:01 PM
Unknown Object (File)
Tue, Jan 21, 12:50 PM
Unknown Object (File)
Fri, Jan 17, 10:39 PM
Unknown Object (File)
Sun, Jan 5, 10:15 PM
Unknown Object (File)
Jan 3 2025, 7:57 PM
Unknown Object (File)
Jan 3 2025, 8:34 AM
Subscribers
None

Details

Summary

Ref T12562. I think the pre-send-on-enter behavior was: disable textarea, send message, clear area on response?

That got changed but not completely, maybe. There's currently an issue here:

  • Add a sleep(3) to UpdateController.
  • Type "AAA".
  • Press enter.
  • Real fast, type "BBB".
  • When the "AAA" arrives, your "BBB" is lost. Sad!
Test Plan
  • Did the thing described above; no longer lost "BBB".
  • Switched threads, sent messages, couldn't find anything else this breaks. It dates from a long time ago so I think it's just pre-SOE stuff.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable