Page MenuHomePhabricator

In Conpherence, stop throwing away stuff users have typed when a reply arrives
ClosedPublic

Authored by epriestley on Apr 20 2017, 12:07 AM.
Tags
None
Referenced Files
F18817115: D17742.diff
Tue, Oct 21, 12:34 PM
F18816224: D17742.id.diff
Tue, Oct 21, 5:31 AM
F18808766: D17742.diff
Sun, Oct 19, 8:25 AM
F18733565: D17742.id.diff
Tue, Sep 30, 10:37 PM
F18610590: D17742.id42675.diff
Sep 14 2025, 5:08 AM
F18597859: D17742.id.diff
Sep 13 2025, 3:51 AM
F18566207: D17742.id.diff
Sep 9 2025, 2:23 PM
F18500891: D17742.diff
Sep 4 2025, 9:24 PM
Subscribers
None

Details

Summary

Ref T12562. I think the pre-send-on-enter behavior was: disable textarea, send message, clear area on response?

That got changed but not completely, maybe. There's currently an issue here:

  • Add a sleep(3) to UpdateController.
  • Type "AAA".
  • Press enter.
  • Real fast, type "BBB".
  • When the "AAA" arrives, your "BBB" is lost. Sad!
Test Plan
  • Did the thing described above; no longer lost "BBB".
  • Switched threads, sent messages, couldn't find anything else this breaks. It dates from a long time ago so I think it's just pre-SOE stuff.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable