Page MenuHomePhabricator

The "Persistent Chat" element doesn't remember which room you had selected across page refreshes
Open, Needs TriagePublic

Description

To reproduce:

  1. Navigate to a page
  2. \ to open chat column
  3. Click a different conversation than the default (i.e. not the leftmost)
  4. Start typing in the send box
  5. Click back (either browser back or defocus + backspace)

The column stays open, but reverts back to the leftmost conversation being selected. I would expect the conversation I selected and started typing in to stay selected.

I just ran into this on secure and can reproduce. Queueing some text in the send box seems to be required oddly.

Event Timeline

sshannin created this task.May 16 2015, 2:24 PM
sshannin raised the priority of this task from to Needs Triage.
sshannin updated the task description. (Show Details)
sshannin added a project: Conpherence.
sshannin updated the task description. (Show Details)
sshannin added a subscriber: sshannin.

@chad, @epriestley - just want to verify this is the behavior you guys want? (the back button / page history should have no interaction with the durable chat column basically)

I want to verify because my guess is this is complicated to get right. :D

I'd maybe start with this:

  • When a thread is selected in the column, save a server-side preference (like we do for column open/closed).
  • If the preference is set and points at a valid thread, default to that thread when rendering the column. Logic might look like:
    • Pull the defaults.
    • If it's there, great.
    • If not, do another query to look for it (and stick it on the front if we hit it, I guess?)

That's probably a little bit of work because of the query stuff and will be a little odd (ordering may feel a touch jumpy?) but I think it should mostly align with expectations and get rid of most of the funk here.

It probably won't make the preview / typing a message case seamless, but I think that's less important. And maybe it actually does?

I do expect this general class of behavioral stickiness overall, but I'm not sure how valuable sinking the effort in to get all the fine-tuning and details of draft stuff working ahead of other refinements (like showing threads with mentions or new messages) is.

fanis added a subscriber: fanis.Aug 28 2015, 12:26 PM
epriestley renamed this task from conversation in chat column doesn't stick to The "Persistent Chat" element doesn't remember which room you had selected across page refreshes.Apr 17 2017, 11:20 AM
epriestley moved this task from Backlog to v4 on the Conpherence board.
epriestley edited projects, added Conpherence (v4); removed Conpherence.