Page MenuHomePhabricator

Move room preferences into own controller
ClosedPublic

Authored by chad on Apr 19 2017, 11:23 PM.

Details

Summary

Ref T12591. These preferences are per user and we need to reload the whole UI on a change anyways. Simplifies future expansion.

Test Plan

Option click into new window, set preferences. View in Conpherence, see saved settings, change sound. Hear new sound.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

v. nice

src/applications/conpherence/controller/ConpherenceRoomPreferencesController.php
32

This can be simplified slightly to $this->newDialog() in modern code.

Probably needs a addCancelButton()?

37

(Consider adding getURI() to Thread if it doesn't already exist?)

This revision is now accepted and ready to land.Apr 19 2017, 11:25 PM
chad marked an inline comment as done.
  • update per comments
This revision was automatically updated to reflect the committed changes.