Page MenuHomePhabricator

Move room preferences into own controller
ClosedPublic

Authored by chad on Apr 19 2017, 11:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 29, 10:46 PM
Unknown Object (File)
Sat, Nov 25, 11:16 AM
Unknown Object (File)
Sat, Nov 25, 11:16 AM
Unknown Object (File)
Sat, Nov 25, 11:16 AM
Unknown Object (File)
Sat, Nov 25, 11:16 AM
Unknown Object (File)
Thu, Nov 16, 7:40 PM
Unknown Object (File)
Tue, Nov 14, 12:38 PM
Unknown Object (File)
Nov 3 2023, 1:25 AM
Subscribers

Details

Summary

Ref T12591. These preferences are per user and we need to reload the whole UI on a change anyways. Simplifies future expansion.

Test Plan

Option click into new window, set preferences. View in Conpherence, see saved settings, change sound. Hear new sound.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

v. nice

src/applications/conpherence/controller/ConpherenceRoomPreferencesController.php
33

This can be simplified slightly to $this->newDialog() in modern code.

Probably needs a addCancelButton()?

38

(Consider adding getURI() to Thread if it doesn't already exist?)

This revision is now accepted and ready to land.Apr 19 2017, 11:25 PM
chad marked an inline comment as done.
  • update per comments
This revision was automatically updated to reflect the committed changes.