Page MenuHomePhabricator

Make "Range" HTTP header work for Celerity static resource requests
ClosedPublic

Authored by epriestley on Apr 18 2017, 8:27 PM.
Tags
None
Referenced Files
F15561425: D17724.id42631.diff
Tue, Apr 29, 7:44 PM
F15553402: D17724.id42631.diff
Mon, Apr 28, 1:54 AM
F15544382: D17724.id.diff
Sat, Apr 26, 4:35 AM
F15542815: D17724.diff
Fri, Apr 25, 7:06 PM
F15542539: D17724.id42631.diff
Fri, Apr 25, 5:22 PM
F15506612: D17724.diff
Tue, Apr 15, 12:42 PM
F15449896: D17724.id42631.diff
Mar 28 2025, 12:45 PM
F15443969: D17724.id.diff
Mar 27 2025, 7:09 AM
Subscribers
None

Details

Summary

Ref T7567. In T8266 I fixed a bunch of obscure "Range" issues, but only for file downloads -- not for Celerity.

Extend all that stuff to Celerity, which is fortunately much easier.

I believe this will fix Conpherence sounds in Safari.

Test Plan
  • Wrote out an HTTP request in a text file with Range: bytes=0-1 and similar, piped it to localhost with cat request.txt | nc localhost 80, saw server return appropriate range responses consistent with file behavior after T8266, which all seems to work.
  • Also did that for files to try to make sure I wasn't breaking anything.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Apr 18 2017, 8:45 PM
This revision was automatically updated to reflect the committed changes.