Page MenuHomePhabricator

Make "Range" HTTP header work for Celerity static resource requests
ClosedPublic

Authored by epriestley on Apr 18 2017, 8:27 PM.
Tags
None
Referenced Files
F18097438: D17724.id42631.diff
Fri, Aug 8, 1:19 PM
F18094569: D17724.id.diff
Thu, Aug 7, 10:12 PM
F18081788: D17724.id42631.diff
Tue, Aug 5, 2:16 AM
F17955394: D17724.id.diff
Fri, Aug 1, 4:46 AM
F17949006: D17724.diff
Thu, Jul 31, 10:34 PM
F17930471: D17724.diff
Wed, Jul 30, 6:03 PM
F17664461: D17724.id42629.diff
Jul 12 2025, 7:01 PM
Unknown Object (File)
May 29 2025, 9:16 AM
Subscribers
None

Details

Summary

Ref T7567. In T8266 I fixed a bunch of obscure "Range" issues, but only for file downloads -- not for Celerity.

Extend all that stuff to Celerity, which is fortunately much easier.

I believe this will fix Conpherence sounds in Safari.

Test Plan
  • Wrote out an HTTP request in a text file with Range: bytes=0-1 and similar, piped it to localhost with cat request.txt | nc localhost 80, saw server return appropriate range responses consistent with file behavior after T8266, which all seems to work.
  • Also did that for files to try to make sure I wasn't breaking anything.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Apr 18 2017, 8:45 PM
This revision was automatically updated to reflect the committed changes.