Page MenuHomePhabricator

Make "Range" HTTP header work for Celerity static resource requests
ClosedPublic

Authored by epriestley on Apr 18 2017, 8:27 PM.
Tags
None
Referenced Files
F15449896: D17724.id42631.diff
Fri, Mar 28, 12:45 PM
F15443969: D17724.id.diff
Thu, Mar 27, 7:09 AM
F15439144: D17724.id.diff
Wed, Mar 26, 5:58 AM
F15436888: D17724.id42629.diff
Tue, Mar 25, 4:43 PM
F15434403: D17724.id42629.diff
Tue, Mar 25, 3:26 AM
F15409555: D17724.id42629.diff
Wed, Mar 19, 4:41 AM
F15393935: D17724.id42629.diff
Mar 15 2025, 11:17 PM
F15377295: D17724.id42629.diff
Mar 13 2025, 8:33 AM
Subscribers
None

Details

Summary

Ref T7567. In T8266 I fixed a bunch of obscure "Range" issues, but only for file downloads -- not for Celerity.

Extend all that stuff to Celerity, which is fortunately much easier.

I believe this will fix Conpherence sounds in Safari.

Test Plan
  • Wrote out an HTTP request in a text file with Range: bytes=0-1 and similar, piped it to localhost with cat request.txt | nc localhost 80, saw server return appropriate range responses consistent with file behavior after T8266, which all seems to work.
  • Also did that for files to try to make sure I wasn't breaking anything.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Apr 18 2017, 8:45 PM
This revision was automatically updated to reflect the committed changes.