Page MenuHomePhabricator

Make "Range" HTTP header work for Celerity static resource requests
ClosedPublic

Authored by epriestley on Apr 18 2017, 8:27 PM.
Tags
None
Referenced Files
F19030590: D17724.diff
Mon, Nov 24, 9:45 PM
F18935889: D17724.diff
Nov 10 2025, 7:11 PM
F18855339: D17724.id42629.diff
Nov 1 2025, 4:56 AM
F18821652: D17724.id42631.diff
Oct 23 2025, 1:03 AM
F18763872: D17724.id.diff
Oct 7 2025, 2:46 AM
F18628763: D17724.id42631.diff
Sep 16 2025, 7:15 AM
F18616314: D17724.diff
Sep 14 2025, 5:06 PM
F18600197: D17724.diff
Sep 13 2025, 9:12 AM
Subscribers
None

Details

Summary

Ref T7567. In T8266 I fixed a bunch of obscure "Range" issues, but only for file downloads -- not for Celerity.

Extend all that stuff to Celerity, which is fortunately much easier.

I believe this will fix Conpherence sounds in Safari.

Test Plan
  • Wrote out an HTTP request in a text file with Range: bytes=0-1 and similar, piped it to localhost with cat request.txt | nc localhost 80, saw server return appropriate range responses consistent with file behavior after T8266, which all seems to work.
  • Also did that for files to try to make sure I wasn't breaking anything.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Apr 18 2017, 8:45 PM
This revision was automatically updated to reflect the committed changes.