Page MenuHomePhabricator

Make "Range" HTTP header work for Celerity static resource requests
ClosedPublic

Authored by epriestley on Apr 18 2017, 8:27 PM.
Tags
None
Referenced Files
F12847435: D17724.id42631.diff
Fri, Mar 29, 2:13 AM
Unknown Object (File)
Feb 3 2024, 3:37 PM
Unknown Object (File)
Jan 25 2024, 6:51 AM
Unknown Object (File)
Jan 16 2024, 1:21 AM
Unknown Object (File)
Dec 27 2023, 10:43 AM
Unknown Object (File)
Dec 27 2023, 10:43 AM
Unknown Object (File)
Dec 27 2023, 10:43 AM
Unknown Object (File)
Dec 21 2023, 5:45 PM
Subscribers
None

Details

Summary

Ref T7567. In T8266 I fixed a bunch of obscure "Range" issues, but only for file downloads -- not for Celerity.

Extend all that stuff to Celerity, which is fortunately much easier.

I believe this will fix Conpherence sounds in Safari.

Test Plan
  • Wrote out an HTTP request in a text file with Range: bytes=0-1 and similar, piped it to localhost with cat request.txt | nc localhost 80, saw server return appropriate range responses consistent with file behavior after T8266, which all seems to work.
  • Also did that for files to try to make sure I wasn't breaking anything.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Apr 18 2017, 8:45 PM
This revision was automatically updated to reflect the committed changes.