Page MenuHomePhabricator

Make "Range" HTTP header work for Celerity static resource requests
ClosedPublic

Authored by epriestley on Apr 18 2017, 8:27 PM.
Tags
None
Referenced Files
F17664461: D17724.id42629.diff
Sat, Jul 12, 7:01 PM
Unknown Object (File)
May 29 2025, 9:16 AM
Unknown Object (File)
May 27 2025, 4:54 AM
Unknown Object (File)
May 26 2025, 8:20 PM
Unknown Object (File)
May 20 2025, 5:09 AM
Unknown Object (File)
May 20 2025, 2:16 AM
Unknown Object (File)
Apr 29 2025, 7:44 PM
Unknown Object (File)
Apr 28 2025, 1:54 AM
Subscribers
None

Details

Summary

Ref T7567. In T8266 I fixed a bunch of obscure "Range" issues, but only for file downloads -- not for Celerity.

Extend all that stuff to Celerity, which is fortunately much easier.

I believe this will fix Conpherence sounds in Safari.

Test Plan
  • Wrote out an HTTP request in a text file with Range: bytes=0-1 and similar, piped it to localhost with cat request.txt | nc localhost 80, saw server return appropriate range responses consistent with file behavior after T8266, which all seems to work.
  • Also did that for files to try to make sure I wasn't breaking anything.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Apr 18 2017, 8:45 PM
This revision was automatically updated to reflect the committed changes.