Page MenuHomePhabricator
Feed Advanced Search

Jul 17 2015

epriestley closed T8872: phabricator admin Login Failure as Invalid.

This report doesn't have enough information for us to reproduce the issue. See the documentation here:

Jul 17 2015, 1:47 PM · Auth
chad awarded T8862: Fix "1 reviewer(s)" translation string for Differential feed stories a Pterodactyl token.
Jul 17 2015, 1:03 AM · Differential

Jul 16 2015

epriestley closed T5016: Allow Herald rules for Maniphest to act on custom task fields as Resolved by committing Restricted Diffusion Commit.
Jul 16 2015, 9:12 PM · Herald, Custom Fields
epriestley created T8862: Fix "1 reviewer(s)" translation string for Differential feed stories.
Jul 16 2015, 8:50 PM · Differential
epriestley removed a reviewer for D13607: aaa呵呵: Blessed Reviewers.
Jul 16 2015, 8:45 PM
epriestley removed a reviewer for D13610: 测试是否所有人可见: Blessed Reviewers.
Jul 16 2015, 8:45 PM
epriestley removed a reviewer for D13611: test audit: Blessed Reviewers.
Jul 16 2015, 8:44 PM
epriestley requested changes to D13639: Prevent 'Start or Wait for Build Plan' from running disabled build plans.

Why is this passing instead of failing?

Jul 16 2015, 8:41 PM
epriestley triaged T8858: Allow storing binary files in Passphrase as Wishlist priority.
Jul 16 2015, 8:38 PM · Passphrase
epriestley added a comment to T8861: Updating a revision with dependencies pulls all diffs from dependencies by default.

Use arc which to understand what arc is doing and why.

Jul 16 2015, 8:38 PM · Arcanist
epriestley edited P1826 ssh-keygen.
Jul 16 2015, 8:26 PM
epriestley merged task T8857: Make Git commit / message parsers eventually fail or de-prioritize on failure into T5955: Refactor Conduit auth to be stateless, token-based, and support wire encodings.
Jul 16 2015, 7:42 PM · Daemons
epriestley merged T8857: Make Git commit / message parsers eventually fail or de-prioritize on failure into T5955: Refactor Conduit auth to be stateless, token-based, and support wire encodings.
Jul 16 2015, 7:42 PM · Restricted Project, Auth, Conduit
epriestley edited the content of 2011-05 May - 2011-07 July.
Jul 16 2015, 7:37 PM
epriestley edited the content of Changelog.
Jul 16 2015, 7:36 PM
epriestley edited the content of Welcome.
Jul 16 2015, 7:36 PM
epriestley deleted Demo Page.
Jul 16 2015, 7:25 PM
20after4 awarded T6049: Implement Phurl, a URL shortener/bookmarking application a Love token.
Jul 16 2015, 5:43 PM · Phurl
epriestley closed T8860: Test task as Resolved.
Jul 16 2015, 3:37 PM
epriestley renamed T8667: Don't index Diviner sub-atoms in global search from Search should allow "Not" functions when selecting document types to Don't index Diviner sub-atoms in global search.
Jul 16 2015, 3:25 PM · Diviner
epriestley added a comment to T8667: Don't index Diviner sub-atoms in global search.

Currently, these results are essentially never useful to anyone, so I don't think the proposed solution (adding difficult-to-discovery complexity to the typeahead) is very good. Instead, we should improve the quality of the search results. For example, only indexing top-level atoms (in PHP, classes and functions). I believe we already have the concept of "top-level" in Diviner.

Jul 16 2015, 3:23 PM · Diviner
epriestley renamed T8850: Add a setup warning to make sure users haven't wiped out $_SERVER['REMOTE_ADDR'] from Creating new user raises: #1048: Column 'remoteAddr' cannot be null to Add a setup warning to make sure users haven't wiped out $_SERVER['REMOTE_ADDR'].
Jul 16 2015, 3:17 PM · Contributor Onboarding, Setup
epriestley added a comment to T8857: Make Git commit / message parsers eventually fail or de-prioritize on failure.

Why are they failing?

Jul 16 2015, 3:12 PM · Daemons
epriestley updated subscribers of T8320: Bring Owners out of the dark ages.
Jul 16 2015, 3:11 PM · Prioritized, Owners
epriestley merged task T8859: Find Owners link in Diffusion leads to a 404 /owners/view/search into T8320: Bring Owners out of the dark ages.
Jul 16 2015, 3:11 PM · Owners, Diffusion
epriestley added a comment to T8854: Display unit test results on home view.

(I believe) get a warning on the command-line if you try to land when tests are failing/not yet reported.

Jul 16 2015, 12:19 AM · Unit, Arcanist, Restricted Project
epriestley added a comment to T8854: Display unit test results on home view.

This would discourage people from landing in the situation where a diff has passed CR but hasn't passed tests.

Jul 16 2015, 12:19 AM · Unit, Arcanist, Restricted Project

Jul 15 2015

epriestley closed T8805: Improve error checking for third-party unit test engines as Resolved by committing Restricted Diffusion Commit.
Jul 15 2015, 8:26 PM · Arcanist
epriestley added a revision to T8805: Improve error checking for third-party unit test engines: Unknown Object (Differential Revision).
Jul 15 2015, 7:34 PM · Arcanist
epriestley added a comment to T8848: Add policy support to hosted repositories for allowing pushing branches or tags.

T8644 also discusses writing a "recipe book" for Herald, since there are a lot of things like this which it's powerful enough to do but where the pathway isn't necessarily obvious.

Jul 15 2015, 5:21 PM · Diffusion
epriestley added a comment to T8848: Add policy support to hosted repositories for allowing pushing branches or tags.

Oh, I suppose there's actually no way to specify "Administrators", per se, right now. We could maybe add one after T8726 wraps up.

Jul 15 2015, 5:14 PM · Diffusion
epriestley removed 1 mock(s) for T8830: `bin/remove destroy` is dangerous and leaves dangling edges: Unknown Object (Pholio Mock).
Jul 15 2015, 5:13 PM · Infrastructure, Restricted Project
epriestley added a comment to T7410: Allow a project's workboard to be disabled so that tagged tasks no longer show meaningless "(Backlog)".

its information content is 0.

Jul 15 2015, 5:12 PM · Projects, Wikimedia, Workboards

Jul 14 2015

epriestley added a comment to T8848: Add policy support to hosted repositories for allowing pushing branches or tags.

Can you use a Herald rule like this?

Jul 14 2015, 11:22 PM · Diffusion
haldyr awarded T3993: Build a global menu item showing the current Phrequent stack a Love token.
Jul 14 2015, 6:13 PM · Phrequent
epriestley added a comment to T8455: Herald rules with mailing lists are broken after mailing list -> user migration.

Do you still happen to have the original error message? That was unexpected, and the migration specifically accounted for the case of email collisions and I recall testing that case locally in detail, so I'm curious what I missed. The expected behavior is that that list wouldn't migrate (and would emit a message), but other lists would:

Jul 14 2015, 2:43 PM · Herald, Mailing Lists, Restricted Project
epriestley added a comment to T7484: Lock is not locked by this process.

I can write a lock log for this but it's going to add a huge amount of complexity and basically amount to implementing locks ourselves from scratch. However, I don't see any other way forward.

Jul 14 2015, 2:32 PM · Restricted Project, Daemons
epriestley added a comment to T8830: `bin/remove destroy` is dangerous and leaves dangling edges.

Locally, edge destruction works correctly. Here's a complete log:

Jul 14 2015, 2:29 PM · Infrastructure, Restricted Project
epriestley added a comment to T8830: `bin/remove destroy` is dangerous and leaves dangling edges.

Can you also enumerate exactly what problems you have with bin/remove destroy on tasks at HEAD? The expectation is that all these relationships are destroyed:

Jul 14 2015, 2:27 PM · Infrastructure, Restricted Project
epriestley added a comment to T8836: Unhandled Exception when dragging a card on workboards (not affecting all projects, may need help to investigate the cause).

This is almost certainly fixed by outstanding changes to Herald which are awaiting review. See also T8822.

Jul 14 2015, 2:23 PM · Herald
epriestley added a comment to T8835: Replacement for actAsUser in Conduit API.

We don't plan to restore actAsUser in any form to the upstream, since it violates policies and can not be made safe (in the sense of not-policy-violating).

Jul 14 2015, 2:20 PM · Restricted Project, Conduit
epriestley merged task T8837: XUnit parser generates results with a stringy duration into T8805: Improve error checking for third-party unit test engines.
Jul 14 2015, 2:16 PM · Arcanist
epriestley updated subscribers of T8805: Improve error checking for third-party unit test engines.
Jul 14 2015, 2:16 PM · Arcanist
epriestley added a comment to T3855: `arc land` should work when the current branch/bookmark and the target branch/bookmark are the same.

T8833 is also "arc land should restore state after a failure".

Jul 14 2015, 2:16 PM · Restricted Project, Arcanist
epriestley updated subscribers of T3855: `arc land` should work when the current branch/bookmark and the target branch/bookmark are the same.
Jul 14 2015, 2:15 PM · Restricted Project, Arcanist
epriestley merged task T8833: Branch state not preserved during arc land with a failed pre-receive hook into T3855: `arc land` should work when the current branch/bookmark and the target branch/bookmark are the same.
Jul 14 2015, 2:15 PM · Restricted Project, Arcanist
epriestley added a comment to T8833: Branch state not preserved during arc land with a failed pre-receive hook.

It is currently intentional that arc land does not restore state after a push failure.

Jul 14 2015, 2:15 PM · Restricted Project, Arcanist
epriestley added a comment to T8834: Remove Calendar/Files from Conpherence.

Yeah, I think we're likely to remove this. It generally needs a lot of effort to modernize even if we're going to keep it.

Jul 14 2015, 2:07 PM · Calendar, Conpherence

Jul 12 2015

johnny-bit awarded T6526: Implement "Badges" or "Medals", for annotating special users a Like token.
Jul 12 2015, 6:53 AM · Restricted Project, Badges (v0), People
hach-que awarded T6526: Implement "Badges" or "Medals", for annotating special users a Like token.
Jul 12 2015, 12:15 AM · Restricted Project, Badges (v0), People
hach-que awarded T6526: Implement "Badges" or "Medals", for annotating special users a Piece of Eight token.
Jul 12 2015, 12:15 AM · Restricted Project, Badges (v0), People

Jul 11 2015

tycho.tatitscheff awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Pterodactyl token.
Jul 11 2015, 6:46 AM · Workboards (v3), Restricted Project

Jul 10 2015

epriestley updated subscribers of T4136: Project options shown in Policy control should be smarter and more powerful.
Jul 10 2015, 6:33 PM · Projects, Policy
epriestley merged task T8819: Limiting "Can Create Spaces" to "Administrators" causes usability issues into T4136: Project options shown in Policy control should be smarter and more powerful.
Jul 10 2015, 6:33 PM · Policy, Spaces
epriestley added a comment to T8823: Unhandled Exception ("AphrontQueryException") when searching.

Try this:

Jul 10 2015, 6:11 PM · Search
epriestley closed T8820: Fix redirects on this install as Resolved.

I think I never actually enabled HSTS on this host. I've enabled it now. Clients should refuse to establish HTTP connections, mooting this.

Jul 10 2015, 4:01 PM · Phacility
epriestley added a revision to T7149: Allow users to import data into a new Phacility instance: Unknown Object (Differential Revision).
Jul 10 2015, 2:47 PM · Phacility
epriestley added a comment to T7149: Allow users to import data into a new Phacility instance.

I converted all the data destruction steps into a services wipe command. I'm planning to get the repo path stuff formalized too, then I'll update this with a simpler game plan.

Jul 10 2015, 1:34 PM · Phacility
epriestley added a comment to T8822: Unhandled Exception ("InvalidArgumentException") when try to edit Herald rule..

This is likely fixed by further changes connected to T8726, which are currently out for review. I'll keep an eye on it.

Jul 10 2015, 12:40 PM · Herald
epriestley added a comment to T8820: Fix redirects on this install.

It didn't, but nothing should be linking to http. How are you hitting HTTP links?

Jul 10 2015, 12:25 PM · Phacility
bobek awarded T418: Integrate CustomField into more interfaces a Like token.
Jul 10 2015, 5:49 AM · Restricted Project, Restricted Project, Restricted Project, Maniphest, Custom Fields
bobek awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Like token.
Jul 10 2015, 5:47 AM · Workboards (v3), Restricted Project

Jul 9 2015

epriestley added a revision to T8726: Modularize Herald fields and actions: Unknown Object (Differential Revision).
Jul 9 2015, 11:27 PM · Herald
epriestley added a comment to T6526: Implement "Badges" or "Medals", for annotating special users.

We could let specific "Important" badges generate a text tag like that but I'd like to be able to, e.g., award everyone who reports a bug a badge for it without turning every timeline into "Reported a Bug" on each comment.

Jul 9 2015, 10:26 PM · Restricted Project, Badges (v0), People
epriestley added a comment to T6526: Implement "Badges" or "Medals", for annotating special users.

Oh, yeah. That huge treatment might be good for "Administrator", "Employee" or object relationships ("Task Owner", "Task Author"), but feels pretty big for the more achivement-like "Made 100 Commits", "Registered for 5 years", "Contributed", things.

Jul 9 2015, 10:24 PM · Restricted Project, Badges (v0), People
epriestley added a comment to T6526: Implement "Badges" or "Medals", for annotating special users.

I was imagining something like this:

Jul 9 2015, 10:22 PM · Restricted Project, Badges (v0), People
epriestley added a comment to T6526: Implement "Badges" or "Medals", for annotating special users.

I don't want to do project/badge stuff yet, just an explicit "award this badge to this user" thing for now, but imagine maybe doing that in a future version.

Jul 9 2015, 10:16 PM · Restricted Project, Badges (v0), People
epriestley added a comment to T8816: Owners packages do not have monograms.

We could maybe do exotic monograms (π) or multicharacter monograms (PKG123) but I generally like T5378 first, at least.

Jul 9 2015, 10:09 PM · Owners
epriestley closed T8815: Typo in PhabricatorMultiColumnUIExample as Resolved by committing Restricted Diffusion Commit.
Jul 9 2015, 10:08 PM · PHUI
epriestley added a revision to T655: Integrate CustomField into Herald: Unknown Object (Differential Revision).
Jul 9 2015, 10:07 PM · Custom Fields, Herald
epriestley added a revision to T5016: Allow Herald rules for Maniphest to act on custom task fields: Unknown Object (Differential Revision).
Jul 9 2015, 10:07 PM · Herald, Custom Fields
epriestley added a revision to T8434: Accommodate the "Security" workflow: Unknown Object (Differential Revision).
Jul 9 2015, 10:07 PM · Wikimedia, Policy, Prioritized
epriestley added a revision to T8726: Modularize Herald fields and actions: Unknown Object (Differential Revision).
Jul 9 2015, 10:07 PM · Herald
epriestley edited the content of Object Name Prefixes / Monograms.
Jul 9 2015, 10:01 PM
epriestley added a comment to T8816: Owners packages do not have monograms.

(We only have ~30 reasonable monograms, most of which are used, and it's rare to need to refer to a package.)

Jul 9 2015, 10:01 PM · Owners
epriestley closed T8816: Owners packages do not have monograms as Wontfix.

Yes.

Jul 9 2015, 10:00 PM · Owners
epriestley claimed T8815: Typo in PhabricatorMultiColumnUIExample.
Jul 9 2015, 9:13 PM · PHUI
epriestley added a revision to T8815: Typo in PhabricatorMultiColumnUIExample: Unknown Object (Differential Revision).
Jul 9 2015, 9:11 PM · PHUI
epriestley added a revision to T8726: Modularize Herald fields and actions: Unknown Object (Differential Revision).
Jul 9 2015, 8:33 PM · Herald
epriestley added a revision to T8726: Modularize Herald fields and actions: Unknown Object (Differential Revision).
Jul 9 2015, 4:33 PM · Herald
epriestley added a revision to T8726: Modularize Herald fields and actions: Unknown Object (Differential Revision).
Jul 9 2015, 4:06 PM · Herald
epriestley added a revision to T8726: Modularize Herald fields and actions: Unknown Object (Differential Revision).
Jul 9 2015, 3:42 PM · Herald
epriestley updated subscribers of T5187: Make "Upload File" dialog have a vanilla file upload control.
Jul 9 2015, 3:39 PM · Prioritized, FreeBSD, User Delight, Remarkup, Files, Wikimedia
epriestley merged task T8766: Upload faliure into T5187: Make "Upload File" dialog have a vanilla file upload control.
Jul 9 2015, 3:39 PM · Files
epriestley updated subscribers of T5187: Make "Upload File" dialog have a vanilla file upload control.
Jul 9 2015, 3:39 PM · Prioritized, FreeBSD, User Delight, Remarkup, Files, Wikimedia
epriestley merged task T8814: Make it possible to attach a file without drag and drop into T5187: Make "Upload File" dialog have a vanilla file upload control.
Jul 9 2015, 3:39 PM · Maniphest
epriestley added a comment to P1792 PhabricatorGermanTranslation.php.

https://secure.phabricator.com/book/phabcontrib/article/adding_new_classes/

Jul 9 2015, 2:50 PM · Localization
epriestley updated subscribers of T8672: PhabricatorTaskmasterDaemon fatals in PublishWorker.
Jul 9 2015, 1:13 PM · Diffusion, Daemons
epriestley merged task T8813: exec_daemon Error into T8672: PhabricatorTaskmasterDaemon fatals in PublishWorker.
Jul 9 2015, 1:13 PM · Daemons
• filip.brinkmann awarded T4548: Support "Mylyn" Eclipse plugin a Pterodactyl token.
Jul 9 2015, 10:12 AM · Feature Request, Maniphest
epriestley added a comment to T8806: Buildable status icon is really hard to read between blue / green colours.

It's true. It's fair to say I was born for it.

Jul 9 2015, 2:28 AM · Harbormaster
epriestley closed T8807: Time Tracker as Invalid.

We have one, Phrequent. This is a prototype and very far down the list of development priorities.

Jul 9 2015, 2:21 AM · Roadmap
epriestley merged T8806: Buildable status icon is really hard to read between blue / green colours into T8096: Improve Harbormaster UI/UX (v1).
Jul 9 2015, 2:20 AM · Harbormaster
epriestley merged task T8806: Buildable status icon is really hard to read between blue / green colours into T8096: Improve Harbormaster UI/UX (v1).
Jul 9 2015, 2:20 AM · Harbormaster

Jul 8 2015

epriestley added a comment to T8805: Improve error checking for third-party unit test engines.

It looks like the culprit is likely in first-party code:

Jul 8 2015, 10:17 PM · Arcanist
epriestley created T8805: Improve error checking for third-party unit test engines.
Jul 8 2015, 10:15 PM · Arcanist
epriestley added a comment to T8588: One instance has a severe, global performance issue.

That bump for the INSERT is expected when you enable the profiler -- it's just saving the profile itself (the page as a whole will run a bit slower, too, which is normal/expected).

Jul 8 2015, 7:22 PM · Restricted Project
epriestley added a comment to T8783: Unprototype Nuance (v1).

I expect that kind of stuff to be a good fit, yeah.

Jul 8 2015, 4:29 PM · Nuance, Restricted Project
epriestley closed T8801: Cannot find a way to generate a request with the right requestData as Wontfix.

Sorry, we don't offer support with third-party custom development. See "Supported Issues" here:

Jul 8 2015, 3:56 PM · Config, Aphront, Maniphest
epriestley added a comment to T8794: Support "Add follow-up task" action in Maniphest.

Ah, it sounds like you really want something like "Create Supertask" -- the opposite of "Create Subtask" -- rather than something more like "Create Sibling Task", which is where related/followup were previously headed.

Jul 8 2015, 2:24 PM · OpenStack, Maniphest