In T13208#242142, @epriestley wrote:

To reproduce this issue, just need to Click on Default Column -> View as Query then leaving without Saving the query.

These reproduction steps don't work for me, and don't make sense given how the software works. If you believe you have a set of reproduction steps, can you walk through them step-by-step in more detail so I can reproduce the issue?

If anyone can come up with reproduction steps which actually work, this will probably take me about 3 minutes to fix. The only thing blocking this is that I have no idea how to reproduce it.

@epriestley, would you mind taking a look at this diff?

Maybe add some comments?

I think maybe we should keep it as an empty n_CLASS_ATTRIBUTES in case attributes are added later.

Automated landing didn't work so I'll do it the old-fashioned way.

@epriestley, would you be open to making the chunk size configurable? Changing the chunk size from 32 to 512 reduced the amount of time required for us to lint ~1500 TypeScript files from 370 seconds to 66 seconds.

I can just do this with D19730 instead.

In rPc5960c71f92995ab9cae5e1f700268ce25c24c3a#43947, @epriestley wrote:

That seems weird, but it sort of expected/desirable.

If the Conduit calls for Branches/Tags fail to generate, we put the error message from the call into the email. This seemed better than: dropping the email; omitting the sections; or putting a generic "something went wrong" message in the email. D13319 and T8574 appear to be the genesis of this behavior.

In most cases, the error is a Conduit-level error ("your account is disabled", "the specified repository does not exist") and one or two lines long, and the message is likely relatively useful in understanding why that section didn't render.

In this case, the host itself was toast since I couldn't get through storage upgrades without this patch, so we got an actual HTTP-level error, and the exception message for these is just a big chunk of the response body since it's sometimes useful in understanding what went wrong.

So even though this outcome is a little goofy, I think all the rules that led us there are mostly pretty reasonable, and don't see anything obvious that should be changed/fixed.

In D19630#242860, @epriestley wrote:

T13098 is "happening" very "soon" quote unquote "quote" "unquote" "Soon™".

In D19630#242798, @epriestley wrote:

I believe it is nearly the end of days for this version of arc so I'm fine with just letting some stuff like this in.

In D19629#242776, @avivey wrote:

Almost all of us:

Looks like it depends on which instance you hit: https://www.ssllabs.com/ssltest/analyze.html?d=www.php.net&latest

Unrelated to this change, but this is from the email I received about it:

Even with OAuth, you still can't make AJAX requests to Conduit from client-side JavaScript, right? Is the idea that the backend code uses OAuth to talk to Conduit on a user's behalf?

Fix someone else's mistakes

There's still a bunch of logic in ArcanistLintEngine and ArcanistLintEngine regarding caching... should that be removed/deprecated as well?

FWIW, I am using a custom file and mail engine that utilises the AWS SDK and supports instance profile credentials. See P2082 and P2083. You need to install and require the AWS SDK before using these extensions.

Update src/parser/xhpast/parser_nodes.php

I will land it shortly.

Minor

In D18621#227381, @epriestley wrote:

Do you want to just delete all the tests and I'll accept those and abandon D17819?

Oh cool. I'm somewhat surprised this is being accepted as I expected it to be blocked on T4334#222499.

Thanks for the detailed response, I certainly didn't expect it.

In D18378#224025, @epriestley wrote:

! joshuaspence (Joshua Spence)

• Mail Tags: This mail has tags which control which users receive it, and this recipient has not elected to receive mail with any of the tags on this message (Settings > Email Preferences).

Do you have "Differential > Other Activity Not Listed Above" set to "Notify" or "Ignore"?

(interestingly, I didn't receive an email about this diff being accepted)

In T12959#230805, @chad wrote:

In general are you aware we no longer take bug reports or feature requests here?

In T12959#230799, @chad wrote:

What does "mysterious" mean.