Paths

Table of Contentst

Differential D18770

Add support for nullable parameter types
ClosedPublic
Actions

Authored by joshuaspence on Nov 13 2017, 4:36 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T4334: Support PHP5.4+ syntax in XHPAST

Commits

rPHU32746e8b0793: Add support for nullable parameter types

Summary

Ref T4334. Adds support for nullable parameter types, which are a thing as of PHP 7.1.

Test Plan

Added unit tests.

Diff Detail

Repository

rPHU libphutil

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence created this revision.Nov 13 2017, 4:36 AM

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 13 2017, 4:36 AM

Herald added a subscriber: Firehed. · View Herald Transcript

Harbormaster completed remote builds in B18824: Diff 45042.Nov 13 2017, 4:37 AM

joshuaspence requested review of this revision.Nov 13 2017, 4:37 AM

epriestley accepted this revision.Nov 16 2017, 5:50 PM

This revision is now accepted and ready to land.Nov 16 2017, 5:50 PM

Herald added a subscriber: Korvin. · View Herald TranscriptNov 16 2017, 5:50 PM

When can this diff be landed?

I will land it shortly.

Update src/parser/xhpast/parser_nodes.php

Harbormaster completed remote builds in B18853: Diff 45074.Nov 24 2017, 5:13 AM

Closed by commit rPHU32746e8b0793: Add support for nullable parameter types (authored by joshuaspence). · Explain WhyNov 26 2017, 10:42 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

parser/

xhpast/

__tests__/

data/

optional-parameter.php.test

282 lines

return-type.php.test

119 lines

bin/

PhutilXHPASTBinary.php

2 lines

parser_nodes.php

1 line

support/

xhpast/

1 line

12 lines

3166 lines

1 line

2 lines

Diff 45075

View Options

src/parser/xhpast/tests/data/optional-parameter.php.test

View Options

src/parser/xhpast/tests/data/return-type.php.test

View Options

src/parser/xhpast/bin/PhutilXHPASTBinary.php

View Options

src/parser/xhpast/parser_nodes.php

View Options

support/xhpast/generate_nodes.php

View Options

support/xhpast/parser.y

View Options

support/xhpast/parser.yacc.cpp

View Options

support/xhpast/parser_nodes.php

View Options

Add support for nullable parameter typesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 45075

src/parser/xhpast/__tests__/data/optional-parameter.php.test

src/parser/xhpast/__tests__/data/return-type.php.test

src/parser/xhpast/bin/PhutilXHPASTBinary.php

src/parser/xhpast/parser_nodes.php

support/xhpast/generate_nodes.php

support/xhpast/parser.y

support/xhpast/parser.yacc.cpp

support/xhpast/parser_nodes.php

support/xhpast/xhpast.cpp

Add support for nullable parameter types
ClosedPublic
Actions

Revision Contents
Changeset List

src/parser/xhpast/tests/data/optional-parameter.php.test

src/parser/xhpast/tests/data/return-type.php.test