Page MenuHomePhabricator

Remove "arc lint --cache"
ClosedPublic

Authored by epriestley on Sep 25 2017, 6:22 PM.

Details

Summary

Ref T12996. This is another half-baked Facebook-specific feature. Clear it out of the way so arc lint can be modernized more easily.

Test Plan

Grepped for cache, created this revision.

Diff Detail

Repository
rARC Arcanist
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Sep 25 2017, 6:22 PM
amckinley accepted this revision.Sep 25 2017, 6:30 PM
This revision is now accepted and ready to land.Sep 25 2017, 6:30 PM
This revision was automatically updated to reflect the committed changes.

There's still a bunch of logic in ArcanistLintEngine and ArcanistLintEngine regarding caching... should that be removed/deprecated as well?

Yeah. I think granularity on lint messages gets a mention in T13098, at least. I don't currently plan to rebuild support for this stuff, at least until all the dust has settled on the whole huge tree of issues under T13098.