HomePhabricator

Improve symbol generation scripts

Authored by joshuaspence on Aug 15 2018, 8:39 PM.

Description

Improve symbol generation scripts

Summary: Currently the symbol generation scripts fail if passed a list containing no files because explode("\n", $input) returns array("") rather than array(). This means that a generic Harbormaster Build Plan with a step which executes find . -type f -name '*.php' | ./scripts/generate_php_symbols.php won't work because it fails in repositories that don't contain any PHP code.

Test Plan: Ran echo | generate_php_symbols and saw no output instead of an exception.

Reviewers: epriestley, Blessed Reviewers

Reviewed By: epriestley, Blessed Reviewers

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D19588

Details

Committed
joshuaspenceAug 15 2018, 8:40 PM
Pushed
joshuaspenceAug 15 2018, 8:40 PM
Reviewer
Blessed Reviewers
Differential Revision
D19588: Improve symbol generation scripts
Parents
rPcc1def6ceaab: Remove some array typehints for passing around
Branches
Unknown
Tags
Unknown
Build Status
Buildable 20624
Build 28028: Run Core Tests