Page MenuHomePhabricator

Remove `bin/files purge` workflow
ClosedPublic

Authored by epriestley on Aug 10 2017, 1:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 26, 2:39 PM
Unknown Object (File)
Tue, Mar 26, 2:39 PM
Unknown Object (File)
Tue, Mar 26, 2:39 PM
Unknown Object (File)
Wed, Feb 28, 6:40 AM
Unknown Object (File)
Feb 1 2024, 9:26 PM
Unknown Object (File)
Jan 23 2024, 10:07 AM
Unknown Object (File)
Dec 27 2023, 11:46 AM
Unknown Object (File)
Dec 21 2023, 8:23 PM
Subscribers
None

Details

Summary

Fixes T12948. See that task for substantial discussion and context. Briefly:

  • This workflow is very old, and won't work for large (>2GB) files.
  • This workflow has become more dangerous than it once was, and can fail in several ways that delete data and/or make recovery much more difficult (see T12948 for more discussion).
  • This was originally added in D6068, which is a bit muddled, but looks like "one install ran into a weird issue so I wrote a script for them"; this would be a Consulting/Support issue and not come upstream today. I can't identify any arguments for retaining this workflow there, at least.
Test Plan
  • Grepped for files purge, got nothing.
  • Grepped for purge, looked for anything that looked like instructions or documentation, got nothing.

I don't recall recommending anyone run this script in many years, and didn't even remember that it existed or what it did when T12948 was reported, so I believe it is not in widespread use.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Aug 10 2017, 1:22 PM
This revision was automatically updated to reflect the committed changes.