Page MenuHomePhabricator

Improve symbol generation scripts
ClosedPublic

Authored by joshuaspence on Aug 15 2018, 1:25 AM.
Tags
None
Referenced Files
F13086091: D19588.diff
Thu, Apr 25, 12:03 AM
Unknown Object (File)
Fri, Apr 19, 7:52 PM
Unknown Object (File)
Wed, Apr 17, 3:07 PM
Unknown Object (File)
Wed, Apr 17, 1:45 PM
Unknown Object (File)
Sat, Apr 13, 6:14 AM
Unknown Object (File)
Fri, Apr 12, 3:43 AM
Unknown Object (File)
Thu, Apr 11, 8:54 PM
Unknown Object (File)
Thu, Apr 11, 8:20 AM
Subscribers

Details

Summary

Currently the symbol generation scripts fail if passed a list containing no files because explode("\n", $input) returns array("") rather than array(). This means that a generic Harbormaster Build Plan with a step which executes find . -type f -name '*.php' | ./scripts/generate_php_symbols.php won't work because it fails in repositories that don't contain any PHP code.

Test Plan

Ran echo | generate_php_symbols and saw no output instead of an exception.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

These scripts may not be long for this world (see T13047) but this change seems reasonable.

This revision is now accepted and ready to land.Aug 15 2018, 4:58 PM
This revision was automatically updated to reflect the committed changes.