Page MenuHomePhabricator
Differential D19736

Add support for anonymous class
ClosedPublic
Actions

Authored by wjiang on Oct 8 2018, 12:51 AM.

Active Operations

Details

Reviewers
joshuaspence
thaiphv
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T4334: Support PHP5.4+ syntax in XHPAST
Commits
rPHU8c1091dc9892: (stable) Promote 2018 Week 41
rPHU603209bb1756: Add support for anonymous class
Summary

Ref T4334. Adds support for anonymous class, which is supported by PHP 7.0.

Test Plan

Added test cases.

Diff Detail

Repository
rPHU libphutil
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

wjiang created this revision.Oct 8 2018, 12:51 AM
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptOct 8 2018, 12:51 AM
Herald added subscribers: Firehed, epriestley. · View Herald Transcript
wjiang requested review of this revision.Oct 8 2018, 12:51 AM
Harbormaster completed remote builds in B20999: Diff 47156.Oct 8 2018, 12:51 AM
wjiang added a reviewer: thaiphv.Oct 8 2018, 12:53 AM
joshuaspence accepted this revision.Oct 8 2018, 12:54 AM
epriestley accepted this revision.Oct 8 2018, 2:05 PM
This revision is now accepted and ready to land.Oct 8 2018, 2:05 PM
Herald added a subscriber: Korvin. · View Herald TranscriptOct 8 2018, 2:05 PM
joshuaspence added a comment.Oct 8 2018, 11:34 PM

Automated landing didn't work so I'll do it the old-fashioned way.

Closed by commit rPHU603209bb1756: Add support for anonymous class (authored by wjiang, committed by joshuaspence). · Explain WhyOct 8 2018, 11:39 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
parser/
xhpast/
__tests__/
data/
599 lines
bin/
2 lines
support/
xhpast/
15 lines
2 lines

Diff 47161

View Options

src/parser/xhpast/__tests__/data/anonymous_class.php.test

Loading...
View Options

src/parser/xhpast/bin/PhutilXHPASTBinary.php

Loading...
View Options

support/xhpast/parser.y

Loading...
View Options

support/xhpast/parser.yacc.cpp

Loading...
View Options

support/xhpast/scanner.lex.hpp

Loading...
View Options

support/xhpast/scanner.lex.cpp

Loading...
View Options

support/xhpast/xhpast.cpp

Loading...
Phabricator · Built by Phacility