Differential D19736

Add support for anonymous class
ClosedPublic
Actions

Authored by wjiang on Oct 8 2018, 12:51 AM.

Tags

None

Subscribers

Korvin, epriestley, Firehed

Active Operations

Operation 278 Land Revision
Operation encountered an error.

Details

Reviewers

joshuaspence
thaiphv
epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T4334: Support PHP5.4+ syntax in XHPAST

Commits

rPHU8c1091dc9892: (stable) Promote 2018 Week 41
rPHU603209bb1756: Add support for anonymous class

Summary

Ref T4334. Adds support for anonymous class, which is supported by PHP 7.0.

Test Plan

Added test cases.

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

wjiang created this revision.Oct 8 2018, 12:51 AM

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptOct 8 2018, 12:51 AM

Herald added subscribers: Firehed, epriestley. · View Herald Transcript

wjiang requested review of this revision.Oct 8 2018, 12:51 AM

Harbormaster completed remote builds in B20999: Diff 47156.Oct 8 2018, 12:51 AM

wjiang added a reviewer: thaiphv.Oct 8 2018, 12:53 AM

joshuaspence accepted this revision.Oct 8 2018, 12:54 AM

epriestley accepted this revision.Oct 8 2018, 2:05 PM

This revision is now accepted and ready to land.Oct 8 2018, 2:05 PM

Herald added a subscriber: Korvin. · View Herald TranscriptOct 8 2018, 2:05 PM

Automated landing didn't work so I'll do it the old-fashioned way.

Closed by commit rPHU603209bb1756: Add support for anonymous class (authored by wjiang, committed by joshuaspence). · Explain WhyOct 8 2018, 11:39 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
A	M		src/parser/xhpast/__tests__/data/anonymous_class.php.test (599 lines)
M			src/parser/xhpast/bin/PhutilXHPASTBinary.php (2 lines)
M			support/xhpast/parser.y (15 lines)
M			support/xhpast/parser.yacc.cpp (3654 lines)
M			support/xhpast/scanner.lex.hpp (485 lines)
M			support/xhpast/scanner.lex.cpp (1152 lines)
M			support/xhpast/xhpast.cpp (2 lines)

Diff 47161

src/parser/xhpast/tests/data/anonymous_class.php.test

Loading...

src/parser/xhpast/bin/PhutilXHPASTBinary.php

Loading...

support/xhpast/parser.y

Loading...

support/xhpast/parser.yacc.cpp

Loading...

support/xhpast/scanner.lex.hpp

Loading...

support/xhpast/scanner.lex.cpp

Loading...

support/xhpast/xhpast.cpp

Loading...