Fix node for nullable return value
ClosedPublic
Actions

Authored by joshuaspence on Sep 25 2017, 5:32 AM.

Tags

None

Referenced Files

	F18633733: D18639.id.diff
	Tue, Sep 16, 8:56 PM

	F18619906: D18639.diff
	Mon, Sep 15, 3:42 AM

	F18514149: D18639.id44754.diff
	Fri, Sep 5, 10:02 AM

	F18234648: D18639.id44754.diff
	Aug 20 2025, 6:23 PM

	F18093474: D18639.diff
	Aug 7 2025, 6:37 PM

	F18081714: D18639.id45073.diff
	Aug 5 2025, 1:42 AM

	F18058469: D18639.id45073.diff
	Aug 4 2025, 9:42 AM

	F18051839: D18639.id.diff
	Aug 4 2025, 12:34 AM

Subscribers

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T4334: Support PHP5.4+ syntax in XHPAST

Commits

rPHUae80e72461d2: Fix node for nullable return value

Summary

Ref T4334. Fixes a bug introduced by D18621 which created a node without a valid type.

Test Plan

N/A

Diff Detail

Repository

rPHU libphutil

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence created this revision.Sep 25 2017, 5:32 AM

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptSep 25 2017, 5:32 AM

Herald added subscribers: Firehed, Korvin. · View Herald Transcript

Harbormaster completed remote builds in B18532: Diff 44754.Sep 25 2017, 5:33 AM

epriestley accepted this revision.Sep 25 2017, 1:26 PM

This revision is now accepted and ready to land.Sep 25 2017, 1:26 PM

Closed by commit rPHUae80e72461d2: Fix node for nullable return value (authored by joshuaspence). · Explain WhyNov 24 2017, 3:27 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

parser/

xhpast/

__tests__/

data/

return-type.php.test

10 lines

bin/

PhutilXHPASTBinary.php

2 lines

support/

xhpast/

parser.y

2 lines

parser.yacc.cpp

2 lines

xhpast.cpp

2 lines

Diff 45073

View Options

src/parser/xhpast/tests/data/return-type.php.test

View Options

src/parser/xhpast/bin/PhutilXHPASTBinary.php

View Options

support/xhpast/parser.y

View Options

support/xhpast/parser.yacc.cpp

View Options

Fix node for nullable return valueClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 45073

src/parser/xhpast/__tests__/data/return-type.php.test

src/parser/xhpast/bin/PhutilXHPASTBinary.php

support/xhpast/parser.y

support/xhpast/parser.yacc.cpp

support/xhpast/xhpast.cpp

Fix node for nullable return value
ClosedPublic
Actions

Revision Contents
Changeset List

src/parser/xhpast/tests/data/return-type.php.test