Page MenuHomePhabricator
Differential D18639

Fix node for nullable return value
ClosedPublic
Actions

Authored by joshuaspence on Sep 25 2017, 5:32 AM.
Tags
None
Referenced Files
F18081714: D18639.id45073.diff
Tue, Aug 5, 1:42 AM
F18058469: D18639.id45073.diff
Mon, Aug 4, 9:42 AM
F18051839: D18639.id.diff
Mon, Aug 4, 12:34 AM
F18034711: D18639.diff
Sun, Aug 3, 1:16 AM
F17932385: D18639.id.diff
Wed, Jul 30, 8:08 PM
F17894100: D18639.diff
Tue, Jul 29, 5:29 AM
F17626859: D18639.id44754.diff
Thu, Jul 10, 5:21 AM
Unknown Object (File)
Jul 3 2025, 10:23 AM
View All Files
Subscribers
Firehed
Korvin
wjiang

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T4334: Support PHP5.4+ syntax in XHPAST
Commits
rPHUae80e72461d2: Fix node for nullable return value
Summary

Ref T4334. Fixes a bug introduced by D18621 which created a node without a valid type.

Test Plan

N/A

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
parser/
xhpast/
__tests__/
data/
10 lines
bin/
2 lines
support/
xhpast/
2 lines
2 lines
2 lines

Diff 45073

View Options

src/parser/xhpast/__tests__/data/return-type.php.test

Loading...
View Options

src/parser/xhpast/bin/PhutilXHPASTBinary.php

Loading...
View Options

support/xhpast/parser.y

Loading...
View Options

support/xhpast/parser.yacc.cpp

Loading...
View Options

support/xhpast/xhpast.cpp

Loading...
Phabricator · Built by Phacility