Page MenuHomePhabricator
Differential D18639

Fix node for nullable return value
ClosedPublic
Actions

Authored by joshuaspence on Sep 25 2017, 5:32 AM.
Tags
None
Referenced Files
F19504501: D18639.diff
Fri, Jan 9, 5:15 AM
F19504454: D18639.diff
Fri, Jan 9, 5:11 AM
F19043833: D18639.id44754.diff
Nov 27 2025, 1:04 AM
F19036810: D18639.id.diff
Nov 25 2025, 8:41 PM
F19024602: D18639.diff
Nov 24 2025, 3:44 AM
F18992092: D18639.diff
Nov 19 2025, 12:36 AM
F18814163: D18639.id.diff
Oct 20 2025, 9:57 PM
F18813088: D18639.diff
Oct 20 2025, 1:57 PM
View All Files
Subscribers
Firehed
Korvin
wjiang

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T4334: Support PHP5.4+ syntax in XHPAST
Commits
rPHUae80e72461d2: Fix node for nullable return value
Summary

Ref T4334. Fixes a bug introduced by D18621 which created a node without a valid type.

Test Plan

N/A

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
parser/
xhpast/
__tests__/
data/
10 lines
bin/
2 lines
support/
xhpast/
2 lines
2 lines
2 lines

Diff 45073

View Options

src/parser/xhpast/__tests__/data/return-type.php.test

Loading...
View Options

src/parser/xhpast/bin/PhutilXHPASTBinary.php

Loading...
View Options

support/xhpast/parser.y

Loading...
View Options

support/xhpast/parser.yacc.cpp

Loading...
View Options

support/xhpast/xhpast.cpp

Loading...
Phabricator · Built by Phacility