Page MenuHomePhabricator

Remove chatbot example configuration
ClosedPublic

Authored by joshuaspence on Aug 9 2017, 10:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 1, 10:48 PM
Unknown Object (File)
Tue, Nov 26, 4:54 PM
Unknown Object (File)
Tue, Nov 26, 4:23 PM
Unknown Object (File)
Tue, Nov 26, 12:56 PM
Unknown Object (File)
Thu, Nov 21, 9:43 AM
Unknown Object (File)
Mon, Nov 18, 8:54 PM
Unknown Object (File)
Thu, Nov 14, 10:54 PM
Unknown Object (File)
Nov 6 2024, 12:00 AM
Subscribers

Details

Summary

This is no longer needed after the chatbot was removed in D17756.

Test Plan

N/A

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Aug 9 2017, 10:34 PM

(interestingly, I didn't receive an email about this diff being accepted)

This revision was automatically updated to reflect the committed changes.

! joshuaspence (Joshua Spence)

  • Mail Tags: This mail has tags which control which users receive it, and this recipient has not elected to receive mail with any of the tags on this message (Settings > Email Preferences).

Do you have "Differential > Other Activity Not Listed Above" set to "Notify" or "Ignore"?

src/applications/files/storage/PhabricatorFile.php
857

Oh wtf. This wasn't in the diff. I used "Land Revision"

! joshuaspence (Joshua Spence)

  • Mail Tags: This mail has tags which control which users receive it, and this recipient has not elected to receive mail with any of the tags on this message (Settings > Email Preferences).

Do you have "Differential > Other Activity Not Listed Above" set to "Notify" or "Ignore"?

Ah right, thanks

src/applications/files/storage/PhabricatorFile.php
857

I'll revert when I get back to mylaptop

If you put change X on master, then change Y, then arc diff X, the web UI will show Y but "land revision" will land X + Y. This is bad/confusing but not trivial to fix since the web UI and staging area don't really know about one another right now.

Sounds good, doesn't look like it'll break anything anyway. I'll send you a revert if I get there first.