Page MenuHomePhabricator

Allow filename for linter tests to be explicitly specified
Needs ReviewPublic

Authored by joshuaspence on Sep 27 2017, 5:14 AM.
Tags
None
Referenced Files
F19739657: D18650.id44771.diff
Sun, Feb 15, 8:30 AM
F18757470: D18650.diff
Oct 5 2025, 5:33 PM
F18612428: D18650.id44771.diff
Sep 14 2025, 9:03 AM
F18517716: D18650.id44771.diff
Sep 5 2025, 1:50 PM
F18513300: D18650.id44771.diff
Sep 5 2025, 9:21 AM
F18513002: D18650.id.diff
Sep 5 2025, 8:49 AM
F18512219: D18650.diff
Sep 5 2025, 7:45 AM
F18510919: D18650.diff
Sep 5 2025, 5:55 AM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

Currently the temporary file created for testing linters is always named the same as the *.lint-test file which specifies the test case. Unfortunately, some linters (in my case, TSLint) refuse to lint a file unless it has a specific file extension. This diff allows *.lint-test test cases to explicitly specify a filename for this purpose.

Test Plan

Tested with our custom TSLint linter.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 18548
Build 24989: Run Core Tests
Build 24988: arc lint + arc unit