Very soon now, git is getting an exciting new wire protocol. Highlights are improving performance on repos with unholy amount of refs, and being "easier to expand".

D19269 makes Harbormaster objects destructible. I've made Build destroy BuildMessage (which it doesn't receive, so this never destroys anything) but not BuildCommand (which it does receive), so that when this change is made (and it starts receiving BuildMessage instead of BuildCommand) things will just work. Until then, BuildCommand objects are technically left hanging, but destroying builds is exceptionally rare so I'm just assuming that this will probably be fixed before anyone notices.

(Note that it will only work for more-recent logs, T13088 will have some guidance for older logs eventually.)

I missed this task when collecting T13088, but this is supported after D19151.

Having looked at the code some more, I see when the HeraldPreCommitRefAdapter runs, there is no parsed commit object yet, so there's no way to invoke harbormaster (what would the container PHID be?). This kind of makes sense.

I'm rolling this forward into T13103 but don't actually plan to implement Harbormaster build icons at this time since there are no outstanding requests from customers.

Current state of the world here is:

Resolved by D19163 etc., see T13088.

Effectively resolved by D19167; see T13088 for followups.

I'm not currently planning to build this, per se. See T13088 / T6139 for lighter-weight support around log summarization.

Likely resolved by D19166, see T13088 for followups.

Add line numbers and links to the log page with proper copy/paste behavior.

Add line numbers and links to the log page ... This is actually legitimately hard without scanning the entire file. Maybe we can emit a map as part of finalization which shows which has line markers every megabyte or so.

Maybe summarization and highlighting aren't the same object?

Very rough version of the new log:

As a note, pv can rate limit a pipe and is generally very useful all around.

this is a very good task :)

i used gem install so that i could remain ignorant of those types of problems

haha

I suppose welding does normally take a long time.

it has an -s option

There is a program far superior to cat that already exists.

Testing any of this is also a pain right now, so before any of that happens I'm going to write bin/harbormaster build --log output.txt or bin/harbormaster write-a-log or something. This overlaps the actual API-writing request in T9124, but that has more complicated concerns (like UTF8 issues, writing to a closed log, etc).

maybe a "grep" would be nice

I'm planning to tackle the build log stuff first since it's the most clear-cut, all fairly close together, and also roughly the most dumb.

The build itself can do this over Conduit. Although it's possible we'll support things like this some day, I think this is currently too niche and disconnected from other application behavior to pursue in the upstream.

That is, we mutated the object outside of the Editor, then relied on the Editor to save the mutation.

See T13072 for Harbormaster followups.