Page MenuHomePhabricator

Correct line highlighting behavior in Diffusion
ClosedPublic

Authored by epriestley on Mar 7 2018, 3:04 PM.
Tags
None
Referenced Files
F18807548: D19187.id45955.diff
Oct 19 2025, 2:16 AM
F18681686: D19187.id.diff
Sep 26 2025, 4:48 AM
F18626203: D19187.id45956.diff
Sep 16 2025, 12:45 AM
F18509405: D19187.id.diff
Sep 5 2025, 3:23 AM
F18502336: D19187.diff
Sep 4 2025, 10:22 PM
F18195492: D19187.id45955.diff
Aug 17 2025, 4:04 PM
F18187086: D19187.id.diff
Aug 16 2025, 7:19 PM
F18162650: D19187.diff
Aug 15 2025, 4:52 AM
Subscribers
None

Details

Summary

See https://discourse.phabricator-community.org/t/line-highlighting-in-diffusion-breaks-url/1207. Ref T13088. This was disrupted by changes for the new Harbormaster build logs and now needs an explicit base URI.

Test Plan

Clicked lines and dragged across line ranges in Diffusion, observed correct URI behavior.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 7 2018, 3:05 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.