Page MenuHomePhabricator
Differential D19187

Correct line highlighting behavior in Diffusion
ClosedPublic
Actions

Authored by epriestley on Mar 7 2018, 3:04 PM.
Tags
None
Referenced Files
F17686339: D19187.id45956.diff
Mon, Jul 14, 5:47 AM
F17682493: D19187.id.diff
Sun, Jul 13, 8:44 PM
F17681039: D19187.id45955.diff
Sun, Jul 13, 5:52 PM
F17651861: D19187.diff
Sat, Jul 12, 6:10 AM
Unknown Object (File)
Jun 17 2025, 8:29 AM
Unknown Object (File)
Jun 7 2025, 7:54 PM
Unknown Object (File)
Jun 6 2025, 4:43 AM
Unknown Object (File)
May 31 2025, 12:13 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13088: Plans: Harbormaster UI usability and interconnectedness
Commits
rPdab0f84b670d: (stable) Correct line highlighting behavior in Diffusion
rPc6a042b59acf: Correct line highlighting behavior in Diffusion
Summary

See https://discourse.phabricator-community.org/t/line-highlighting-in-diffusion-breaks-url/1207. Ref T13088. This was disrupted by changes for the new Harbormaster build logs and now needs an explicit base URI.

Test Plan

Clicked lines and dragged across line ranges in Diffusion, observed correct URI behavior.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Mar 7 2018, 3:04 PM
Harbormaster completed remote builds in B19770: Diff 45955.Mar 7 2018, 3:05 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 7 2018, 3:05 PM
epriestley requested review of this revision.
Closed by commit rPc6a042b59acf: Correct line highlighting behavior in Diffusion (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
controller/
18 lines

Diff 45956

View Options

src/applications/diffusion/controller/DiffusionBrowseController.php

Loading...
Phabricator · Built by Phacility