Differential D19187

Correct line highlighting behavior in Diffusion
ClosedPublic
Actions

Authored by epriestley on Mar 7 2018, 3:04 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Feb 9, 5:38 AM

	Unknown Object (File)
	Sun, Feb 9, 5:38 AM

	Unknown Object (File)
	Sun, Feb 9, 5:38 AM

	Unknown Object (File)
	Wed, Feb 5, 12:55 AM

	Unknown Object (File)
	Tue, Jan 28, 3:31 AM

	Unknown Object (File)
	Jan 25 2025, 12:32 AM

	Unknown Object (File)
	Jan 25 2025, 12:32 AM

	Unknown Object (File)
	Jan 25 2025, 12:32 AM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13088: Plans: Harbormaster UI usability and interconnectedness
Commits: rPdab0f84b670d: (stable) Correct line highlighting behavior in Diffusion
rPc6a042b59acf: Correct line highlighting behavior in Diffusion

Summary

See https://discourse.phabricator-community.org/t/line-highlighting-in-diffusion-breaks-url/1207. Ref T13088. This was disrupted by changes for the new Harbormaster build logs and now needs an explicit base URI.

Test Plan

Clicked lines and dragged across line ranges in Diffusion, observed correct URI behavior.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Mar 7 2018, 3:04 PM

Harbormaster completed remote builds in B19770: Diff 45955.Mar 7 2018, 3:05 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 7 2018, 3:05 PM

epriestley requested review of this revision.

Closed by commit rPc6a042b59acf: Correct line highlighting behavior in Diffusion (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

controller/

DiffusionBrowseController.php

18 lines

Diff 45956

View Options

src/applications/diffusion/controller/DiffusionBrowseController.php

Correct line highlighting behavior in DiffusionClosedPublicActions