Page MenuHomePhabricator
Differential D19133

Add a very basic standalone view for build logs with a "Download Log" button
ClosedPublic
Actions

Authored by epriestley on Feb 23 2018, 3:20 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Feb 10, 3:15 AM
Unknown Object (File)
Sun, Feb 9, 5:32 AM
Unknown Object (File)
Sun, Feb 9, 5:32 AM
Unknown Object (File)
Sun, Feb 9, 5:32 AM
Unknown Object (File)
Wed, Feb 5, 3:23 AM
Unknown Object (File)
Mon, Feb 3, 11:18 PM
Unknown Object (File)
Thu, Jan 30, 1:20 AM
Unknown Object (File)
Tue, Jan 28, 3:25 AM
View All Files
Subscribers
Restricted Owners Package

Details

Reviewers
None
Maniphest Tasks
T13088: Plans: Harbormaster UI usability and interconnectedness
Commits
rP9b4295ed6051: Add a very basic standalone view for build logs with a "Download Log" button
Summary

Depends on D19132. Ref T13088. This implements an extremely skeletal dedicated log page with a more-or-less functional "Download Log" button.

Test Plan

Downloaded a recent log. Tried to download an old (un-finalized) log, couldn't. Used bin/harbormaster write-log to get a convenient standalone link to a log.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 23 2018, 3:20 AM
Owners added a subscriber: Restricted Owners Package.Feb 23 2018, 3:20 AM
Harbormaster completed remote builds in B19648: Diff 45839.Feb 23 2018, 3:21 AM
epriestley requested review of this revision.Feb 23 2018, 3:21 AM
epriestley added a child revision: D19134: Implement DestructibleInterface on BuildLog.Feb 23 2018, 1:18 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 27 2018, 1:53 AM
Closed by commit rP9b4295ed6051: Add a very basic standalone view for build logs with a "Download Log" button (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 45854

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/harbormaster/application/PhabricatorHarbormasterApplication.php

Loading...
View Options

src/applications/harbormaster/controller/HarbormasterBuildLogDownloadController.php

Loading...
View Options

src/applications/harbormaster/controller/HarbormasterBuildLogViewController.php

Loading...
View Options

src/applications/harbormaster/management/HarbormasterManagementWriteLogWorkflow.php

Loading...
View Options

src/applications/harbormaster/phid/HarbormasterBuildLogPHIDType.php

Loading...
View Options

src/applications/harbormaster/storage/build/HarbormasterBuildLog.php

Loading...
View Options

src/applications/harbormaster/view/HarbormasterBuildLogView.php

Loading...
Phabricator · Built by Phacility