Differential D19165

Share the Paste line highlighting behavior for Harbormaster build logs
ClosedPublic
Actions

Authored by epriestley on Mar 1 2018, 4:04 PM.

Details

Reviewers: None
Maniphest Tasks: T13088: Plans: Harbormaster UI usability and interconnectedness
Commits: rP73619c4643c9: Share the Paste line highlighting behavior for Harbormaster build logs

Summary

Depends on D19164. Ref T13088. Now that the JS behaviors are generic, use them on the Harbormaster standalone page.

Test Plan

Clicked lines and dragged across line ranges. Reloaded pages. Saw expected highlighting behavior in the client and on the server across reloads.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Mar 1 2018, 4:04 PM

Owners added a subscriber: Restricted Owners Package.Mar 1 2018, 4:04 PM

Harbormaster completed remote builds in B19714: Diff 45905.Mar 1 2018, 4:05 PM

epriestley requested review of this revision.Mar 1 2018, 4:05 PM

epriestley added a child revision: D19166: Prevent copying Harbormaster build log line numbers with CSS psuedocontent instead of ZWS.Mar 1 2018, 4:17 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 1 2018, 8:57 PM

Closed by commit rP73619c4643c9: Share the Paste line highlighting behavior for Harbormaster build logs (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

4 lines

src/

applications/

harbormaster/

controller/

HarbormasterBuildLogRenderController.php

14 lines

HarbormasterBuildLogViewController.php

3 lines

view/

HarbormasterBuildLogView.php

10 lines

webroot/

rsrc/

css/

application/

harbormaster/

harbormaster.css

6 lines

Diff 45911

View Options

resources/celerity/map.php

View Options

src/applications/harbormaster/controller/HarbormasterBuildLogRenderController.php

View Options

src/applications/harbormaster/controller/HarbormasterBuildLogViewController.php

View Options

src/applications/harbormaster/view/HarbormasterBuildLogView.php

View Options

webroot/rsrc/css/application/harbormaster/harbormaster.css

Share the Paste line highlighting behavior for Harbormaster build logsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 45911

resources/celerity/map.php

src/applications/harbormaster/controller/HarbormasterBuildLogRenderController.php

src/applications/harbormaster/controller/HarbormasterBuildLogViewController.php

src/applications/harbormaster/view/HarbormasterBuildLogView.php

webroot/rsrc/css/application/harbormaster/harbormaster.css

Share the Paste line highlighting behavior for Harbormaster build logs
ClosedPublic
Actions

Revision Contents
Changeset List