Page MenuHomePhabricator
Differential D19165

Share the Paste line highlighting behavior for Harbormaster build logs
ClosedPublic
Actions

Authored by epriestley on Mar 1 2018, 4:04 PM.
Tags
None
Referenced Files
F14415961: D19165.id.diff
Tue, Dec 24, 7:51 PM
Unknown Object (File)
Thu, Dec 19, 7:46 AM
Unknown Object (File)
Sat, Dec 14, 7:20 AM
Unknown Object (File)
Tue, Dec 10, 6:43 PM
Unknown Object (File)
Sun, Dec 8, 11:35 PM
Unknown Object (File)
Sat, Dec 7, 6:37 AM
Unknown Object (File)
Fri, Dec 6, 5:21 PM
Unknown Object (File)
Tue, Dec 3, 3:52 PM
View All Files
Subscribers
Restricted Owners Package

Details

Reviewers
None
Maniphest Tasks
T13088: Plans: Harbormaster UI usability and interconnectedness
Commits
rP73619c4643c9: Share the Paste line highlighting behavior for Harbormaster build logs
Summary

Depends on D19164. Ref T13088. Now that the JS behaviors are generic, use them on the Harbormaster standalone page.

Test Plan

Clicked lines and dragged across line ranges. Reloaded pages. Saw expected highlighting behavior in the client and on the server across reloads.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
resources/
celerity/
4 lines
src/
applications/
harbormaster/
controller/
14 lines
3 lines
view/
10 lines
webroot/
rsrc/
css/
application/
harbormaster/
6 lines

Diff 45911

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/harbormaster/controller/HarbormasterBuildLogRenderController.php

Loading...
View Options

src/applications/harbormaster/controller/HarbormasterBuildLogViewController.php

Loading...
View Options

src/applications/harbormaster/view/HarbormasterBuildLogView.php

Loading...
View Options

webroot/rsrc/css/application/harbormaster/harbormaster.css

Loading...
Phabricator · Built by Phacility