Page MenuHomePhabricator

Prevent copying Harbormaster build log line numbers with CSS psuedocontent instead of ZWS
ClosedPublic

Authored by epriestley on Mar 1 2018, 4:17 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Feb 26, 11:08 PM
Unknown Object (File)
Wed, Feb 26, 9:11 AM
Unknown Object (File)
Sun, Feb 16, 11:06 PM
Unknown Object (File)
Tue, Feb 11, 4:52 AM
Unknown Object (File)
Sun, Feb 9, 5:35 AM
Unknown Object (File)
Sun, Feb 9, 5:35 AM
Unknown Object (File)
Sun, Feb 9, 5:35 AM
Unknown Object (File)
Jan 28 2025, 3:30 AM
Subscribers
Restricted Owners Package

Details

Summary

Depends on D19165. Ref T13088. Currently, in other applications, we use Zero Width Spaces and Javascript "copy" listeners to prevent line numbers from being copied. This isn't terribly elegant.

Modern browsers support a second approach: using psuedo-elements with content. Try this in Harbormaster since it's conceptually cleaner, at least. One immediate drawback is that Command-F can't find this text either.

Test Plan

In Safari, Chrome and Firefox, highlighted ranges of lines and copy/pasted text. Got just text (no line numbers) in all cases.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable