Paths

Table of Contentst

Differential D19136

In Harbormaster, record byte length on the build logs
ClosedPublic
Actions

Authored by epriestley on Feb 23 2018, 1:52 PM.

Details

Reviewers: None
Maniphest Tasks: T13088: Plans: Harbormaster UI usability and interconnectedness
Commits: rP57e3d607f566: In Harbormaster, record byte length on the build logs

Summary

Depends on D19135. Ref T13088. Denormalize the total log size onto the log itself. This makes reasoning about the log at display time easier, and we don't need to fish around in the database as much to figure out what we're dealing with.

Test Plan

Ran bin/harbormaster rebuild-log, saw an existing log populate. Ran bin/harbormaster write-log, saw new log write with proper length information.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 23 2018, 1:52 PM

Owners added a subscriber: Restricted Owners Package.Feb 23 2018, 1:52 PM

Harbormaster completed remote builds in B19651: Diff 45842.Feb 23 2018, 1:53 PM

epriestley requested review of this revision.Feb 23 2018, 1:53 PM

epriestley added a child revision: D19137: Add "--all" and an explicit "--force" flag to `bin/harbormaster rebuild-log`.Feb 23 2018, 2:03 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 27 2018, 1:54 AM

Closed by commit rP57e3d607f566: In Harbormaster, record byte length on the build logs (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

sql/

autopatches/

20180223.log.01.bytelength.sql

2 lines

src/

applications/

harbormaster/

storage/

build/

HarbormasterBuildLog.php

33 lines

worker/

HarbormasterLogWorker.php

13 lines

Diff 45857

View Options

resources/sql/autopatches/20180223.log.01.bytelength.sql

View Options

src/applications/harbormaster/storage/build/HarbormasterBuildLog.php

View Options

src/applications/harbormaster/worker/HarbormasterLogWorker.php

In Harbormaster, record byte length on the build logsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 45857

resources/sql/autopatches/20180223.log.01.bytelength.sql

src/applications/harbormaster/storage/build/HarbormasterBuildLog.php

src/applications/harbormaster/worker/HarbormasterLogWorker.php

In Harbormaster, record byte length on the build logs
ClosedPublic
Actions

Revision Contents
Changeset List