Page MenuHomePhabricator

Move Harbormaster log compression to the worker task queue
ClosedPublic

Authored by epriestley on Feb 23 2018, 2:20 AM.
Tags
None
Referenced Files
F14756700: D19131.id45837.diff
Tue, Jan 21, 8:20 PM
F14754902: D19131.id45852.diff
Tue, Jan 21, 3:41 PM
F14744935: D19131.diff
Tue, Jan 21, 9:15 AM
Unknown Object (File)
Sat, Jan 18, 5:11 PM
Unknown Object (File)
Fri, Jan 17, 12:24 PM
Unknown Object (File)
Mon, Jan 13, 12:31 PM
Unknown Object (File)
Tue, Jan 7, 10:45 PM
Unknown Object (File)
Mon, Dec 23, 12:19 AM
Subscribers
Restricted Owners Package

Details

Summary

Depends on D19130. Ref T13088. Currently, when a build log is closed we compress it in the same process. Separate this out into a dedicated worker since the plan is to do a lot more work during finalization, none of which needs to happen inline during builds (or, particuarly, inline during a Conduit call for API writes in the future).

Test Plan

Ran bin/harbormaster write-log --trace, saw compression run inline.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.Feb 23 2018, 2:20 AM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 27 2018, 1:52 AM
This revision was automatically updated to reflect the committed changes.