Page MenuHomePhabricator

Move Harbormaster log compression to the worker task queue
ClosedPublic

Authored by epriestley on Feb 23 2018, 2:20 AM.
Tags
None
Referenced Files
F13061438: D19131.diff
Fri, Apr 19, 7:26 PM
Unknown Object (File)
Wed, Apr 17, 2:44 PM
Unknown Object (File)
Mon, Apr 1, 9:33 AM
Unknown Object (File)
Sat, Mar 30, 5:58 AM
Unknown Object (File)
Mar 9 2024, 11:21 PM
Unknown Object (File)
Feb 28 2024, 3:45 PM
Unknown Object (File)
Feb 3 2024, 6:12 PM
Unknown Object (File)
Dec 24 2023, 1:04 AM
Subscribers
Restricted Owners Package

Details

Summary

Depends on D19130. Ref T13088. Currently, when a build log is closed we compress it in the same process. Separate this out into a dedicated worker since the plan is to do a lot more work during finalization, none of which needs to happen inline during builds (or, particuarly, inline during a Conduit call for API writes in the future).

Test Plan

Ran bin/harbormaster write-log --trace, saw compression run inline.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.Feb 23 2018, 2:20 AM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 27 2018, 1:52 AM
This revision was automatically updated to reflect the committed changes.