Page MenuHomePhabricator

Move Harbormaster log compression to the worker task queue
ClosedPublic

Authored by epriestley on Feb 23 2018, 2:20 AM.
Tags
None
Referenced Files
F18738226: D19131.diff
Wed, Oct 1, 2:52 PM
F18566626: D19131.id.diff
Sep 9 2025, 2:47 PM
F18502215: D19131.diff
Sep 4 2025, 10:17 PM
F18379892: D19131.id45852.diff
Aug 28 2025, 4:48 PM
F18376983: D19131.id45837.diff
Aug 28 2025, 12:01 PM
F18375638: D19131.id45852.diff
Aug 28 2025, 10:10 AM
F18374680: D19131.id.diff
Aug 28 2025, 9:07 AM
F18373892: D19131.id45837.diff
Aug 28 2025, 8:07 AM
Subscribers
Restricted Owners Package

Details

Summary

Depends on D19130. Ref T13088. Currently, when a build log is closed we compress it in the same process. Separate this out into a dedicated worker since the plan is to do a lot more work during finalization, none of which needs to happen inline during builds (or, particuarly, inline during a Conduit call for API writes in the future).

Test Plan

Ran bin/harbormaster write-log --trace, saw compression run inline.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.Feb 23 2018, 2:20 AM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 27 2018, 1:52 AM
This revision was automatically updated to reflect the committed changes.