Page MenuHomePhabricator
Differential D19132

Add a "filePHID" to HarbormasterBuildLog and copy logs into Files during finalization
ClosedPublic
Actions

Authored by epriestley on Feb 23 2018, 2:46 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jan 28, 3:25 AM
Unknown Object (File)
Sat, Jan 25, 12:20 AM
Unknown Object (File)
Sat, Jan 25, 12:20 AM
Unknown Object (File)
Sat, Jan 25, 12:20 AM
Unknown Object (File)
Tue, Jan 21, 3:37 PM
Unknown Object (File)
Tue, Jan 21, 3:19 PM
Unknown Object (File)
Tue, Jan 21, 9:16 AM
Unknown Object (File)
Sat, Jan 18, 2:44 AM
View All Files
Subscribers
Restricted Owners Package

Details

Reviewers
None
Maniphest Tasks
T13088: Plans: Harbormaster UI usability and interconnectedness
Commits
rP8a2604cf06a8: Add a "filePHID" to HarbormasterBuildLog and copy logs into Files during…
Summary

Depends on D19131. Ref T13088. During log finalization, stream the log into Files to support "Download Log", archive to Files, and API access.

Test Plan

Ran write-log and rebuild-log, saw Files objects generate with log content and appropriate permissions.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 23 2018, 2:46 AM
Owners added a subscriber: Restricted Owners Package.Feb 23 2018, 2:46 AM
Harbormaster completed remote builds in B19647: Diff 45838.Feb 23 2018, 2:47 AM
epriestley requested review of this revision.Feb 23 2018, 2:47 AM
epriestley added a child revision: D19133: Add a very basic standalone view for build logs with a "Download Log" button.Feb 23 2018, 3:20 AM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 27 2018, 1:52 AM
Closed by commit rP8a2604cf06a8: Add a "filePHID" to HarbormasterBuildLog and copy logs into Files during… (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 45853

View Options

resources/sql/autopatches/20180222.log.01.filephid.sql

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/harbormaster/management/HarbormasterManagementRebuildLogWorkflow.php

Loading...
View Options

src/applications/harbormaster/management/HarbormasterManagementWriteLogWorkflow.php

Loading...
View Options

src/applications/harbormaster/phid/HarbormasterBuildLogPHIDType.php

Loading...
View Options

src/applications/harbormaster/storage/build/HarbormasterBuildLog.php

Loading...
View Options

src/applications/harbormaster/storage/build/HarbormasterBuildLogChunkIterator.php

Loading...
View Options

src/applications/harbormaster/worker/HarbormasterLogWorker.php

Loading...
Phabricator · Built by Phacility