Page MenuHomePhabricator

Sort of make Harbormaster build logs page properly
ClosedPublic

Authored by epriestley on Feb 26 2018, 10:50 PM.
Tags
None
Referenced Files
F17798256: D19141.id45848.diff
Fri, Jul 25, 3:17 AM
F17751701: D19141.id45848.diff
Tue, Jul 22, 5:56 AM
F17717784: D19141.id.diff
Fri, Jul 18, 12:12 AM
F17707413: D19141.diff
Wed, Jul 16, 2:58 PM
Unknown Object (File)
Jun 18 2025, 10:01 AM
Unknown Object (File)
Jun 16 2025, 8:06 PM
Unknown Object (File)
Jun 16 2025, 5:15 PM
Unknown Object (File)
Jun 16 2025, 10:38 AM
Subscribers
Restricted Owners Package

Details

Summary

Depends on D19139. Ref T13088. This doesn't actually work, but is close enough that a skilled attacker might be able to briefly deceive a small child.

Test Plan
  • Viewed some very small logs under very controlled conditions, saw content.
  • Larger logs vaguely do something resembling working correctly.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.Feb 26 2018, 10:50 PM
  • Remove no-longer-used BuildLogRange class, which may return later.
This revision was not accepted when it landed; it landed in state Needs Review.Feb 27 2018, 1:58 AM
This revision was automatically updated to reflect the committed changes.