Page MenuHomePhabricator

Move Paste line range reading code into AphrontRequest
ClosedPublic

Authored by epriestley on Mar 1 2018, 2:11 PM.
Tags
None
Referenced Files
F15567152: D19162.diff
Fri, May 2, 4:29 AM
F15543272: D19162.diff
Fri, Apr 25, 9:48 PM
F15532134: D19162.diff
Wed, Apr 23, 2:32 PM
F15509399: D19162.id.diff
Wed, Apr 16, 12:08 PM
F15506304: D19162.id45902.diff
Tue, Apr 15, 10:05 AM
F15474946: D19162.id45908.diff
Apr 6 2025, 2:23 PM
F15463010: D19162.id45902.diff
Apr 1 2025, 7:44 PM
F15427143: D19162.id45908.diff
Mar 23 2025, 1:06 PM
Subscribers
None

Details

Summary

Ref T13088. This lifts the code for parsing "$x-y" line ranges in URIs into AphrontRequest so Diffusion, Paste, Harbormaster, etc., can share it.

Test Plan

Viewed lines, line ranges, no lines, negative line ranges, line ranges with 0, and extremely long line ranges in Paste.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable