Page MenuHomePhabricator

Allow designation of "summary" build logs which are sorted to the top or otherwise promoted
Open, NormalPublic

Description

At the moment when we're building a diff, there's a multitude of ways that it can fail, in particular:

  • Merge conflicts
  • Build failure
  • Unit test failure

It'd be preferable to expose this reason on the "Harbormaster failed to build <buildable>" transaction so that users know why the build failure occurred (without having to scan through logs).

I think this is dependent on supporting "Failure Steps" in build plans; that is, steps to run when a build fails. Then we have some sort of "Scan Log and Set Reason" build step that searches logs for a particular regex and sets the build failure reason if it matches.

Related Objects

Event Timeline

hach-que created this task.Sep 19 2014, 3:09 AM
hach-que raised the priority of this task from to Needs Triage.
hach-que updated the task description. (Show Details)
hach-que added a project: Harbormaster.
hach-que added subscribers: hach-que, epriestley.
mikn added a subscriber: mikn.Oct 17 2014, 1:37 PM
eadler added a subscriber: eadler.May 3 2015, 5:36 AM

I don't think this is meaningfully distinguishable from logs. There's no reason a target can't fail for multiple reasons, there may be other non-failure data targets wish to log, this data essentially has to be text which we can't understand or do anything special with and I don't think it makes sense for us to do anything about it anyway.

I think this is basically T9124, plus maybe some options for sorting this log to the top or demarcating it in a special way.

epriestley renamed this task from Allow Harbormaster build failures to provide a reason to Allow designation of "summary" build logs which are sorted to the top or otherwise promoted.Aug 10 2015, 1:50 PM
epriestley triaged this task as Normal priority.
epriestley moved this task from v1 to v2 on the Harbormaster board.

Not exactly related, but we also have a fair number of multipart logs:

  • HTTP requests produce a Body, Head and should produce a status code (although maybe I'll just shove that onto the Head log).
  • Execution produces stdout/stderr and return code.

Maybe tackling this through some sort of log grouping is part of a solution here.

eadler added a project: Restricted Project.Aug 5 2016, 4:44 PM
urzds added a subscriber: urzds.Jul 12 2017, 11:13 AM
epriestley moved this task from v2 to Logs / Unit Logs on the Harbormaster board.Feb 21 2018, 2:32 PM