Page MenuHomePhabricator
Create Task
Maniphest T6139

Allow designation of "summary" build logs which are sorted to the top or otherwise promoted
Open, NormalPublic
Actions

Description

At the moment when we're building a diff, there's a multitude of ways that it can fail, in particular:

  • Merge conflicts
  • Build failure
  • Unit test failure

It'd be preferable to expose this reason on the "Harbormaster failed to build <buildable>" transaction so that users know why the build failure occurred (without having to scan through logs).

I think this is dependent on supporting "Failure Steps" in build plans; that is, steps to run when a build fails. Then we have some sort of "Scan Log and Set Reason" build step that searches logs for a particular regex and sets the build failure reason if it matches.

Related Objects
Search...

Event Timeline

hach-que created this task.Sep 19 2014, 3:09 AM
hach-que raised the priority of this task from to Needs Triage.
hach-que updated the task description. (Show Details)
hach-que added a project: Harbormaster.
hach-que added subscribers: hach-que, epriestley.
talshiri added a subscriber: talshiri.Sep 19 2014, 3:35 AM
mikn added a subscriber: mikn.Oct 17 2014, 1:37 PM
• mada added a subscriber: • mada.Oct 17 2014, 1:41 PM
fooishbar added a subscriber: fooishbar.Feb 5 2015, 9:07 PM
nchammas added a subscriber: nchammas.Feb 24 2015, 9:22 PM
devurandom added a subscriber: devurandom.Mar 3 2015, 10:30 AM
eadler added a subscriber: eadler.May 3 2015, 5:36 AM
epriestley moved this task from Backlog to v1 on the Harbormaster board.May 6 2015, 4:08 PM
epriestley added a parent task: T8097: Allow external systems to report results into Harbormaster.
cburroughs added a subscriber: cburroughs.May 6 2015, 7:00 PM
epriestley removed a parent task: T8097: Allow external systems to report results into Harbormaster.Aug 10 2015, 1:47 PM
epriestley added a comment.Aug 10 2015, 1:50 PM

I don't think this is meaningfully distinguishable from logs. There's no reason a target can't fail for multiple reasons, there may be other non-failure data targets wish to log, this data essentially has to be text which we can't understand or do anything special with and I don't think it makes sense for us to do anything about it anyway.

I think this is basically T9124, plus maybe some options for sorting this log to the top or demarcating it in a special way.

epriestley renamed this task from Allow Harbormaster build failures to provide a reason to Allow designation of "summary" build logs which are sorted to the top or otherwise promoted.Aug 10 2015, 1:50 PM
epriestley triaged this task as Normal priority.
epriestley added a subtask: T9124: Support uploading build log data via the Harbormaster API.
epriestley moved this task from v1 to v2 on the Harbormaster board.
epriestley mentioned this in T5920: Support grey-area results ("unstable" builds, "non-critical" builds) in Harbormaster.Aug 10 2015, 2:17 PM
epriestley mentioned this in D13874: Implement methods for logging to Harbormaster via Conduit.Aug 12 2015, 2:33 PM
epriestley mentioned this in T9265: UI/UX: Show Drydock lease logs in Harbormaster.Sep 16 2015, 3:47 PM
epriestley added a comment.Oct 2 2015, 1:42 PM

Not exactly related, but we also have a fair number of multipart logs:

  • HTTP requests produce a Body, Head and should produce a status code (although maybe I'll just shove that onto the Head log).
  • Execution produces stdout/stderr and return code.

Maybe tackling this through some sort of log grouping is part of a solution here.

hach-que mentioned this in T10123: Allow short "result" message for CI builds.Jan 11 2016, 11:53 PM
hach-que mentioned this in T10179: Support specifying a log parser or some such construct for Harbormaster build logs.Jan 19 2016, 11:36 PM
epriestley mentioned this in T10868: Make a line-linkable view for individual build logs.Apr 26 2016, 12:32 PM
eadler added a project: Restricted Project.Aug 5 2016, 4:44 PM
urzds added a subscriber: urzds.Jul 12 2017, 11:13 AM
fooishbar removed a subscriber: fooishbar.Sep 27 2017, 5:59 PM
epriestley moved this task from v2 to Logs / Unit Logs on the Harbormaster board.Feb 21 2018, 2:32 PM
epriestley mentioned this in T13088: Plans: Harbormaster UI usability and interconnectedness.Feb 21 2018, 3:43 PM
epriestley mentioned this in T13108: Plans: 2018 Week 12 Bonus Content.Mar 20 2018, 5:03 PM
epriestley mentioned this in T13257: Plans: Unbeta New Harbormaster Log UI.Feb 26 2019, 12:36 PM
Phabricator · Built by Phacility