Page MenuHomePhabricator

Make dashboard arrange actions (move, add, remove) work again after read locking from "chaos reduction"

Authored by epriestley on Feb 21 2018, 1:20 AM.



See PHI385. Ref T13054. Ref T13083. The dashboard "arrange" operations (add, remove, move) rely on doing $dashboard->setThing(...) and then applying transactions.

This no longer works after the read locking change from T13054. To make this function again, just add an explicit save() after layout adjustment. This should be more nuanced eventually, but all arrange operations are nonfunctional in a corrupting way at HEAD of master/stable, so stop the bleeding first.

Test Plan
  • Created new empty and template dashboards.
  • Moved panels.
  • Added new and existing panels.
  • Removed panels.

Diff Detail

rP Phabricator
Lint Not Applicable
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Feb 21 2018, 1:22 AM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.