Page MenuHomePhabricator
Differential D19134

Implement DestructibleInterface on BuildLog
ClosedPublic
Actions

Authored by epriestley on Feb 23 2018, 1:18 PM.
Tags
None
Referenced Files
F14840545: D19134.id45840.diff
Sat, Feb 1, 7:23 AM
Unknown Object (File)
Tue, Jan 28, 4:55 PM
Unknown Object (File)
Tue, Jan 28, 3:26 AM
Unknown Object (File)
Sat, Jan 25, 12:21 AM
Unknown Object (File)
Sat, Jan 25, 12:21 AM
Unknown Object (File)
Sat, Jan 25, 12:21 AM
Unknown Object (File)
Tue, Jan 21, 4:07 PM
Unknown Object (File)
Tue, Jan 21, 3:57 PM
View All Files
Subscribers
Restricted Owners Package

Details

Reviewers
None
Maniphest Tasks
T13088: Plans: Harbormaster UI usability and interconnectedness
Commits
rPe920e2b143a2: Implement DestructibleInterface on BuildLog
Summary

Depends on D19133. Ref T13088. Allows build logs to be formally destroyed, cleaning up their chunks and file data.

Test Plan
  • Used bin/remove destroy to destroy a log, verified chunks and files were removed.
  • Used bin/harbormaster rebuild-log to force a log to rebuild, verified files were destroyed and regenerated.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 23 2018, 1:18 PM
Owners added a subscriber: Restricted Owners Package.Feb 23 2018, 1:18 PM
Harbormaster completed remote builds in B19649: Diff 45840.Feb 23 2018, 1:19 PM
epriestley requested review of this revision.Feb 23 2018, 1:19 PM
epriestley added a child revision: D19135: Manage log locks on the Log object to prepare for multiple writers.Feb 23 2018, 1:39 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 27 2018, 1:53 AM
Closed by commit rPe920e2b143a2: Implement DestructibleInterface on BuildLog (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
1 line
applications/
harbormaster/
storage/
build/
54 lines
worker/
15 lines

Diff 45855

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/harbormaster/storage/build/HarbormasterBuildLog.php

Loading...
View Options

src/applications/harbormaster/worker/HarbormasterLogWorker.php

Loading...
Phabricator · Built by Phacility