Page MenuHomePhabricator

Support rendering arbitrary sections in the middle of a Harbormaster build log so links to line 3500 work
ClosedPublic

Authored by epriestley on Mar 1 2018, 3:12 PM.
Tags
None
Referenced Files
F19055986: D19163.id.diff
Fri, Nov 28, 6:49 PM
F19045382: D19163.diff
Thu, Nov 27, 7:19 AM
F19016681: D19163.diff
Sun, Nov 23, 5:04 AM
F18852804: D19163.id.diff
Oct 31 2025, 12:06 PM
F18817625: D19163.id45909.diff
Oct 21 2025, 5:05 PM
F18809991: D19163.id.diff
Oct 19 2025, 6:38 PM
F18804294: D19163.diff
Oct 18 2025, 7:14 AM
F18652820: D19163.diff
Sep 21 2025, 9:44 AM
Subscribers
Restricted Owners Package

Details

Summary

Depends on D19162. Ref T13088. When a user links to $1234, we need to render a default view of the log with a piece at the head, a piece at the end, and a piece in the middle.

We also need to figure out the offset for line 1234, or multiple offsets for "1234-2345".

Since the logic views/reads mostly anticipated this it isn't too much of a mess, although there are a couple of bugs this exposes with view specifications that use combinations of parameters which were previously impossible.

Test Plan

Viewed a large log with no line marker. Viewed $1. Viewed $end. Viewed $35-40, etc. Expanded context around logs.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable