Page MenuHomePhabricator

Support rendering arbitrary sections in the middle of a Harbormaster build log so links to line 3500 work
ClosedPublic

Authored by epriestley on Mar 1 2018, 3:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 20, 11:32 AM
Unknown Object (File)
Sat, Nov 16, 2:39 PM
Unknown Object (File)
Tue, Nov 12, 7:57 AM
Unknown Object (File)
Thu, Nov 7, 6:42 PM
Unknown Object (File)
Sat, Oct 26, 6:23 AM
Unknown Object (File)
Oct 17 2024, 5:00 AM
Unknown Object (File)
Oct 9 2024, 9:04 AM
Unknown Object (File)
Oct 9 2024, 9:04 AM
Subscribers
Restricted Owners Package

Details

Summary

Depends on D19162. Ref T13088. When a user links to $1234, we need to render a default view of the log with a piece at the head, a piece at the end, and a piece in the middle.

We also need to figure out the offset for line 1234, or multiple offsets for "1234-2345".

Since the logic views/reads mostly anticipated this it isn't too much of a mess, although there are a couple of bugs this exposes with view specifications that use combinations of parameters which were previously impossible.

Test Plan

Viewed a large log with no line marker. Viewed $1. Viewed $end. Viewed $35-40, etc. Expanded context around logs.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable