Page MenuHomePhabricator

Fix some of the most egregious errors in Harbormaster log paging
ClosedPublic

Authored by epriestley on Feb 27 2018, 1:49 AM.
Tags
None
Referenced Files
F18794620: D19142.id45850.diff
Fri, Oct 17, 12:07 AM
F18794619: D19142.id45862.diff
Fri, Oct 17, 12:07 AM
F18794403: D19142.diff
Thu, Oct 16, 11:35 PM
F18634017: D19142.diff
Sep 16 2025, 9:24 PM
F18619222: D19142.diff
Sep 15 2025, 2:00 AM
F18566661: D19142.id.diff
Sep 9 2025, 2:48 PM
F18502234: D19142.diff
Sep 4 2025, 10:18 PM
F18206617: D19142.id45862.diff
Aug 18 2025, 4:02 PM
Subscribers
Restricted Owners Package

Details

Summary

Depends on D19141. Ref T13088. Some of the fundamental log behaviors like "loading the correct rows" are now a bit better behaved.

The UI is a little less garbage, too.

Test Plan

Viewed some logs and loaded more context by clicking the buttons.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.Feb 27 2018, 1:49 AM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 27 2018, 1:59 AM
This revision was automatically updated to reflect the committed changes.