Page MenuHomePhabricator
Feed Advanced Search

Jul 8 2017

csilvers added a comment to T10183: Allow Herald to add a comment to a Maniphest task.

Can you change the syntax to something like @unittest.skip("Reasoning behind this decision...")?

Jul 8 2017, 3:06 AM · Herald, Feature Request
epriestley added a comment to T10183: Allow Herald to add a comment to a Maniphest task.

That is, I think the right tool for the job is either runtime enforcement or lint enforcement: make unittest.skip() with no reason fail (so the tests don't pass) or make lint raise a warning like "unittest.skip() must have a comment above it explaining the plan for re-enabling the test.".

Jul 8 2017, 12:55 AM · Herald, Feature Request
epriestley added a comment to T10183: Allow Herald to add a comment to a Maniphest task.

Can you change the syntax to something like @unittest.skip("Reasoning behind this decision...")?

Jul 8 2017, 12:46 AM · Herald, Feature Request
csilvers added a comment to T10183: Allow Herald to add a comment to a Maniphest task.

I know about T9853, but if there's still a chance you might consider merging that upstream, there are a few folks here at Khan Academy who are excited by the feature. Here's one example:

Jul 8 2017, 12:40 AM · Herald, Feature Request

Jul 7 2017

epriestley merged task T12903: Can not visually differentiate between "stalled" and "open" tasks on a workboard into T10333: Add groups to workboard columns.
Jul 7 2017, 11:26 PM · Workboards, Feature Request
epriestley added a comment to T12903: Can not visually differentiate between "stalled" and "open" tasks on a workboard.

This is either T10333 or T4863. I'd guess the former will happen first. Filter is probably the best workaround until then. See also T12374 maybe, although I think that task involved a lot of meandering.

Jul 7 2017, 11:26 PM · Workboards, Feature Request
greggrossmeier created T12903: Can not visually differentiate between "stalled" and "open" tasks on a workboard.
Jul 7 2017, 11:20 PM · Workboards, Feature Request

Jul 6 2017

jmeador added a comment to T12896: It isn’t obvious when repository observation breaks.

This information may be entirely useless, but it is somewhat related. We have a large number of repositories, with multiple clusters so this affects us in a major way.

Jul 6 2017, 11:35 PM · Diffusion, Feature Request
epriestley added a comment to T12901: Support access policies for saved queries.

Have you actually tested this scenario yourself?

Jul 6 2017, 4:24 PM · Feature Request
eliaspro added a comment to T12901: Support access policies for saved queries.

Edit the Saved Query to contain something sensitive

This isn't possible.

Jul 6 2017, 4:15 PM · Feature Request
epriestley closed T12901: Support access policies for saved queries as Wontfix.

Edit the Saved Query to contain something sensitive

Jul 6 2017, 3:59 PM · Feature Request
eliaspro added a comment to T12901: Support access policies for saved queries.

A user might have a saved query which contains sensitive information no one else should know about.

How would other users discover the query's ID?

Jul 6 2017, 3:25 PM · Feature Request
epriestley added a comment to T12896: It isn’t obvious when repository observation breaks.

From elsewhere:

Jul 6 2017, 3:19 PM · Diffusion, Feature Request
epriestley added a comment to T12901: Support access policies for saved queries.

A user might have a saved query which contains sensitive information no one else should know about.

Jul 6 2017, 3:17 PM · Feature Request
eliaspro created T12901: Support access policies for saved queries.
Jul 6 2017, 3:15 PM · Feature Request
eliaspro added a comment to T12896: It isn’t obvious when repository observation breaks.

Also related: T12417: Show failing status of Diffusion repositories in top main menu bar.

Jul 6 2017, 1:23 PM · Diffusion, Feature Request

Jul 5 2017

alexmv added a comment to T12792: Consider an option to disable all popup notifications.

We've also had a request for this (disabling the in-application popups) at #dropbox, as a per-user preference.

Jul 5 2017, 11:46 PM · Feature Request, Customer Impact, Notifications
mruuska added a comment to T11535: Make it possible for arc land to disable upstream branch tracking.

Severely needed. .arcconfig should be able to control where things land without arguments. I also question the choice made in D10058 where branch tracking seems to be used as a indicator of a branch created with arc-feature. Since arc-feature is in no way central to arc use, I think it should not be assumed that it will be used. And regular workflows and GUI tools will use git-branch instead, with tracking.

Jul 5 2017, 1:10 PM · Arcanist, Restricted Project

Jul 4 2017

mavit created T12896: It isn’t obvious when repository observation breaks.
Jul 4 2017, 4:19 PM · Diffusion, Feature Request

Jul 2 2017

quark.zju added a comment to T12618: Parse multiple commits and commit metadata from "hg log --patch" and "hg export".

Parsing hg export metadata is an elegant solution. # HG changeset patch could imply sourceControlSystem = 'hg'. Thanks for merging the task!

Jul 2 2017, 7:30 PM · Arcanist, Mercurial, Differential, Conduit, Feature Request
epriestley merged task T12890: Add sourceControlSystem parameter to differential.createrawdiff into T12618: Parse multiple commits and commit metadata from "hg log --patch" and "hg export".
Jul 2 2017, 7:22 PM · Feature Request
epriestley merged T12890: Add sourceControlSystem parameter to differential.createrawdiff into T12618: Parse multiple commits and commit metadata from "hg log --patch" and "hg export".
Jul 2 2017, 7:22 PM · Arcanist, Mercurial, Differential, Conduit, Feature Request
quark.zju added a comment to T12890: Add sourceControlSystem parameter to differential.createrawdiff.

The background is the Mercurial community wants to try Phabricator as an experimental review system. It's using emails now. I'd like to make Phabricator workflow as convenient as traditional email workflow.

Jul 2 2017, 7:16 PM · Feature Request
epriestley added a comment to T12890: Add sourceControlSystem parameter to differential.createrawdiff.

I'm writing a Mercurial extension to send changesets to Differential like hg email provided by patchbomb extension.

Jul 2 2017, 6:51 PM · Feature Request
quark.zju created T12890: Add sourceControlSystem parameter to differential.createrawdiff.
Jul 2 2017, 6:47 PM · Feature Request

Jun 30 2017

jcox added a comment to T12880: Expose the ability to add some JS to every page.

Haha to be clear we're using an open-source self-hosted tracking solution, I was just throwing GA out there as an example. But I do understand your point vis-a-vis data security.

Jun 30 2017, 5:37 PM · Feature Request
epriestley added a comment to T12880: Expose the ability to add some JS to every page.

I guess everyone uses GMail nowadays anyway (as mandated by international galactic law) so my paranoia is probably mostly moot because they can undetectably read all email communication anyway.

Jun 30 2017, 5:14 PM · Feature Request
epriestley closed T12880: Expose the ability to add some JS to every page as Wontfix.

I think you probably won't be able to answer most of those questions with Google Analytics. For example, bots will never hit client-side analytics, so any question about bots probably can't be served by GA. Likewise, GA can't see Conduit/API activity.

Jun 30 2017, 2:45 PM · Feature Request
jcox added a comment to T12880: Expose the ability to add some JS to every page.

Why do you want to track users with Google Analytics or a similar library?

Jun 30 2017, 2:17 PM · Feature Request
epriestley added a comment to T12885: Warning For Past Events.

I think it's probably reasonable for us to warn about RSVP'ing to an event which has already ended. I'd guess this is usually a mistake, and in cases where it isn't some kind of weird off-label workflow is taking place and the warning is probably fine.

Jun 30 2017, 2:09 PM · Calendar, Feature Request

Jun 29 2017

CodeMouse92 created T12885: Warning For Past Events.
Jun 29 2017, 11:11 PM · Calendar, Feature Request
epriestley added a comment to T12880: Expose the ability to add some JS to every page.

Why do you want to track users with Google Analytics or a similar library?

Jun 29 2017, 4:07 PM · Feature Request
chad closed T12882: testing form configurations as Invalid.
Jun 29 2017, 7:18 AM · Feature Request
exp10r3r created T12882: testing form configurations.
Jun 29 2017, 7:13 AM · Feature Request
avivey added a comment to T12876: Improve initial arc land experience when destination repo is empty.

in T6722#197239 I had the same problem with "land revision from Web UI" :)

Jun 29 2017, 4:26 AM · Arcanist

Jun 28 2017

jcox added a comment to T12880: Expose the ability to add some JS to every page.

image.png (553×414 px, 298 KB)

Jun 28 2017, 7:55 PM · Feature Request
chad added a comment to T12880: Expose the ability to add some JS to every page.

tumblr_inline_op017kGTqT1teupc5_540.gif (345×498 px, 2 MB)

Jun 28 2017, 7:50 PM · Feature Request
jcox created T12880: Expose the ability to add some JS to every page.
Jun 28 2017, 7:42 PM · Feature Request
StingRayZA added a comment to T12873: Ability to display custom message during externally linked login prompt.

Thanks for this - suggested solution works perfectly!

Jun 28 2017, 10:20 AM · Feature Request

Jun 27 2017

amckinley created T12876: Improve initial arc land experience when destination repo is empty.
Jun 27 2017, 7:48 PM · Arcanist
epriestley closed T12875: How to see all user keys uploaded as Invalid.

See T12874. Your account will be disabled if you continue creating tasks like this. Follow the instructions you were given.

Jun 27 2017, 4:14 PM · Feature Request
marcoscorvalan created T12875: How to see all user keys uploaded .
Jun 27 2017, 3:34 PM · Feature Request
chad added a comment to T12874: HOw to see ALL user Keys uploaded.

See Support Resources

Jun 27 2017, 3:23 PM · Feature Request
chad closed T12874: HOw to see ALL user Keys uploaded as Invalid.
Jun 27 2017, 3:22 PM · Feature Request
marcoscorvalan created T12874: HOw to see ALL user Keys uploaded.
Jun 27 2017, 3:18 PM · Feature Request
chad added a comment to T12873: Ability to display custom message during externally linked login prompt.

/config/edit/translation.override/ then add the string, and what you want it to say instead. That's the quickest path here. Merging into the other request.

Jun 27 2017, 10:53 AM · Feature Request
chad merged T12873: Ability to display custom message during externally linked login prompt into T11514: Authentication should have a way to customize the credentials name.
Jun 27 2017, 10:50 AM · Auth, LDAP, Feature Request
chad merged task T12873: Ability to display custom message during externally linked login prompt into T11514: Authentication should have a way to customize the credentials name.
Jun 27 2017, 10:50 AM · Feature Request
chad added a comment to T12873: Ability to display custom message during externally linked login prompt.

Can you be more specific here? If you just want to rename "LDAP Login" you can already do that with the translation framework.

Jun 27 2017, 10:39 AM · Feature Request
StingRayZA created T12873: Ability to display custom message during externally linked login prompt.
Jun 27 2017, 9:18 AM · Feature Request

Jun 23 2017

epriestley added a comment to T12842: Some improvements to Mercurial, Arcanist, and Dependent Revisions.

For (1), it's currently expected, yes. We don't create branches for dependencies in Git either, currently. I don't think this is terribly unreasonable, but I'm also not sure it's terribly useful (does it just help you keep track of which commits are part of the leaf?) and it makes cleanup more difficult by creating more total branch/bookmark artifacts in the local working copy.

Jun 23 2017, 11:39 PM · Arcanist, Mercurial, Feature Request
cspeckmim added a comment to T12842: Some improvements to Mercurial, Arcanist, and Dependent Revisions.

For (1), it is expected to not apply bookmarks to dependency changesets that are applied as part of the patch issued? When patched one-by-one they would each obtain their bookmark.

Jun 23 2017, 11:29 PM · Arcanist, Mercurial, Feature Request
mcorteel added a comment to T12865: Strikethrough for icons in checked remarkup list items.

Sorry, I should have led with a screenshot! I'm the biggest nitpicker, I know.

Jun 23 2017, 5:48 PM · Remarkup, Feature Request
epriestley added a comment to T12842: Some improvements to Mercurial, Arcanist, and Dependent Revisions.

Some of the (3), (2), (1) stuff is that we're trying to pick a single behavior which addresses most use cases reasonably well. For example, if we use "natural" bookmark names that will tend to make things much worse for users in bucket (3).

Jun 23 2017, 4:48 PM · Arcanist, Mercurial, Feature Request
epriestley added a comment to T12865: Strikethrough for icons in checked remarkup list items.

Thanks, that's much more clear than the original description!

Jun 23 2017, 4:42 PM · Remarkup, Feature Request
mcorteel added a comment to T12865: Strikethrough for icons in checked remarkup list items.

No they're not. I know it's a tiny difference, but look at this closely (left is my proposal, right is the current state):

Spectacle.eD1745.png (147×463 px, 9 KB)

Jun 23 2017, 4:41 PM · Remarkup, Feature Request
epriestley triaged T12866: Batch repository editing or repository groups for shared access control settings as Low priority.
Jun 23 2017, 4:18 PM · Diffusion, Feature Request
epriestley added a comment to T12865: Strikethrough for icons in checked remarkup list items.

I'm confused here -- the icons are already struck in every browser on my system (Safari, Firefox, Chrome):

Jun 23 2017, 4:18 PM · Remarkup, Feature Request
epriestley added a comment to T12866: Batch repository editing or repository groups for shared access control settings.

See also T10005 (bulk editors for all applications) and T6722.

Jun 23 2017, 1:38 PM · Diffusion, Feature Request
chad merged task T12868: Highlight and link URI's in review titles into T3278: ⛄ Build a summary mode Remarkup engine for constrained text areas.
Jun 23 2017, 6:29 AM · Diffusion, Differential, Feature Request
jcarrillo7 created T12868: Highlight and link URI's in review titles.
Jun 23 2017, 6:25 AM · Diffusion, Differential, Feature Request

Jun 22 2017

avivey added a parent task for T12866: Batch repository editing or repository groups for shared access control settings: T9287: Working with many repositories.
Jun 22 2017, 7:26 PM · Diffusion, Feature Request
chad updated the task description for T12865: Strikethrough for icons in checked remarkup list items.
Jun 22 2017, 7:25 PM · Remarkup, Feature Request
jcarrillo7 updated the task description for T12866: Batch repository editing or repository groups for shared access control settings.
Jun 22 2017, 7:20 PM · Diffusion, Feature Request
jcarrillo7 added a project to T12866: Batch repository editing or repository groups for shared access control settings: Diffusion.
Jun 22 2017, 7:19 PM · Diffusion, Feature Request
jcarrillo7 created T12866: Batch repository editing or repository groups for shared access control settings.
Jun 22 2017, 7:19 PM · Diffusion, Feature Request
1 added a comment to T12865: Strikethrough for icons in checked remarkup list items.
Jun 22 2017, 6:11 PM · Remarkup, Feature Request
mcorteel created T12865: Strikethrough for icons in checked remarkup list items.
Jun 22 2017, 8:24 AM · Remarkup, Feature Request

Jun 21 2017

chad added a comment to T12861: How to intergrate Infer's analysis result into Phabricator?.

Just to clarify, Phacility is the paid hosted version of Phabricator. If you installed Phabricator locally, we cannot help you with this request via Phacility. You'll need to follow Support Resources for your self-hosted installation.

Jun 21 2017, 6:35 PM · Phacility, Feature Request
epriestley added a comment to T12861: How to intergrate Infer's analysis result into Phabricator?.

Great! Please mail support at support@phacility.com and identify which instance you're paying us for, then we're happy to help you. We won't help you here, since this isn't the right way for customers to get support.

Jun 21 2017, 6:27 PM · Phacility, Feature Request
sencho added a comment to T12861: How to intergrate Infer's analysis result into Phabricator?.

Yes,we are Phacility customer And I deployed it on a Ubuntu server,Thank you.

Jun 21 2017, 5:42 PM · Phacility, Feature Request
epriestley merged T12862: Diffusion: change to a flat project structure view into T10767: fold empty directories in Browse view.
Jun 21 2017, 5:23 PM · Restricted Project, Diffusion, Feature Request
epriestley merged task T12862: Diffusion: change to a flat project structure view into T10767: fold empty directories in Browse view.
Jun 21 2017, 5:23 PM · Diffusion, Feature Request
epriestley closed T12861: How to intergrate Infer's analysis result into Phabricator? as Invalid.

If you're a Phacility customer, please mail support at support@phacility.com (and identify your instance).

Jun 21 2017, 5:22 PM · Phacility, Feature Request
bhchandra added a project to T12862: Diffusion: change to a flat project structure view: Diffusion.
Jun 21 2017, 5:18 PM · Diffusion, Feature Request
sencho added a project to T12861: How to intergrate Infer's analysis result into Phabricator?: Phacility.
Jun 21 2017, 5:17 PM · Phacility, Feature Request
bhchandra created T12862: Diffusion: change to a flat project structure view.
Jun 21 2017, 5:17 PM · Diffusion, Feature Request
sencho created T12861: How to intergrate Infer's analysis result into Phabricator?.
Jun 21 2017, 5:15 PM · Phacility, Feature Request

Jun 19 2017

vanto- added a comment to T12852: just test.

haha

Jun 19 2017, 7:38 AM
vanto- created T12852: just test.
Jun 19 2017, 7:37 AM

Jun 18 2017

kszatan added a comment to T12813: Integrate Harbormaster with GoCD.

I was going to wait with updating this task until I'm finished but I'm stuck on GoCD side for some time. The extension for Phabricator is 99% ready so anyone interested may give it a try:
https://github.com/kszatan/harbormaster-gocd-buildstep
It's enough to be able to schedule a pipeline in GoCD but nothing more. This issue hampers my progress with notifying Harbormaster about pipeline status. I'll update this task when all is working as planned.

Jun 18 2017, 9:00 PM · Harbormaster, Feature Request
waxmigs2902 added a comment to T10605: Implement setOriginalText() and setReplacementText() in RuboCop driver.

done! cheers

Jun 18 2017, 11:38 AM · Lint, Feature Request

Jun 16 2017

charlax added a comment to T12843: Add support for creating workboard columns from the Conduit API.

Milestones works great for this, but you still have to manually create the workboard (just going into workboard and clicking create - milestones show up).

Jun 16 2017, 1:59 PM · Conduit, Projects, Workboards, Feature Request

Jun 14 2017

jboning updated subscribers of T11664: Add option to allow owner packages to be added as reviewers to diffs, when the diff author is in the owner package.

I'm not totally sure about how/why users are expecting the behavior in the third case.

Jun 14 2017, 10:13 PM · Restricted Project, Feature Request
epriestley added a comment to T11664: Add option to allow owner packages to be added as reviewers to diffs, when the diff author is in the owner package.

I'm not particularly strongly opposed to adding more options here, I just want to avoid the dropdown becoming this:

Jun 14 2017, 10:08 PM · Restricted Project, Feature Request
epriestley added a comment to T11664: Add option to allow owner packages to be added as reviewers to diffs, when the diff author is in the owner package.

For the compliance case, you should already be able to trigger this stronger rule ("always add the package as a reviewer, even if an owner authored it") with Herald, by writing this rule:

Jun 14 2017, 9:58 PM · Restricted Project, Feature Request
neilfitz added a comment to T11664: Add option to allow owner packages to be added as reviewers to diffs, when the diff author is in the owner package.

As more of a point of philosophy of code review also, I (and, I think, my teammates) would say that diffs should be reviewed by someone who both:

  1. Understands the relevant code
  2. Did not write the code themselves

In other words, the combination of expertise + different perspective is of value beyond each component individually. If you believe that, then B or C should review A's diff in this case.

Jun 14 2017, 9:56 PM · Restricted Project, Feature Request
jboning added a comment to T11664: Add option to allow owner packages to be added as reviewers to diffs, when the diff author is in the owner package.

When you put it that way, it does seem backwards.

Jun 14 2017, 9:31 PM · Restricted Project, Feature Request
epriestley added a comment to T11664: Add option to allow owner packages to be added as reviewers to diffs, when the diff author is in the owner package.

The use case in this task's description does not make sense to me.

Jun 14 2017, 7:28 PM · Restricted Project, Feature Request
jboning added a project to T11664: Add option to allow owner packages to be added as reviewers to diffs, when the diff author is in the owner package: Restricted Project.

We're interested in this option, since we find that users are often surprised by the existing behaviour. I think this would make sense as a per-package setting, rather than a global one.

Jun 14 2017, 5:57 PM · Restricted Project, Feature Request
20after4 added a comment to T12314: Support formal task subtypes (like "bug" vs "feature").

It would be really nice to default newly added fields to hidden. Going through 20+ forms to hide the fields is tedious.

Jun 14 2017, 3:06 PM · EditEngine, Maniphest, Custom Fields, Feature Request
epriestley added a comment to T12843: Add support for creating workboard columns from the Conduit API.

We do something similar ourselves for technical interviews, but I just related all the tasks by embedding them in the description of a central task:

Jun 14 2017, 12:15 PM · Conduit, Projects, Workboards, Feature Request
epriestley added a project to T12843: Add support for creating workboard columns from the Conduit API: Conduit.
Jun 14 2017, 12:08 PM · Conduit, Projects, Workboards, Feature Request
epriestley added projects to T12843: Add support for creating workboard columns from the Conduit API: Workboards, Projects.

I think this use case is a reasonable one.

Jun 14 2017, 12:08 PM · Conduit, Projects, Workboards, Feature Request
charlax added a comment to T12843: Add support for creating workboard columns from the Conduit API.

Just discovered I could use the Milestones feature to do that. Will try this out.

Jun 14 2017, 9:51 AM · Conduit, Projects, Workboards, Feature Request
charlax created T12843: Add support for creating workboard columns from the Conduit API.
Jun 14 2017, 9:45 AM · Conduit, Projects, Workboards, Feature Request
cspeckmim created T12842: Some improvements to Mercurial, Arcanist, and Dependent Revisions.
Jun 14 2017, 3:08 AM · Arcanist, Mercurial, Feature Request

Jun 13 2017

epriestley closed T12834: Set new hourly rate for our new colleague as Invalid.
Jun 13 2017, 9:47 AM · Feature Request
banica moved T12834: Set new hourly rate for our new colleague from Needs Information to Backlog on the Feature Request board.
Jun 13 2017, 8:59 AM · Feature Request
banica moved T12834: Set new hourly rate for our new colleague from Backlog to Future on the Feature Request board.
Jun 13 2017, 8:58 AM · Feature Request