Page MenuHomePhabricator
Feed Advanced Search

Apr 25 2017

epriestley merged task T12638: Arcanist (svn): add ability to output diff against last differential update into T1084: Preview what's new in a diff when attaching it to an existing revision .
Apr 25 2017, 12:34 AM · Arcanist, Subversion, Feature Request

Apr 24 2017

epriestley added a comment to T12613: In diffusion hosting subversion repository, several commands do not return (freeze)..
  • I deployed D17774 to secure.
  • I verified that rSVNTEST now correctly raised an error because it was backed by a service with muliple hosts.
  • I moved rSVNTEST and rHGTEST to a one-host service, securex-legacy.phacility.net.
  • I can no longer reproduce any issues against this host.
Apr 24 2017, 5:54 PM · Diffusion, Bug Report
epriestley added a comment to T12528: Can't send confirmation email if two mails are available.

T12635 had another similar report, and I believe I tracked down and fixed the root cause there.

Apr 24 2017, 5:27 PM · Mail, Bug Report
epriestley added a comment to T12635: Can't verify primary emails for existing users.

And thanks for the report! Let us know if you run into anything else..

Apr 24 2017, 5:27 PM · Bug Report
epriestley added a comment to T12635: Can't verify primary emails for existing users.

This should now be resolved at HEAD:

Apr 24 2017, 5:27 PM · Bug Report
epriestley closed T12635: Can't verify primary emails for existing users as Resolved by committing Restricted Diffusion Commit.
Apr 24 2017, 5:24 PM · Bug Report
epriestley closed T10954: Differential keyboard shortcut inline selection reticle is visually unclear (bad z-index?) as Resolved by committing Restricted Diffusion Commit.
Apr 24 2017, 5:24 PM · Inline Comments, Differential, Feature Request
epriestley created T12637: ToC button icon in Diviner and Phriction isn't centered?.
Apr 24 2017, 4:29 PM · Phriction, Diviner, Design
epriestley added a revision to T12635: Can't verify primary emails for existing users: Unknown Object (Differential Revision).
Apr 24 2017, 4:25 PM · Bug Report
epriestley added a revision to T12635: Can't verify primary emails for existing users: Unknown Object (Differential Revision).
Apr 24 2017, 4:12 PM · Bug Report
epriestley created T12636: Legalpad error view is missing some margins/padding.
Apr 24 2017, 4:07 PM · Legal, Design
epriestley added a comment to T12635: Can't verify primary emails for existing users.

Actually I think there's a real path to this which remains available:

Apr 24 2017, 4:05 PM · Bug Report
epriestley added a comment to T12635: Can't verify primary emails for existing users.

Here's a script which will identify affected users. Output is:

Apr 24 2017, 3:57 PM · Bug Report
epriestley added a comment to T12635: Can't verify primary emails for existing users.

I think some very old users got into a bugged state where their primary email is verified but the "is verified" flag was never set on their account. We saw one of these users on admin.phacility.com earlier, but I wasn't able to identify a way that a modern account could get into this state.

Apr 24 2017, 3:45 PM · Bug Report
epriestley moved T11662: Draft comments which reply to ghost inlines from lines which no longer exist can not be edited or deleted until the page is reloaded from Glitches to Editor on the Inline Comments board.
Apr 24 2017, 10:33 AM · Inline Comments, Customer Impact, Differential
epriestley moved T8288: Hovering over "Edit" dialog for inline comments which are replies to right-hand-side inline comments shows reticle on wrong side of diff from Glitches to Editor on the Inline Comments board.
Apr 24 2017, 10:33 AM · Inline Comments, Differential
epriestley moved T8323: Saving draft inlines on left hand side of files not present in newer diff in diff-of-diffs fails from Glitches to Editor on the Inline Comments board.
Apr 24 2017, 10:33 AM · Inline Comments, Differential
epriestley moved T11093: DifferentialInlineCommentEditor retains state across Quicksand requests from Glitches to Editor on the Inline Comments board.
Apr 24 2017, 10:33 AM · Inline Comments, Restricted Project, Quicksand, Differential
epriestley moved T10668: When replying to a ghost inline comment, it is possible for the reticle to cover the reply UI from Glitches to Editor on the Inline Comments board.
Apr 24 2017, 10:33 AM · Inline Comments, Restricted Project, Differential
epriestley moved T9269: Undoing multiple inline comments on the same line will restore the comment out of position. from Glitches to Editor on the Inline Comments board.
Apr 24 2017, 10:32 AM · Inline Comments, Differential
epriestley moved T10563: Inline comments displayed on the same line are shown in creation order without regard for threading from Glitches to Editor on the Inline Comments board.
Apr 24 2017, 10:32 AM · Inline Comments, Differential, Restricted Project
epriestley added a comment to T8288: Hovering over "Edit" dialog for inline comments which are replies to right-hand-side inline comments shows reticle on wrong side of diff.

This reproduces for me at HEAD:

Apr 24 2017, 10:32 AM · Inline Comments, Differential
epriestley moved T8047: Differential inline reticle can persist across Quicksand navigations from Backlog to Glitches on the Inline Comments board.
Apr 24 2017, 10:30 AM · Inline Comments, Quicksand
epriestley added a comment to T8047: Differential inline reticle can persist across Quicksand navigations.

The keyboard reticle probably has the same issue but we can figure that out later.

Apr 24 2017, 10:30 AM · Inline Comments, Quicksand
epriestley removed a parent task for T8047: Differential inline reticle can persist across Quicksand navigations: T12634: Keyboard focus reticle is generally oblivious to the world around it.
Apr 24 2017, 10:30 AM · Inline Comments, Quicksand
epriestley removed a subtask for T12634: Keyboard focus reticle is generally oblivious to the world around it: T8047: Differential inline reticle can persist across Quicksand navigations.
Apr 24 2017, 10:30 AM · Differential, Inline Comments
epriestley added a comment to T8047: Differential inline reticle can persist across Quicksand navigations.

Oh, this actually is the inline reticle, not the keyboard reticle.

Apr 24 2017, 10:29 AM · Inline Comments, Quicksand
epriestley added a parent task for T8047: Differential inline reticle can persist across Quicksand navigations: T12634: Keyboard focus reticle is generally oblivious to the world around it.
Apr 24 2017, 10:29 AM · Inline Comments, Quicksand
epriestley added a subtask for T12634: Keyboard focus reticle is generally oblivious to the world around it: T8047: Differential inline reticle can persist across Quicksand navigations.
Apr 24 2017, 10:29 AM · Differential, Inline Comments
epriestley added a project to T8047: Differential inline reticle can persist across Quicksand navigations: Inline Comments.
Apr 24 2017, 10:29 AM · Inline Comments, Quicksand
epriestley added a parent task for T9270: Toggling File Browser on Differential while creating inline comment causes inline/edit focus reticle to offset: T12634: Keyboard focus reticle is generally oblivious to the world around it.
Apr 24 2017, 10:27 AM · Inline Comments, Differential
epriestley added a parent task for T12633: Interacting with the InlineEditor does not resize or reposition the keyboard focus reticle: T12634: Keyboard focus reticle is generally oblivious to the world around it.
Apr 24 2017, 10:27 AM · Inline Comments
epriestley added a parent task for T12632: Resizing a diff does not resize the keyboard focus reticle: T12634: Keyboard focus reticle is generally oblivious to the world around it.
Apr 24 2017, 10:27 AM · Inline Comments
epriestley added a parent task for T11648: Jumping to an reply inline comment via URL anchor should highlight the comment node accurately: T12634: Keyboard focus reticle is generally oblivious to the world around it.
Apr 24 2017, 10:27 AM · Inline Comments, Differential, Bug Report
epriestley added a parent task for T10049: Differential highlight reticle persists after focusing an inline comment, then hiding it: T12634: Keyboard focus reticle is generally oblivious to the world around it.
Apr 24 2017, 10:27 AM · Inline Comments, Differential
epriestley added subtasks for T12634: Keyboard focus reticle is generally oblivious to the world around it: T12633: Interacting with the InlineEditor does not resize or reposition the keyboard focus reticle, T12632: Resizing a diff does not resize the keyboard focus reticle, T9270: Toggling File Browser on Differential while creating inline comment causes inline/edit focus reticle to offset, T10049: Differential highlight reticle persists after focusing an inline comment, then hiding it, T11648: Jumping to an reply inline comment via URL anchor should highlight the comment node accurately.
Apr 24 2017, 10:27 AM · Differential, Inline Comments
epriestley created T12634: Keyboard focus reticle is generally oblivious to the world around it.
Apr 24 2017, 10:26 AM · Differential, Inline Comments
epriestley moved T10049: Differential highlight reticle persists after focusing an inline comment, then hiding it from Glitches to Reticle on the Inline Comments board.
Apr 24 2017, 10:25 AM · Inline Comments, Differential
epriestley renamed T9270: Toggling File Browser on Differential while creating inline comment causes inline/edit focus reticle to offset from Toggling File Browser on Differential while creating inline comment causes line highlight to offset to Toggling File Browser on Differential while creating inline comment causes keyboard focus reticle to offset.
Apr 24 2017, 10:25 AM · Inline Comments, Differential
epriestley moved T9270: Toggling File Browser on Differential while creating inline comment causes inline/edit focus reticle to offset from Glitches to Reticle on the Inline Comments board.
Apr 24 2017, 10:25 AM · Inline Comments, Differential
epriestley added a revision to T10954: Differential keyboard shortcut inline selection reticle is visually unclear (bad z-index?): Unknown Object (Differential Revision).
Apr 24 2017, 10:21 AM · Inline Comments, Differential, Feature Request
epriestley created T12633: Interacting with the InlineEditor does not resize or reposition the keyboard focus reticle.
Apr 24 2017, 10:18 AM · Inline Comments
epriestley created T12632: Resizing a diff does not resize the keyboard focus reticle.
Apr 24 2017, 10:17 AM · Inline Comments
epriestley added a comment to T11648: Jumping to an reply inline comment via URL anchor should highlight the comment node accurately.

Oh, the highlight itself actually is a little off if the reply is threaded. We move the comment up a little bit to make it visually thread a little more cleanly, but the highlight doesn't get a corresponding offset.

Apr 24 2017, 10:13 AM · Inline Comments, Differential, Bug Report
epriestley added a comment to T10954: Differential keyboard shortcut inline selection reticle is visually unclear (bad z-index?).

I'm going to try putting this on top of everything and using pointer-events: none to fix all the attendant click/hover/select issues.

Apr 24 2017, 10:09 AM · Inline Comments, Differential, Feature Request
epriestley moved T10954: Differential keyboard shortcut inline selection reticle is visually unclear (bad z-index?) from Glitches to Reticle on the Inline Comments board.
Apr 24 2017, 10:05 AM · Inline Comments, Differential, Feature Request
epriestley moved T11648: Jumping to an reply inline comment via URL anchor should highlight the comment node accurately from Glitches to Reticle on the Inline Comments board.
Apr 24 2017, 10:05 AM · Inline Comments, Differential, Bug Report
epriestley renamed T11648: Jumping to an reply inline comment via URL anchor should highlight the comment node accurately from Inline comment highlight is slightly misaligned to Jumping to an inline comment via URL anchor should highlight it with the keyboard focus reticle.
Apr 24 2017, 10:03 AM · Inline Comments, Differential, Bug Report
epriestley triaged T11648: Jumping to an reply inline comment via URL anchor should highlight the comment node accurately as Low priority.
Apr 24 2017, 10:03 AM · Inline Comments, Differential, Bug Report
epriestley added a comment to T11648: Jumping to an reply inline comment via URL anchor should highlight the comment node accurately.

There are three different highlights at play here, visible in this screenshot:

Apr 24 2017, 10:03 AM · Inline Comments, Differential, Bug Report

Apr 23 2017

epriestley added a comment to T12611: Write Phabricator HTTP and SSH logs in the production cluster.

The Aphlict logs should probably get consolidated here too, they're set up a little weird and don't currently rotate during normal deployments.

Apr 23 2017, 7:18 PM · Phacility, Ops
epriestley closed T12621: remarkup literal block requires text on beginning line as Resolved by committing Restricted Diffusion Commit.
Apr 23 2017, 6:25 PM · Remarkup, Bug Report
epriestley closed T12614: Add file transform unit tests as Resolved by committing Restricted Diffusion Commit.
Apr 23 2017, 6:02 PM · Bug Report
epriestley closed T10929: Remarkup block rules rely on sort stability, a subtask of T12621: remarkup literal block requires text on beginning line, as Resolved.
Apr 23 2017, 6:02 PM · Remarkup, Bug Report
epriestley closed T10929: Remarkup block rules rely on sort stability as Resolved by committing Restricted Diffusion Commit.
Apr 23 2017, 6:02 PM · Remarkup
epriestley closed T12628: Old migration resizes and writes new Conpherence room images, but Files have changed since then as Resolved by committing Restricted Diffusion Commit.
Apr 23 2017, 5:46 PM · Installing & Upgrading, Bug Report
epriestley added a comment to T12629: Start daemons that should be running but aren't.

It is intentional that daemons shutdown when they aren't doing anything. See T12298. They will be restarted automatically when work becomes ready.

Apr 23 2017, 5:45 PM · Daemons, Feature Request
epriestley added a revision to T12611: Write Phabricator HTTP and SSH logs in the production cluster: Unknown Object (Differential Revision).
Apr 23 2017, 2:57 PM · Phacility, Ops
epriestley added a revision to T12611: Write Phabricator HTTP and SSH logs in the production cluster: Unknown Object (Differential Revision).
Apr 23 2017, 2:47 PM · Phacility, Ops
epriestley added a revision to T12611: Write Phabricator HTTP and SSH logs in the production cluster: Unknown Object (Differential Revision).
Apr 23 2017, 2:37 PM · Phacility, Ops
epriestley added a revision to T12611: Write Phabricator HTTP and SSH logs in the production cluster: Unknown Object (Differential Revision).
Apr 23 2017, 2:35 PM · Phacility, Ops
epriestley added a revision to T12613: In diffusion hosting subversion repository, several commands do not return (freeze).: Unknown Object (Differential Revision).
Apr 23 2017, 1:19 PM · Diffusion, Bug Report
epriestley added a revision to T12614: Add file transform unit tests: Unknown Object (Differential Revision).
Apr 23 2017, 1:10 PM · Bug Report
epriestley claimed T12614: Add file transform unit tests.
Apr 23 2017, 1:02 PM · Bug Report
epriestley claimed T12621: remarkup literal block requires text on beginning line.
Apr 23 2017, 1:01 PM · Remarkup, Bug Report
epriestley added a revision to T12621: remarkup literal block requires text on beginning line: Unknown Object (Differential Revision).
Apr 23 2017, 1:01 PM · Remarkup, Bug Report
epriestley added a revision to T10929: Remarkup block rules rely on sort stability: Unknown Object (Differential Revision).
Apr 23 2017, 12:50 PM · Remarkup
epriestley renamed T12628: Old migration resizes and writes new Conpherence room images, but Files have changed since then from Error running Storage Upgrade to Old migration resizes and writes new Conpherence room images, but Files have changed since then.
Apr 23 2017, 11:53 AM · Installing & Upgrading, Bug Report
epriestley claimed T12628: Old migration resizes and writes new Conpherence room images, but Files have changed since then.
Apr 23 2017, 11:49 AM · Installing & Upgrading, Bug Report
epriestley added a comment to T12628: Old migration resizes and writes new Conpherence room images, but Files have changed since then.

This is a bug in the upstream. D17770 (or some similar patch) should be available later today.

Apr 23 2017, 11:48 AM · Installing & Upgrading, Bug Report
epriestley added a revision to T12628: Old migration resizes and writes new Conpherence room images, but Files have changed since then: Unknown Object (Differential Revision).
Apr 23 2017, 11:42 AM · Installing & Upgrading, Bug Report

Apr 22 2017

johnny-bit awarded T12600: Update Hovercards a Love token.
Apr 22 2017, 6:41 PM · Restricted Project, Hovercards
epriestley added a comment to T12600: Update Hovercards.

Tasks, projects, owners packages.

Apr 22 2017, 5:59 PM · Restricted Project, Hovercards
epriestley added a subtask for T12621: remarkup literal block requires text on beginning line: T10929: Remarkup block rules rely on sort stability.
Apr 22 2017, 4:31 PM · Remarkup, Bug Report
epriestley added a parent task for T10929: Remarkup block rules rely on sort stability: T12621: remarkup literal block requires text on beginning line.
Apr 22 2017, 4:31 PM · Remarkup
epriestley added a revision to T12622: Unhandled Exception ("RuntimeException") when accessing conpherence: Unknown Object (Differential Revision).
Apr 22 2017, 4:22 PM · Bug Report
epriestley added a comment to T12621: remarkup literal block requires text on beginning line.

This is probably the fix:

Apr 22 2017, 4:16 PM · Remarkup, Bug Report
epriestley added a comment to T12621: remarkup literal block requires text on beginning line.

It looks like the existing test cases in master fail on PHP 7.1, presumably because of T10929, so that needs to be fixed before I can fix this.

Apr 22 2017, 4:15 PM · Remarkup, Bug Report
epriestley added a comment to T12621: remarkup literal block requires text on beginning line.

This rule is constructed very awkwardly and I'd sort of prefer to remove it entirely, but I think we can technically fix this without really disrupting things.

Apr 22 2017, 4:09 PM · Remarkup, Bug Report

Apr 21 2017

epriestley edited the content of Changelog.
Apr 21 2017, 11:57 PM
epriestley created 2017 Week 16 (Late April).
Apr 21 2017, 11:56 PM
epriestley added a comment to T12619: Conpherence fatals on a fresh install.

No problem, thanks for the report!

Apr 21 2017, 10:06 PM · Conpherence, Bug Report
epriestley closed T12619: Conpherence fatals on a fresh install as Resolved by committing Restricted Diffusion Commit.
Apr 21 2017, 9:50 PM · Conpherence, Bug Report
epriestley added a revision to T12619: Conpherence fatals on a fresh install: Unknown Object (Differential Revision).
Apr 21 2017, 9:47 PM · Conpherence, Bug Report
epriestley claimed T12619: Conpherence fatals on a fresh install.
Apr 21 2017, 9:47 PM · Conpherence, Bug Report
epriestley added a revision to T12612: Design (and possibly implement) production rate limiting controls: Unknown Object (Differential Revision).
Apr 21 2017, 9:24 PM · Phacility, Ops
epriestley added a revision to T12612: Design (and possibly implement) production rate limiting controls: Unknown Object (Differential Revision).
Apr 21 2017, 9:20 PM · Phacility, Ops
epriestley added a revision to T12612: Design (and possibly implement) production rate limiting controls: Unknown Object (Differential Revision).
Apr 21 2017, 8:59 PM · Phacility, Ops
epriestley archived Phabot.
Apr 21 2017, 7:52 PM
epriestley closed T1271: Jabber Integration as Wontfix by committing Restricted Diffusion Commit.
Apr 21 2017, 7:48 PM · Restricted Project, Conpherence, Phabot, HipChat
epriestley closed T2731: remote control of Bot via external API as Wontfix by committing Restricted Diffusion Commit.
Apr 21 2017, 7:48 PM · Conpherence, Phabot
epriestley closed T7800: Allow Phabricator IRC bot to connect to channels that require password as Wontfix by committing Restricted Diffusion Commit.
Apr 21 2017, 7:48 PM · Restricted Project, Conpherence, Phabot
epriestley closed T7829: PhabricatorBotFeedNotificationHandler is completely broken and unusable as Wontfix by committing Restricted Diffusion Commit.
Apr 21 2017, 7:48 PM · Conpherence, Phabot
epriestley closed T7965: phabot / chatbot should supporting connecting through a proxy as Wontfix by committing Restricted Diffusion Commit.
Apr 21 2017, 7:48 PM · Conpherence, Phabot
epriestley added a revision to T1271: Jabber Integration: Unknown Object (Differential Revision).
Apr 21 2017, 7:46 PM · Restricted Project, Conpherence, Phabot, HipChat
epriestley added a revision to T2731: remote control of Bot via external API: Unknown Object (Differential Revision).
Apr 21 2017, 7:46 PM · Conpherence, Phabot
epriestley added a revision to T7829: PhabricatorBotFeedNotificationHandler is completely broken and unusable: Unknown Object (Differential Revision).
Apr 21 2017, 7:46 PM · Conpherence, Phabot
epriestley added a revision to T7800: Allow Phabricator IRC bot to connect to channels that require password: Unknown Object (Differential Revision).
Apr 21 2017, 7:46 PM · Restricted Project, Conpherence, Phabot
epriestley added a revision to T7965: phabot / chatbot should supporting connecting through a proxy: Restricted Differential Revision.
Apr 21 2017, 7:46 PM · Conpherence, Phabot
epriestley shifted T12611: Write Phabricator HTTP and SSH logs in the production cluster from the Restricted Space space to the S1 Core space.
Apr 21 2017, 7:21 PM · Phacility, Ops