Page MenuHomePhabricator

Unhandled Exception ("RuntimeException") when accessing conpherence
Closed, ResolvedPublic

Description

When attempting to access the conpherwnce an I handled exception occurs for Undefined variable: theme_class.

Reproduction:

  1. As a logged out user, that is not a member of any rooms, access the homepage of secure.phabricator.com
  2. Select the link to general chat
  3. Get exception message

In ConpherenceThread.php on line 213 theme_class is only set if the user is a participant, but the theme_class variable is accessed even if user is not in the room.

Version:
Phabricator: 3698e4a14f6c
Arcanist: 146693307f60
Libphutil: 6fe33623cda6

Revisions and Commits

Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision

Event Timeline

chad added a revision: Restricted Differential Revision.Apr 22 2017, 2:30 PM
chad closed this task as Resolved by committing Restricted Diffusion Commit.Apr 22 2017, 4:01 PM
chad added a commit: Restricted Diffusion Commit.
epriestley added a commit: Restricted Diffusion Commit.Apr 22 2017, 4:17 PM
epriestley added a revision: Restricted Differential Revision.Apr 22 2017, 4:22 PM
epriestley added a commit: Restricted Diffusion Commit.Apr 22 2017, 4:23 PM
epriestley added a commit: Restricted Diffusion Commit.