Page MenuHomePhabricator
Feed Advanced Search

Jan 26 2017

epriestley added a comment to T11741: Quickstart can fail to initialize databases if MyISAM is not available (currently, only in Google Cloud).

From downstream, MariaDB has a fairly severe bug when indexing tokens with length greater than 127 bytes:

Jan 26 2017, 8:35 PM
epriestley added a comment to T11957: Add MenuEngine to Home.

I have discovered that we already have PhabricatorDashboardProfileMenuItem.

Jan 26 2017, 7:54 PM · Profile Menu Item, Dashboards
epriestley created T12158: Possible JS error in Phortune when adding new card.
Jan 26 2017, 7:49 PM · Phortune
epriestley added a comment to T12137: MySQL fulltext search returns no results in boolean mode when a query includes +"x", where "x" is a stopword or short token.

Yeah, you should be good now. I'll look into the JS thing since we like money.

Jan 26 2017, 7:49 PM · Search, Customer Impact, Bug Report
epriestley backed I2 Donate to Phacility with $3.00 USD.
Jan 26 2017, 7:48 PM · Phacility
epriestley added a comment to T11957: Add MenuEngine to Home.

Oh! I thought that mock was a screenshot and that "Home" was a new DashboardMenuItem. No conflicts, I'll shoot you a diff in a bit.

Jan 26 2017, 7:42 PM · Profile Menu Item, Dashboards
epriestley added a comment to T11957: Add MenuEngine to Home.

Yeah, but since you already wrote DashboardMenuItem we'd conflict -- do you want to just diff that separately now, then I'll fancy-it-up and it should integrate cleanly?

Jan 26 2017, 7:39 PM · Profile Menu Item, Dashboards
epriestley added a comment to T11957: Add MenuEngine to Home.

We shouldn't need to build a route into the applications separately -- getProfileMenuRouting() already adds a route (from the code, I guess the actual route is /home/item/view/123/).

Jan 26 2017, 7:28 PM · Profile Menu Item, Dashboards
epriestley added a comment to T11957: Add MenuEngine to Home.

Yeah, fully agreed that we should stay in Home in terms of the nav menu, crumbs (none on Home, but relevant for Projects), checking application permissions, etc. I just got scared off by "AJAX", since I think the non-ajax thing will take me 20 minutes and an Ajax version would take me 20000 minutes.

Jan 26 2017, 7:09 PM · Profile Menu Item, Dashboards
epriestley added a comment to T11957: Add MenuEngine to Home.

If you just want to diff that when it's ready I can implement the fancier version to get the dashboard rendering on the same page. Looking at the code, it's not quite as simple as I remembered -- I thought we had some similar panels already, but all the stuff we have is more hard-coded than I thought.

Jan 26 2017, 7:05 PM · Profile Menu Item, Dashboards
epriestley added a comment to T11957: Add MenuEngine to Home.

I mean if you're on home, and you have 3 dashboards, that you don't leave home. I think we talked about this before and you said that was simple.

Jan 26 2017, 6:57 PM · Profile Menu Item, Dashboards
epriestley added a comment to T11957: Add MenuEngine to Home.

That is, the rule the menu already uses is already "show the item the user has explicitly selected as the default item, or the first item which they could select as a default, if they haven't selected one yet". This is what lets you pick projects to default to the workboard or project profile, but causes them to default to the project profile.

Jan 26 2017, 6:53 PM · Profile Menu Item, Dashboards
epriestley added a comment to T11957: Add MenuEngine to Home.

Selecting first dashboard as homepage. I think I can just query the menu itself in MainController and pull it out? Use built in home if nothing returned?

Jan 26 2017, 6:49 PM · Profile Menu Item, Dashboards
epriestley added a comment to T12157: Make it visibly clearer that a Phabricator user account has been disabled.

🐈

Jan 26 2017, 6:29 PM · Profile, Feature Request
epriestley added a revision to T10978: Modernize Audit: Unknown Object (Differential Revision).
Jan 26 2017, 6:27 PM · Audit
epriestley updated subscribers of T12157: Make it visibly clearer that a Phabricator user account has been disabled.

Downstream, @20after4 calls out that mentioning disabled users in comments still subscribes them, as though they were normal users. This behavior would be easy to change, but I could sort of go either way on it.

Jan 26 2017, 6:19 PM · Profile, Feature Request
epriestley added a comment to T12137: MySQL fulltext search returns no results in boolean mode when a query includes +"x", where "x" is a stopword or short token.
# git show 2dad469
commit 2dad469eca22e344e6e35d7560e822a107aa318e
Author: epriestley <git@epriestley.com>
Date:   Mon Jun 22 11:47:58 2015 -0700
Jan 26 2017, 6:03 PM · Search, Customer Impact, Bug Report
epriestley updated subscribers of T12157: Make it visibly clearer that a Phabricator user account has been disabled.

I think we have some discussion of this somewhere, although I don't immediately recall where and it's not in the obvious places. I might be conflating discussion of the recently-reworked "Available" status.

Jan 26 2017, 5:55 PM · Profile, Feature Request
epriestley added a comment to T12137: MySQL fulltext search returns no results in boolean mode when a query includes +"x", where "x" is a stopword or short token.

Ah, that's probably from an earlier git pull. Each of those merges have two parents, like this in the most recent output:

Jan 26 2017, 5:08 PM · Search, Customer Impact, Bug Report
epriestley added a comment to T12137: MySQL fulltext search returns no results in boolean mode when a query includes +"x", where "x" is a stopword or short token.

I'm not entirely sure what I did here to screw that up.

Jan 26 2017, 5:00 PM · Search, Customer Impact, Bug Report
epriestley added a comment to T12137: MySQL fulltext search returns no results in boolean mode when a query includes +"x", where "x" is a stopword or short token.

According to that test, your server does not support InnoDB fulltext, so what you're seeing is expected: we keep the tables with FULLTEXT indexes on MyISAM if innodb_ft_max_token_size is not a defined system variable.

Jan 26 2017, 4:59 PM · Search, Customer Impact, Bug Report
epriestley added a comment to T12137: MySQL fulltext search returns no results in boolean mode when a query includes +"x", where "x" is a stopword or short token.

It looks like my server supports InnoDB fulltext search

Jan 26 2017, 4:57 PM · Search, Customer Impact, Bug Report
epriestley added a comment to T12137: MySQL fulltext search returns no results in boolean mode when a query includes +"x", where "x" is a stopword or short token.

I don't think this is a stemming problem. Note that we MATCH(corpus, stemmedCorpus) against the query, so we're actually searching in the text "this is a test thi test". I wrote stemming so that it should never match fewer documents than an unstemmed query would -- definitely possible I got something wrong, but that's the intent, at least: stemming only gives you more hits.

Jan 26 2017, 3:49 PM · Search, Customer Impact, Bug Report
epriestley added a comment to T12137: MySQL fulltext search returns no results in boolean mode when a query includes +"x", where "x" is a stopword or short token.

I can get around this by just hashing some unique string that makes up the error and dumping that into the task description and search off of that since full-text searching for single strings works as expected.

Jan 26 2017, 3:29 PM · Search, Customer Impact, Bug Report
epriestley added a revision to T10978: Modernize Audit: Unknown Object (Differential Revision).
Jan 26 2017, 3:17 PM · Audit
epriestley closed T12156: User is unable to close an audit for own commits, even audit.can-author-close-audit is set to TRUE as Resolved.

What for is "audit.can-author-close-audit" then?

Jan 26 2017, 2:22 PM · Feature Request (Needs Information)
epriestley added a comment to T12156: User is unable to close an audit for own commits, even audit.can-author-close-audit is set to TRUE.

You could also add a condition like this to your rules which trigger audits:

Jan 26 2017, 2:15 PM · Feature Request (Needs Information)
epriestley added a comment to T12156: User is unable to close an audit for own commits, even audit.can-author-close-audit is set to TRUE.

he has to remove the group and add himself as Auditor

Jan 26 2017, 2:12 PM · Feature Request (Needs Information)
epriestley edited projects for T12156: User is unable to close an audit for own commits, even audit.can-author-close-audit is set to TRUE, added: Feature Request (Needs Information); removed Bug Report.
Jan 26 2017, 1:52 PM · Feature Request (Needs Information)
epriestley added a comment to T12156: User is unable to close an audit for own commits, even audit.can-author-close-audit is set to TRUE.

Can you describe how audit works in your organization and why you want authors to be able to close audits after T2393?

Jan 26 2017, 1:49 PM · Feature Request (Needs Information)
epriestley closed T12155: Use branches for Staging Area as Invalid.
Jan 26 2017, 3:59 AM · Feature Request

Jan 25 2017

epriestley closed T2393: Adds a "Needs Verification" state to Audits as Resolved by committing Restricted Diffusion Commit.
Jan 25 2017, 9:09 PM · Restricted Project, Audit
epriestley added a comment to T2393: Adds a "Needs Verification" state to Audits.

After D17252, audits now have a "Request Verification" action and a "Needs Verification" state. These states prompt auditors to verify the remedies the author has offered have addressed their concerns. Intended usage is along these lines:

Jan 25 2017, 8:34 PM · Restricted Project, Audit
epriestley merged T4026: Add relations between commits into T2393: Adds a "Needs Verification" state to Audits.
Jan 25 2017, 8:29 PM · Restricted Project, Audit
epriestley merged task T4026: Add relations between commits into T2393: Adds a "Needs Verification" state to Audits.
Jan 25 2017, 8:29 PM · Restricted Project, Audit
epriestley added a comment to T4026: Add relations between commits.

I'm going to merge this into T2393, where I'll discuss this shortly.

Jan 25 2017, 8:29 PM · Restricted Project, Audit
epriestley added a revision to T2393: Adds a "Needs Verification" state to Audits: Unknown Object (Differential Revision).
Jan 25 2017, 8:21 PM · Restricted Project, Audit
epriestley added a revision to T2393: Adds a "Needs Verification" state to Audits: Unknown Object (Differential Revision).
Jan 25 2017, 7:51 PM · Restricted Project, Audit
epriestley added a revision to T2393: Adds a "Needs Verification" state to Audits: Unknown Object (Differential Revision).
Jan 25 2017, 7:45 PM · Restricted Project, Audit
epriestley added a revision to T2393: Adds a "Needs Verification" state to Audits: Unknown Object (Differential Revision).
Jan 25 2017, 7:27 PM · Restricted Project, Audit
epriestley added a revision to T11114: Move Differential to EditEngine: Unknown Object (Differential Revision).
Jan 25 2017, 7:25 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
epriestley closed T12154: PR branches are imported when mirroring a GitHub repo ignoring "Track Only" settings as Invalid.

I filed this task from the perspective of what it looks to the user, not from the engineering implementation perspective.

Jan 25 2017, 6:10 PM · Bug Report
epriestley added a comment to T12154: PR branches are imported when mirroring a GitHub repo ignoring "Track Only" settings.

Does my email about refs/pull/68/head explain this behavior?

Jan 25 2017, 4:55 PM · Bug Report
epriestley added a comment to T12145: Resource allocator does not create new host resources when one is already active.

Is there some scenario which can trigger both bindings in a host group to be brought online?

Jan 25 2017, 4:06 PM · Bug Report, Drydock
epriestley moved T12153: 'Show Hidden Comments' bubble does not fit in margin next to line numbers >1000 from Backlog to Inline Infra on the Differential board.
Jan 25 2017, 3:52 PM · Inline Comments, Differential, Bug Report
epriestley triaged T12153: 'Show Hidden Comments' bubble does not fit in margin next to line numbers >1000 as Low priority.
Jan 25 2017, 3:52 PM · Inline Comments, Differential, Bug Report
epriestley added a comment to T12153: 'Show Hidden Comments' bubble does not fit in margin next to line numbers >1000.

What possible use case could anyone ever have for putting a THOUSAND lines of source code in a single file?!!

Jan 25 2017, 3:52 PM · Inline Comments, Differential, Bug Report
epriestley added a comment to T12145: Resource allocator does not create new host resources when one is already active.

Without actually reproducing this or looking at the code, I believe this isn't a bug. You're expecting Drydock to choose particular allocation strategies:

Jan 25 2017, 3:42 PM · Bug Report, Drydock
epriestley added a comment to T5000: Using Differential with plain Git, without requiring Arc.

No easy way to apply a policy to a group of repos.

Jan 25 2017, 2:10 PM · KDE, FreeBSD, Restricted Project, Haskell.org, Arcanist, Differential
chbrossotaf awarded T7789: Support Git Large File Storage a Like token.
Jan 25 2017, 10:21 AM · Customer Impact, Restricted Project, Files, Diffusion
• 1stone awarded T4558: Make Diviner useful for third-parties a Like token.
Jan 25 2017, 8:16 AM · Diviner
epriestley added a comment to T12139: Add a proper emoji picker to Remarkup bar.

He's so little. :)

Jan 25 2017, 4:28 AM · Remarkup, PHUI
epriestley added a comment to T12139: Add a proper emoji picker to Remarkup bar.

Poor 🐈.

Jan 25 2017, 4:25 AM · Remarkup, PHUI
epriestley added a comment to T12139: Add a proper emoji picker to Remarkup bar.

I guess I don't even have a glyph for :lion_face: anyway.

Jan 25 2017, 4:17 AM · Remarkup, PHUI
epriestley added a comment to T12139: Add a proper emoji picker to Remarkup bar.

Also while you're in there maybe replace _ with (space) in the strings? I can't find :lion_face: by typing :fac... right now, but I think if you swap the underscores for spaces it will work. Then :cat should be able to find crying_cat_face and stuff, too.

Jan 25 2017, 4:15 AM · Remarkup, PHUI
epriestley added a comment to T12139: Add a proper emoji picker to Remarkup bar.

not memorizing emoji collation order in 2017 pfft

Jan 25 2017, 4:14 AM · Remarkup, PHUI
epriestley added a comment to T12139: Add a proper emoji picker to Remarkup bar.

The list is sorted by emoji. 🐈 is "alphabetically" earlier than 🐱 in the list of emoji.

Jan 25 2017, 4:12 AM · Remarkup, PHUI

Jan 24 2017

epriestley added a revision to T2393: Adds a "Needs Verification" state to Audits: Unknown Object (Differential Revision).
Jan 24 2017, 4:59 PM · Restricted Project, Audit
epriestley moved T12151: Repository mail silencing rules aren't intuitive if you audit an importing repository from Backlog to Future on the Audit board.
Jan 24 2017, 3:44 PM · Phacility, Diffusion, Audit
epriestley closed T12152: Adding a task from the workboard with a subproject tag is frozing the UI as Resolved by committing Restricted Diffusion Commit.
Jan 24 2017, 3:41 PM · Bug Report
epriestley added a comment to T12152: Adding a task from the workboard with a subproject tag is frozing the UI.

D17242 should fix this, thanks for the report!

Jan 24 2017, 3:40 PM · Bug Report
epriestley added a revision to T12152: Adding a task from the workboard with a subproject tag is frozing the UI: Unknown Object (Differential Revision).
Jan 24 2017, 3:31 PM · Bug Report
epriestley added a comment to T12152: Adding a task from the workboard with a subproject tag is frozing the UI.

There's now a grayed out page

Jan 24 2017, 2:59 PM · Bug Report
epriestley added a comment to T12150: Restricting Push not working.

your phutil is 3 weeks older than the rest

Jan 24 2017, 2:39 PM · Bug Report (Needs Information)
epriestley added a comment to T12147: Tag task with a Project and Subproject.

Should I open a new bug?

Jan 24 2017, 2:35 PM · Bug Report
epriestley created T12151: Repository mail silencing rules aren't intuitive if you audit an importing repository.
Jan 24 2017, 2:21 PM · Phacility, Diffusion, Audit

Jan 23 2017

epriestley closed T12149: Provide a toast while actively tracking time as Invalid.

Phrequent is a prototype. We do not accept feature requests for prototypes, see User Guide: Prototype Applications.

Jan 23 2017, 8:17 PM · Maniphest, Feature Request
epriestley closed T12141: Cannot access phabricator when wrong email entered at account creation as Wontfix.

This is exceptionally rare, strictly user error (i.e., avoidable by entering your email address correctly), and administrators can force-verify email addresses with bin/accountadmin which offers one way out of this state.

Jan 23 2017, 6:18 PM · Bug Report
epriestley added a comment to T12139: Add a proper emoji picker to Remarkup bar.

This is what I see on my Macbook in Safari:

Jan 23 2017, 5:57 PM · Remarkup, PHUI
epriestley added a comment to T12139: Add a proper emoji picker to Remarkup bar.

Emoji look terrible on nearly every platform / browser

Jan 23 2017, 5:41 PM · Remarkup, PHUI
epriestley merged T12148: "View Raw File" in Diffusion no longer takes you to the raw output of the file into T8170: Diffusion -> show raw file doesn't always render text.
Jan 23 2017, 5:16 PM · Diffusion
epriestley merged task T12148: "View Raw File" in Diffusion no longer takes you to the raw output of the file into T8170: Diffusion -> show raw file doesn't always render text.
Jan 23 2017, 5:16 PM · Diffusion, Bug Report
epriestley added a comment to T11662: Draft comments which reply to ghost inlines from lines which no longer exist can not be edited or deleted until the page is reloaded.

I think it's useful to keep track of bugs which impact customers

Jan 23 2017, 3:13 PM · Inline Comments, Customer Impact, Differential
epriestley added a comment to T11662: Draft comments which reply to ghost inlines from lines which no longer exist can not be edited or deleted until the page is reloaded.

I tagged this with Phacility because a Phacility customer was the original reporter. I think it's useful to keep track of bugs which impact customers, but maybe I should make a different tag?

Jan 23 2017, 3:12 PM · Inline Comments, Customer Impact, Differential
epriestley closed T12146: Adding multiple Tags on a Diffusion Repository leads to a 404 as Invalid.

I can't reproduce this. It's possible that you actually experienced T11165 and misremembered exactly what you'd done, or performed one edit in a tab with the other tab open.

Jan 23 2017, 3:10 PM · Diffusion, Bug Report
epriestley closed T12147: Tag task with a Project and Subproject as Invalid.

This is by design, and explained in the documentation.

Jan 23 2017, 3:08 PM · Bug Report

Jan 22 2017

epriestley added a comment to T12144: Ability to reorder milestones on a project's workboard.

If the milestones aren't strictly ordered, why did the user create milestones instead of subprojects?

Jan 22 2017, 11:31 PM · Projects, Feature Request
dmgarcia awarded T12101: Phabricator PHP 7 Compatibility a Yellow Medal token.
Jan 22 2017, 7:35 PM · Infrastructure, Guides
chad awarded T9640: Make Phabricator compatible with PHP7 a Yellow Medal token.
Jan 22 2017, 7:26 PM · Prioritized, Restricted Project, Infrastructure
dmgarcia awarded T9640: Make Phabricator compatible with PHP7 a Yellow Medal token.
Jan 22 2017, 7:20 PM · Prioritized, Restricted Project, Infrastructure
dmgarcia awarded T9640: Make Phabricator compatible with PHP7 a Orange Medal token.
Jan 22 2017, 7:20 PM · Prioritized, Restricted Project, Infrastructure
epriestley added a comment to T12142: PhabricatorProjectWorkboardProfileMenuItem::validateTransactions() when creating a new workboard.

I deployed this to the Phacility production cluster.

Jan 22 2017, 7:03 PM · Bug Report
epriestley merged T12143: "Create Workboard" action fails when "Make Default" checkbox checked into T12142: PhabricatorProjectWorkboardProfileMenuItem::validateTransactions() when creating a new workboard.
Jan 22 2017, 7:01 PM · Bug Report
epriestley merged task T12143: "Create Workboard" action fails when "Make Default" checkbox checked into T12142: PhabricatorProjectWorkboardProfileMenuItem::validateTransactions() when creating a new workboard.
Jan 22 2017, 7:01 PM · Bug Report
epriestley added a comment to T12143: "Create Workboard" action fails when "Make Default" checkbox checked.

I'm going to merge this into T12142 since that one has an earlier timestamp even though this one is more pure of heart.

Jan 22 2017, 7:01 PM · Bug Report

Jan 21 2017

epriestley added a comment to T12139: Add a proper emoji picker to Remarkup bar.

I think the pros and cons are something like:

Jan 21 2017, 7:29 PM · Remarkup, PHUI
epriestley added a comment to T12139: Add a proper emoji picker to Remarkup bar.

I think we should just use actual emoji for this, not sprite sheets?

Jan 21 2017, 7:07 PM · Remarkup, PHUI
epriestley added a comment to T12139: Add a proper emoji picker to Remarkup bar.

tarnation

Jan 21 2017, 7:05 PM · Remarkup, PHUI
epriestley added a comment to T12140: When Home is uninstalled, the user menu disappears / 2017 Week 3 Deployment Log.

I deployed that change here (secure.phabricator.com). I'll cherry-pick it and deploy it on admin in a little bit, if nothing catches on explosion fire.

Jan 21 2017, 4:54 PM · Phacility, Ops, Applications
epriestley added a comment to T12140: When Home is uninstalled, the user menu disappears / 2017 Week 3 Deployment Log.

Haha, no worries. Uninstalling Home is pretty unusual.

Jan 21 2017, 4:49 PM · Phacility, Ops, Applications
epriestley added a revision to T12140: When Home is uninstalled, the user menu disappears / 2017 Week 3 Deployment Log: Unknown Object (Differential Revision).
Jan 21 2017, 4:32 PM · Phacility, Ops, Applications
epriestley added a comment to T12140: When Home is uninstalled, the user menu disappears / 2017 Week 3 Deployment Log.

After purging dead instances, db003 and db004 are each <25% utilized on their data volumes.

Jan 21 2017, 3:57 PM · Phacility, Ops, Applications
epriestley added a comment to T12140: When Home is uninstalled, the user menu disappears / 2017 Week 3 Deployment Log.

Purging db001 brought primary volume down to 79.2%, which is technically below the 80% caution threshold. It doesn't need to be fixed immediately, but the pathway forward isn't terribly clear. Some options are:

Jan 21 2017, 3:44 PM · Phacility, Ops, Applications
epriestley added a comment to T12140: When Home is uninstalled, the user menu disappears / 2017 Week 3 Deployment Log.

Instance service windows on db003 and db004 have synchronized and the shards are now purging.

Jan 21 2017, 3:37 PM · Phacility, Ops, Applications
epriestley added a comment to T12140: When Home is uninstalled, the user menu disappears / 2017 Week 3 Deployment Log.

The temporary directory storage pressure on repo016 has an unclear root cause (it's related to importing an SVN repository, but I haven't been able to pinpoint where the issue started). The issue no longer appears to be occurring so I'm going to stop digging until it happens again.

Jan 21 2017, 3:37 PM · Phacility, Ops, Applications
epriestley added a comment to T12140: When Home is uninstalled, the user menu disappears / 2017 Week 3 Deployment Log.

The storage pressure on db001 is primarily because an instance imported a large SVN repository with approximately 60M paths. The instance is a free instance with one user.

Jan 21 2017, 3:08 PM · Phacility, Ops, Applications
epriestley added a project to T12140: When Home is uninstalled, the user menu disappears / 2017 Week 3 Deployment Log: Phacility.
Jan 21 2017, 2:58 PM · Phacility, Ops, Applications
epriestley renamed T12140: When Home is uninstalled, the user menu disappears / 2017 Week 3 Deployment Log from When Home is uninstalled, the user menu disappears to When Home is uninstalled, the user menu disappears / 2017 Week 3 Deployment Log.
Jan 21 2017, 2:58 PM · Phacility, Ops, Applications
epriestley added a comment to T12140: When Home is uninstalled, the user menu disappears / 2017 Week 3 Deployment Log.

The db001, db003 and db004 shards have also hit 80% full on their primary volumes. I'm purging dead instances from db001 now. db003 and db004 have never been purged and need to have instance out-of-service dates synchronized first. This is currently underway for db004.

Jan 21 2017, 2:58 PM · Phacility, Ops, Applications
epriestley added a comment to T12140: When Home is uninstalled, the user menu disappears / 2017 Week 3 Deployment Log.

I'm going to move forward with the deploy since this shouldn't impact actual instances, the stuff in this menu isn't super-critical, and workarounds (albeit inconvenient ones) exist to access the items.

Jan 21 2017, 2:34 PM · Phacility, Ops, Applications