Page MenuHomePhabricator
Differential D20383

When a dropdown menu would render in a way that hides it offscreen, try a different alignment
ClosedPublic
Actions

Authored by epriestley on Apr 8 2019, 5:31 PM.
Tags
None
Referenced Files
F13153408: D20383.id48645.diff
Sun, May 5, 2:57 AM
F13150506: D20383.id.diff
Sat, May 4, 4:20 PM
Unknown Object (File)
Fri, May 3, 5:17 AM
Unknown Object (File)
Fri, Apr 26, 10:51 PM
Unknown Object (File)
Thu, Apr 25, 12:50 AM
Unknown Object (File)
Fri, Apr 19, 11:06 PM
Unknown Object (File)
Fri, Apr 19, 3:09 AM
Unknown Object (File)
Thu, Apr 18, 5:24 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13272: Remove the hard-coded homepage, and other Dashboards improvements
Commits
rPe4524d470711: When a dropdown menu would render in a way that hides it offscreen, try a…
Summary

Depends on D20382. Ref T13272. When something near the edge of the screen has a dropdown menu, we currently may render the menu offscreen.

Instead, keep the menu onscreen.

(This is happening because I'm adding dropdown menus to tab query panels.)

Test Plan

Before:

Screen Shot 2019-04-08 at 10.29.37 AM.png (267×389 px, 22 KB)

After:

Screen Shot 2019-04-08 at 10.29.19 AM.png (279×383 px, 28 KB)

Diff Detail

Repository
rP Phabricator
Branch
portal25
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 22504
Build 30815: Run Core Tests
Build 30814: arc lint + arc unit

Revision Contents
Changeset List

PathSize
resources/
celerity/
webroot/
rsrc/
js/
phuix/
30 lines

Diff 48629

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/js/phuix/PHUIXDropdownMenu.js

Loading...
Phabricator · Built by Phacility