Page MenuHomePhabricator

Allow profile menu items to be locked to the top or bottom of the menu
ClosedPublic

Authored by epriestley on Mar 30 2019, 10:09 PM.
Tags
None
Referenced Files
F18841456: D20355.diff
Tue, Oct 28, 9:15 AM
F18839563: D20355.id.diff
Mon, Oct 27, 5:13 PM
F18837139: D20355.diff
Mon, Oct 27, 4:31 AM
F18821425: D20355.diff
Wed, Oct 22, 11:02 PM
F18791325: D20355.id48606.diff
Thu, Oct 16, 9:48 AM
F18702586: D20355.id48572.diff
Sep 28 2025, 12:40 AM
F18518603: D20355.diff
Sep 5 2025, 3:24 PM
F18458905: D20355.diff
Sep 1 2025, 3:41 PM
Subscribers
None

Details

Summary

Depends on D20353. Ref T13275. This is just some small quality-of-life fixes:

  • When you add items to menus, they currently go below the "Edit Menu/Manage Menu" links by default. This isn't a very good place for them. Instead, lock "edit" items to the bottom of the menu.
  • Lock profile pictures to the top of the menu. This just simplifies things a little.
  • Show more iconography hints on the "edit menu items" UI.
  • Add a "drag stuff to do things" hint if some stuff can be dragged.
Test Plan
  • Added new items to a Portal, they didn't go to the very bottom. Instead, they went above the "Edit/Manage" links; a sensible place for them.
  • Viewed the "edit menu items" screen, saw more hints and visual richness.
  • Viewed/edited Home, Projects, Portals, Favorites

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable