Page MenuHomePhabricator

Allow profile menu items to be locked to the top or bottom of the menu
ClosedPublic

Authored by epriestley on Mar 30 2019, 10:09 PM.

Details

Summary

Depends on D20353. Ref T13275. This is just some small quality-of-life fixes:

  • When you add items to menus, they currently go below the "Edit Menu/Manage Menu" links by default. This isn't a very good place for them. Instead, lock "edit" items to the bottom of the menu.
  • Lock profile pictures to the top of the menu. This just simplifies things a little.
  • Show more iconography hints on the "edit menu items" UI.
  • Add a "drag stuff to do things" hint if some stuff can be dragged.
Test Plan
  • Added new items to a Portal, they didn't go to the very bottom. Instead, they went above the "Edit/Manage" links; a sensible place for them.
  • Viewed the "edit menu items" screen, saw more hints and visual richness.
  • Viewed/edited Home, Projects, Portals, Favorites

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Mar 30 2019, 10:09 PM
epriestley requested review of this revision.Mar 30 2019, 10:11 PM
amckinley accepted this revision.Apr 1 2019, 7:32 PM
This revision is now accepted and ready to land.Apr 1 2019, 7:32 PM
This revision was automatically updated to reflect the committed changes.