Differential D20355

Allow profile menu items to be locked to the top or bottom of the menu
ClosedPublic
Actions

Authored by epriestley on Mar 30 2019, 10:09 PM.

Tags

None

Referenced Files

	F13051978: D20355.diff
	Fri, Apr 19, 6:10 AM

	F13050679: D20355.diff
	Fri, Apr 19, 3:06 AM

	F13047943: D20355.id48606.diff
	Thu, Apr 18, 3:17 PM

	Unknown Object (File)
	Wed, Apr 17, 8:08 PM

	Unknown Object (File)
	Sun, Mar 31, 2:52 PM

	Unknown Object (File)
	Wed, Mar 27, 10:19 PM

	Unknown Object (File)
	Tue, Mar 26, 12:43 AM

	Unknown Object (File)
	Mon, Mar 25, 7:44 AM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T13275: Build Portals: a standalone menu page / dashboard of dashboards

Commits

rP47bf382435ee: Allow profile menu items to be locked to the top or bottom of the menu

Summary

Depends on D20353. Ref T13275. This is just some small quality-of-life fixes:

When you add items to menus, they currently go below the "Edit Menu/Manage Menu" links by default. This isn't a very good place for them. Instead, lock "edit" items to the bottom of the menu.
Lock profile pictures to the top of the menu. This just simplifies things a little.
Show more iconography hints on the "edit menu items" UI.
Add a "drag stuff to do things" hint if some stuff can be dragged.

Test Plan

Added new items to a Portal, they didn't go to the very bottom. Instead, they went above the "Edit/Manage" links; a sensible place for them.
Viewed the "edit menu items" screen, saw more hints and visual richness.
Viewed/edited Home, Projects, Portals, Favorites

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Mar 30 2019, 10:09 PM

Harbormaster completed remote builds in B22445: Diff 48572.Mar 30 2019, 10:11 PM

epriestley requested review of this revision.Mar 30 2019, 10:11 PM

epriestley added a child revision: D20356: Automatically build mobile menus from navigation, and clean up external ProfileMenu API.Mar 31 2019, 6:54 PM

amckinley accepted this revision.Apr 1 2019, 7:32 PM

This revision is now accepted and ready to land.Apr 1 2019, 7:32 PM

Closed by commit rP47bf382435ee: Allow profile menu items to be locked to the top or bottom of the menu (authored by epriestley). · Explain WhyApr 2 2019, 10:08 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

src/

applications/

dashboard/

engine/

PhabricatorDashboardPortalProfileMenuEngine.php

3 lines

menuitem/

PhabricatorDashboardPortalMenuItem.php

2 lines

home/

menuitem/

PhabricatorHomeLauncherProfileMenuItem.php

6 lines

PhabricatorHomeProfileMenuItem.php

4 lines

project/

engine/

PhabricatorProjectProfileMenuEngine.php

6 lines

menuitem/

PhabricatorProjectDetailsProfileMenuItem.php

4 lines

PhabricatorProjectManageProfileMenuItem.php

4 lines

PhabricatorProjectMembersProfileMenuItem.php

4 lines

PhabricatorProjectPictureProfileMenuItem.php

4 lines

PhabricatorProjectSubprojectsProfileMenuItem.php

4 lines

PhabricatorProjectWorkboardProfileMenuItem.php

4 lines

search/

engine/

PhabricatorProfileMenuEngine.php

45 lines

menuitem/

PhabricatorLabelProfileMenuItem.php

2 lines

PhabricatorManageProfileMenuItem.php

4 lines

storage/

PhabricatorProfileMenuItemConfiguration.php

31 lines

view/

phui/

PHUIObjectItemView.php

12 lines

webroot/

rsrc/

css/

phui/

object-item/

phui-oi-list-view.css

6 lines

Diff 48606

resources/celerity/map.php

Loading...

src/applications/dashboard/engine/PhabricatorDashboardPortalProfileMenuEngine.php

Loading...

src/applications/dashboard/menuitem/PhabricatorDashboardPortalMenuItem.php

Loading...

src/applications/home/menuitem/PhabricatorHomeLauncherProfileMenuItem.php

Loading...

src/applications/home/menuitem/PhabricatorHomeProfileMenuItem.php

Loading...

src/applications/project/engine/PhabricatorProjectProfileMenuEngine.php

Loading...

src/applications/project/menuitem/PhabricatorProjectDetailsProfileMenuItem.php

Loading...

src/applications/project/menuitem/PhabricatorProjectManageProfileMenuItem.php

Loading...

src/applications/project/menuitem/PhabricatorProjectMembersProfileMenuItem.php

Loading...

src/applications/project/menuitem/PhabricatorProjectPictureProfileMenuItem.php

Loading...

src/applications/project/menuitem/PhabricatorProjectSubprojectsProfileMenuItem.php

Loading...

src/applications/project/menuitem/PhabricatorProjectWorkboardProfileMenuItem.php

Loading...

src/applications/search/engine/PhabricatorProfileMenuEngine.php

Loading...

src/applications/search/menuitem/PhabricatorLabelProfileMenuItem.php

Loading...

src/applications/search/menuitem/PhabricatorManageProfileMenuItem.php

Loading...

src/applications/search/storage/PhabricatorProfileMenuItemConfiguration.php

Loading...

src/view/phui/PHUIObjectItemView.php

Loading...

webroot/rsrc/css/phui/object-item/phui-oi-list-view.css

Loading...