Differential D20373

Make the Dashboard dropshadow a little lighter and turn panel management into a menu
ClosedPublic
Actions

Authored by epriestley on Apr 2 2019, 7:41 PM.

Tags

None

Subscribers

None

Details

Reviewers

Maniphest Tasks

T13272: Remove the hard-coded homepage, and other Dashboards improvements

Commits

rPa1a89589b1c0: Make the Dashboard dropshadow a little lighter and turn panel management into a…

Summary

Depends on D20372. Ref T13272.

There's a very heavy dropshadow on panels right now that looks out of place. Reduce it a bit.
Panels currently have unlabeled pencil and trash icons. Turn this into a menu. I'm likely planning to add options like "Change Query..." to this menu to make managing some types of panels easier.

Test Plan

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Apr 2 2019, 7:41 PM

Harbormaster completed remote builds in B22472: Diff 48598.Apr 2 2019, 7:43 PM

epriestley requested review of this revision.Apr 2 2019, 7:43 PM

epriestley added a child revision: D20374: Make "Favorites" work more like other customizable menus.Apr 2 2019, 8:55 PM

amckinley accepted this revision.Apr 3 2019, 7:12 PM

This revision is now accepted and ready to land.Apr 3 2019, 7:12 PM

Closed by commit rPa1a89589b1c0: Make the Dashboard dropshadow a little lighter and turn panel management into a… (authored by epriestley). · Explain WhyApr 9 2019, 8:58 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

src/

applications/

dashboard/

controller/

PhabricatorDashboardRemovePanelController.php

3 lines

panel/

PhabricatorDashboardPanelEditController.php

45 lines

editor/

PhabricatorDashboardPanelEditEngine.php

9 lines

engine/

PhabricatorDashboardPanelRenderingEngine.php

31 lines

webroot/

rsrc/

css/

application/

dashboard/

2 lines

Diff 48639

resources/celerity/map.php

Loading...

src/applications/dashboard/controller/PhabricatorDashboardRemovePanelController.php

Loading...

src/applications/dashboard/controller/panel/PhabricatorDashboardPanelEditController.php

Loading...

src/applications/dashboard/editor/PhabricatorDashboardPanelEditEngine.php

Loading...

src/applications/dashboard/engine/PhabricatorDashboardPanelRenderingEngine.php

Loading...

webroot/rsrc/css/application/dashboard/dashboard.css

Loading...