Page MenuHomePhabricator

Move Dashboard panel controllers into a "panel/" subdirectory
ClosedPublic

Authored by epriestley on Apr 2 2019, 4:17 PM.

Details

Summary

Depends on D20368. Ref T13272. Dashboards have a lot of controllers, try to organize them a little better.

Note "EditController" vs "EditproController". Yikes.

Test Plan

Loaded dashboards. No code changes.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Apr 2 2019, 4:17 PM
epriestley requested review of this revision.Apr 2 2019, 4:18 PM
amckinley accepted this revision.Apr 3 2019, 6:50 PM

Wait, we have both of PhabricatorDashboardPanelEditproController and PhabricatorDashboardPanelEditController, and they don't have the same code, and we're keeping both of them? Did you write one, forget about it, couldn't find it because of the incorrect name, and write it again?

This revision is now accepted and ready to land.Apr 3 2019, 6:50 PM

Ok this makes more sense now that I've looked at the follow up revisions.

I think the backstory was that Editpro got built out just enough to support a *.edit API for T10855, but finishing it would have been a much larger amount of work (i.e., the work I'm doing now) so I just paused us in a sketchy-but-stable state with both controllers in existence. The plan was always for Editpro to replace Edit some day (and that day is D20371).

This revision was automatically updated to reflect the committed changes.