Page MenuHomePhabricator

Mostly replace the old panel "Edit" controller with the new "Editpro" controller
ClosedPublic

Authored by epriestley on Apr 2 2019, 6:00 PM.

Details

Summary

Depends on D20370. Ref T13272. This tries to get panel editing fully on the newer "Modular Transactions" + "EditEngine" flow.

This breaks tab panels a bit, but I'll fix that in a followup. And they weren't exactly in great shape before.

Also makes the flow prettier. :3

Test Plan

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Apr 2 2019, 6:00 PM
epriestley requested review of this revision.Apr 2 2019, 6:02 PM
epriestley added inline comments.Apr 2 2019, 6:05 PM
src/applications/dashboard/controller/panel/PhabricatorDashboardPanelEditController.php
1

The actual diff is a mess here, but basically I deleted EditController (old), moved EditproController (new) on top of it, and then fixed up the "Create a Panel Directly on a Dashboard" flow. You can sort of ignore the left side of the diff in this file.

amckinley accepted this revision.Apr 3 2019, 7:04 PM
This revision is now accepted and ready to land.Apr 3 2019, 7:04 PM
This revision was automatically updated to reflect the committed changes.