Page MenuHomePhabricator

Mostly replace the old panel "Edit" controller with the new "Editpro" controller

Authored by epriestley on Apr 2 2019, 6:00 PM.



Depends on D20370. Ref T13272. This tries to get panel editing fully on the newer "Modular Transactions" + "EditEngine" flow.

This breaks tab panels a bit, but I'll fix that in a followup. And they weren't exactly in great shape before.

Also makes the flow prettier. :3

Test Plan

Screen Shot 2019-04-02 at 10.38.19 AM.png (422×916 px, 42 KB)

Diff Detail

rP Phabricator
Lint Not Applicable
Tests Not Applicable

Event Timeline


The actual diff is a mess here, but basically I deleted EditController (old), moved EditproController (new) on top of it, and then fixed up the "Create a Panel Directly on a Dashboard" flow. You can sort of ignore the left side of the diff in this file.

This revision is now accepted and ready to land.Apr 3 2019, 7:04 PM
This revision was automatically updated to reflect the committed changes.