When a dropdown menu would render in a way that hides it offscreen, try a different alignment
ClosedPublic
Actions

Authored by epriestley on Apr 8 2019, 5:31 PM.

Details

Reviewers

amckinley

Maniphest Tasks

Commits

Summary

Depends on D20382. Ref T13272. When something near the edge of the screen has a dropdown menu, we currently may render the menu offscreen.

Instead, keep the menu onscreen.

(This is happening because I'm adding dropdown menus to tab query panels.)

Test Plan

Before:

After:

Repository

rP Phabricator

Branch

portal25

Lint

Lint Passed

Unit

No Test Coverage

Build Status

	Time	Test
	250 ms	PhabricatorCelerityTestCase::testCelerityMaps Assertion failed, expected 'true' (at PhabricatorCelerityTestCase.php:32): When this test fails, it means the Celerity resource map is out of date. Run `bin/celerity map` to rebuild it. ACTUAL VALUE
	1 ms	AlmanacNamesTestCase::testServiceOrDeviceNames 30 assertions passed.
	0 ms	AlmanacServiceTypeTestCase::testGetAllServiceTypes 1 assertion passed.
	0 ms	AphrontHTTPSinkTestCase::testHTTPHeaderNames 2 assertions passed.
	0 ms	AphrontHTTPSinkTestCase::testHTTPSinkBasics 3 assertions passed.
		View Full Test Results (1 Failed · 356 Passed)